Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #6127 - Entity explorer - cloned page widget highlight #6441

Merged
merged 3 commits into from
Aug 17, 2021

Conversation

ashit-rath
Copy link
Contributor

@ashit-rath ashit-rath commented Aug 6, 2021

Fixes #6127

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/6127-highlight-cloned-widgets 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.87 (0.04) 37.03 (0.01) 33.21 (0.04) 55.45 (0.04)
🟢 app/client/src/pages/Editor/Explorer/Widgets/WidgetContextMenu.tsx 73.68 (42.1) 16.67 (16.67) 66.67 (66.67) 72.97 (40.54)
🟢 app/client/src/pages/Editor/Explorer/Widgets/WidgetEntity.tsx 98 (-0.08) 82.98 (3.39) 100 (0) 100 (0)
🟢 app/client/src/sagas/PageSagas.tsx 23.77 (0.17) 6.25 (0) 14.29 (0) 25.54 (0.18)

marks0351
marks0351 previously approved these changes Aug 9, 2021
@YogeshJayaseelan
Copy link
Contributor

@marks0351 Tested this fix - on selecting a single widget and on cloning the page the clone functionality is working as expected. But if the user selected multiple widget and when the page is cloned the Copy, Cut and Delete button goes out of the canvas

https://www.loom.com/share/aba9249e475b4f53b109b5a6042136e8

@marks0351
Copy link
Contributor

@YogeshJayaseelan I think it is a bug in prod too and is not linked to this bug but let's fix it with this PR.
@ashit-rath can u clear selected widgets when we are done cloning a page?

Copy link
Contributor

@marks0351 marks0351 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good @ashit-rath can u pls clean up the conflicts.

@ashit-rath ashit-rath enabled auto-merge (squash) August 17, 2021 12:37
@ashit-rath ashit-rath merged commit 2bd2565 into release Aug 17, 2021
@ashit-rath ashit-rath deleted the fix/6127-highlight-cloned-widgets branch August 17, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Cloned widgets also get highlighted when the original widgets get highlighted and vice versa
3 participants