-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove Postgres v13 from base image #34740
Conversation
WalkthroughThe change updates the PostgreSQL version from 13 to 14 in the Docker base image setup, ensuring compatibility with newer features and improvements. This alteration is a straightforward version upgrade in the Docker configuration, impacting how the database environment is set up within containers. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- deploy/docker/base.dockerfile (1 hunks)
Files skipped from review due to trivial changes (1)
- deploy/docker/base.dockerfile
1. This was kept for a short grace period, to be removed once we're confident of upgrading to v14. 2. The `pg-upgrade.sh` script is capable of handling this. It will install v13 when upgrading to v14, if it's not already available. See: https://github.com/appsmithorg/appsmith/blob/2adb12d57bef55de353ba25dd7123be7ae370598/deploy/docker/fs/opt/appsmith/pg-upgrade.sh#L53-L54 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated PostgreSQL version in Docker setup from 13 to 14 for improved performance and security. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
pg-upgrade.sh
script is capable of handling this. It will install v13 when upgrading to v14, if it's not already available. See:appsmith/deploy/docker/fs/opt/appsmith/pg-upgrade.sh
Lines 53 to 54 in 2adb12d
Summary by CodeRabbit