Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove Postgres v13 from base image #34740

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Conversation

sharat87
Copy link
Member

@sharat87 sharat87 commented Jul 5, 2024

  1. This was kept for a short grace period, to be removed once we're confident of upgrading to v14.
  2. The pg-upgrade.sh script is capable of handling this. It will install v13 when upgrading to v14, if it's not already available. See:
    apt-get update
    apt-get install --yes "postgresql-$old_version"

Summary by CodeRabbit

  • Chores
    • Updated PostgreSQL version in Docker setup from 13 to 14 for improved performance and security.

Copy link
Contributor

coderabbitai bot commented Jul 5, 2024

Walkthrough

The change updates the PostgreSQL version from 13 to 14 in the Docker base image setup, ensuring compatibility with newer features and improvements. This alteration is a straightforward version upgrade in the Docker configuration, impacting how the database environment is set up within containers.

Changes

File Change Summary
deploy/docker/base.dockerfile Updated PostgreSQL version from 13 to 14 in the installation step

Poem

In Docker’s sea, a change so grand,
PostgreSQL 14 now takes its stand.
Version numbers rise, oh what a scene,
With upgrades aplenty, bright and keen.
The bunnies cheer, with code so spry,
Each update lifts us to the sky! 🌟🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Jul 5, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2adb12d and fd19d48.

Files selected for processing (1)
  • deploy/docker/base.dockerfile (1 hunks)
Files skipped from review due to trivial changes (1)
  • deploy/docker/base.dockerfile

@sharat87 sharat87 merged commit bf6fd3f into release Jul 5, 2024
16 checks passed
@sharat87 sharat87 deleted the chore/no-pg-13 branch July 5, 2024 12:25
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this pull request Jul 10, 2024
1. This was kept for a short grace period, to be removed once we're
confident of upgrading to v14.
2. The `pg-upgrade.sh` script is capable of handling this. It will
install v13 when upgrading to v14, if it's not already available. See:
https://github.com/appsmithorg/appsmith/blob/2adb12d57bef55de353ba25dd7123be7ae370598/deploy/docker/fs/opt/appsmith/pg-upgrade.sh#L53-L54


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Chores**
- Updated PostgreSQL version in Docker setup from 13 to 14 for improved
performance and security.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants