test: fix flaky iconButton2 spec #33901

NandanAnantharamu · 2024-06-01T04:38:09Z

RCA: exeternal website used in this case "Yahoo.com"

Solution:

so replacing third party url should fix our problem.
used stubbing option to validate the navigation to new window.

coderabbitai · 2024-06-01T04:38:15Z

Walkthrough

The changes to the Cypress tests involve updating the onClick event handler in the IconButton_2_spec.ts file to open a URL in a new window instead of the same window. Additionally, a stub for window.open is added to prevent opening new tabs during testing. The configuration file limited-tests.txt is updated to reflect the new spec file path.

Changes

File Path	Change Summary
`app/client/cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts`	Updated `onClick` event to open URL in a new window and added a stub for `window.open`.
`app/client/cypress/limited-tests.txt`	Updated spec file path from `Fork_Template_spec.js` to `IconButton_2_spec.ts`.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant IconButton
    participant Browser
    participant TestStub

    User->>IconButton: Click on IconButton
    IconButton->>Browser: window.open('https://host.docker:4200/', '_blank')
    Browser->>TestStub: Trigger window.open stub
    TestStub->>Browser: Prevent actual window opening
    Browser-->>User: New window/tab is stubbed

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

NandanAnantharamu · 2024-06-01T04:39:00Z

/ci-test-limit

github-actions · 2024-06-01T04:39:35Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/9327660161.
Cypress dashboard
PR: #33901.

coderabbitai

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts (1)
Line range hint 29-54: Consider converting these function expressions to arrow functions for consistency and to align with modern JavaScript practices.
- function () {
+ () => {
Also applies to: 17-290

github-actions · 2024-06-01T05:01:55Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9327660161.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

NandanAnantharamu · 2024-06-01T06:02:29Z