test: remove startRoutesForDatasource from commands

[NandanAnantharamu]

Removed startRoutesForDatasource from Commands file and replaced with StartDataSourceRoutes from support/Pages/DataSources

[coderabbitai]

Walkthrough

The recent changes involve updating the initialization method for data source routes in Cypress test files. The previous cy.startRoutesForDatasource() method has been replaced with dataSources.StartDataSourceRoutes(). This update impacts multiple test suites across client-side and server-side tests, aiming to standardize the data source setup process. Additionally, the startRoutesForDatasource command has been removed from the Cypress commands file.

Changes

File Path	Change Summary
.../ClientSide/Binding/JSObject_Postgress_Table_spec.js	Replaced cy.startRoutesForDatasource() with _.dataSources.StartDataSourceRoutes() in beforeEach().
.../ClientSide/ExplorerTests/CopyQuery_RenameDatasource_spec.js .../ClientSide/ExplorerTests/Query_Datasource_spec.js .../ClientSide/OtherUIFeatures/GlobalSearch_spec.js	Replaced cy.startRoutesForDatasource() with dataSources.StartDataSourceRoutes() in beforeEach().
.../ServerSide/GenerateCRUD/S3_Spec.js .../ServerSide/Params/ExecutionParams_spec.js .../ServerSide/QueryPane/AddWidgetTableAndBind_spec.js .../ServerSide/QueryPane/AddWidget_spec.js .../ServerSide/QueryPane/EmptyDataSource_spec.js .../ServerSide/QueryPane/S3_1_spec.js .../ServerSide/QueryPane/SwitchDatasource_spec.js	Replaced cy.startRoutesForDatasource() with dataSources.StartDataSourceRoutes() in beforeEach(). Removed commented-out code related to test cleanup.
.../Sanity/Datasources/ElasticSearchDatasource_spec.js .../Sanity/Datasources/MySQLNoiseTest_spec.js .../Sanity/Datasources/MySQL_spec.js .../Sanity/Datasources/PostgresDatasource_spec.js .../Sanity/Datasources/RedshiftDataSourceStub_spec.js .../Sanity/Datasources/SMTPDatasource_spec.js	Replaced cy.startRoutesForDatasource() with dataSources.StartDataSourceRoutes() in beforeEach().
.../limited-tests.txt	Updated spec names and paths for limited tests.
.../support/commands.js	Removed Cypress.Commands.add("startRoutesForDatasource", () => {...}) and related route intercepts for datasources.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[NandanAnantharamu]

/ci-test-limit

[github-actions]

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/9203973302.
Cypress dashboard
PR: #33688.

[coderabbitai]

Actionable comments posted: 1

Outside diff range and nitpick comments (1)

app/client/cypress/limited-tests.txt (1)

Line range hint 23-23: Consider adding "the" for grammatical correctness.

-#ci-test-limit uses this file to run minimum of specs. Do not run entire suite with this command.
+#ci-test-limit uses this file to run the minimum of specs. Do not run the entire suite with this command.

[coderabbitai]

Consider adding "the" for grammatical correctness.

-# To run only limited tests - give spec names in below format:
+# To run only limited tests - give the spec names in the below format:

---

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change

	# To run only limited tests - give the spec names in below format:
	# To run only limited tests - give the spec names in the below format:

[github-actions]

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9203973302.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉