-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: updated queryCommands file #33629
Conversation
WalkthroughWalkthroughThe recent update involves the removal of several custom Cypress commands from the Changes
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Outside diff range and nitpick comments (3)
app/client/cypress/support/queryCommands.js (3)
Line range hint
1-1
: Ensure ESLint rules are still relevant after command removals.Consider reviewing the ESLint rules
cypress/no-unnecessary-waiting
andcypress/no-assigning-return-values
to ensure they are still applicable given the reduced number of commands.
Line range hint
1-1
: Consider reducing hard-coded waits.The use of
cy.wait(2000)
in commands likeNavigateToDSGeneratePage
andrunQuery
could be replaced with more dynamic waiting mechanisms to improve test reliability and performance.
[!TIP]
Codebase VerificationThe search results indicate that there are still references to the
deleteQueryUsingContext
command in multiple files. This suggests that the command might not have been fully removed or that there are lingering references that need to be addressed.
app/client/cypress/support/queryCommands.js
app/client/cypress/e2e/Sanity/Datasources/PostgresDatasource_spec.js
app/client/cypress/e2e/Sanity/Datasources/RedshiftDataSourceStub_spec.js
app/client/cypress/e2e/Sanity/Datasources/MySQL_spec.js
app/client/cypress/e2e/Sanity/Datasources/MsSQLDataSourceStub_spec.js
app/client/cypress/e2e/Sanity/Datasources/ArangoDataSourceStub_spec.js
app/client/cypress/e2e/Sanity/Datasources/MySQLDataSourceStub_spec.js
app/client/cypress/e2e/Regression/ClientSide/ExplorerTests/Query_Datasource_spec.js
app/client/cypress/e2e/Regression/ServerSide/QueryPane/S3_1_spec.js
app/client/cypress/e2e/Regression/ServerSide/QueryPane/Postgres_Spec.js
app/client/cypress/e2e/Regression/ServerSide/QueryPane/Mongo_Spec.js
Please review these files and remove or update the references to
deleteQueryUsingContext
as necessary.Analysis chain
Line range hint
1-1
: Verify removal of all references to deleted commands.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that there are no lingering references to the removed commands in the codebase. # Test: Search for the removed commands. Expect: No occurrences. rg --type python $'fillGoogleSheetsDatasourceForm|RunQueryWithoutWaitingForResolution|hoverAndClickParticularIndex|deleteQuery|CreateMockQuery|SelecJSFunctionAndRun'Length of output: 197
Script:
#!/bin/bash # Description: Verify that there are no lingering references to the removed commands in the codebase. # Test: Search for the removed commands. Expect: No occurrences. rg --type js $'fillGoogleSheetsDatasourceForm|RunQueryWithoutWaitingForResolution|hoverAndClickParticularIndex|deleteQuery|CreateMockQuery|SelecJSFunctionAndRun'Length of output: 2742
RCA: There are many unused commands within queryCommands.js file
Solution:
Checked the queryCommands in both CE and EE repository and we are removing those commands which are not used in any tests as part of cleanup activity
Equivalent EE PR: https://github.com/appsmithorg/appsmith-ee/pull/4280
/ok-to-test tags="@tag.All"
Tip
馃煝 馃煝 馃煝 All cypress tests have passed! 馃帀 馃帀 馃帀
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/9184621910
Commit: 5a42872
Cypress dashboard url: Click here!