-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix JsObjectMutation flaky test #32936
Conversation
WalkthroughThe change involves enhancing the Cypress test suite by adding a new assertion for DOM element verification and introducing a new declaration in the Changes
Possibly related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
/ci-test-limit |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8827703741. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (1)
app/client/cypress/limited-tests.txt (1)
Line range hint
7-7
: Consider adding an article before "minimum" for grammatical correctness.- #ci-test-limit uses this file to run minimum of specs. Do not run entire suite with this command. + #ci-test-limit uses this file to run a minimum of specs. Do not run entire suite with this command.
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8827703741. |
/ci-test-limit runId=8827703741 |
7 similar comments
/ci-test-limit runId=8827703741 |
/ci-test-limit runId=8827703741 |
/ci-test-limit runId=8827703741 |
/ci-test-limit runId=8827703741 |
/ci-test-limit runId=8827703741 |
/ci-test-limit runId=8827703741 |
/ci-test-limit runId=8827703741 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8828659969. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8828661256. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8828661598. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8828662121. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8828661026. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8828663577. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8828662649. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8828663674. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8828661598. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8828661026. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8828662121. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8828661256. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8828659969. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8828663674. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8831704629. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8831704088. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8831703423. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8831702480. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8831702735. |
/ci-test-limit runId=8827703741 |
5 similar comments
/ci-test-limit runId=8827703741 |
/ci-test-limit runId=8827703741 |
/ci-test-limit runId=8827703741 |
/ci-test-limit runId=8827703741 |
/ci-test-limit runId=8827703741 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8833280786. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8833283048. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8833284062. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8833285000. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8833286214. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8833288116. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8833284062. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8833286214. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8833288116. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8833285000. |
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8833280786. |
RCA:
Summary by CodeRabbit
CommonLocators
class for improved test reliability.