test: fix migration spec #32920

NandanAnantharamu · 2024-04-24T12:19:52Z

RCA:
Migration spec was having duplicate code and click on image link and navigation back was causing issues
Solution:
1.Removed redundant code
2.stub image click event and validate rather than navigating to actual image url which is external.

Summary by CodeRabbit

Bug Fixes
- Removed stubbing of window.open to ensure new tabs open correctly.
- Enhanced validation checks for table data, widget mappings, and credit limit computations.
- Improved state button interactions and menu button validations for smoother user experience.
- Optimized performance by eliminating redundant code and unnecessary wait times.
- Refined page validation and code editor content accuracy.

coderabbitai · 2024-04-24T12:20:00Z

Walkthrough

This update focuses on refining the Cypress test suite for a client-side application by enhancing validations, removing inefficiencies, and improving test reliability related to widget operations and page interactions. The adjustments include reorganized validation steps, updated checks for credit limit computations, and the removal of unnecessary code and waits.

Changes

File Path	Change Summary
`.../cypress/e2e/Regression/ClientSide/...`	Updated validations for table data, widget mappings, and credit limit computations; removed redundant code and unnecessary waits; refactored and reorganized various checks.

Possibly related issues

[Task]: Fix cypress test suite failures caused by PR #29794 #30378: The changes in this PR could potentially address the failures mentioned as they enhance the stability and reliability of the test suite, which aligns with the objective to ensure the test suite runs successfully.
[Task] - Cypress failure on mouse move #31263: Although this PR does not directly address mouse move actions, the general improvements in test reliability and removal of unnecessary waits could indirectly benefit the stability of mouse-related tests.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4350781 and a8914c4.

Files selected for processing (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/Migration_Spec.js (3 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/Migration_Spec.js

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json