test: Tree_Select_2_spec - Added toggle JS assertions before updating trigger functions #32873

NandanAnantharamu · 2024-04-23T08:28:01Z

Description

Spec has been flaky because when JS toggle is on a property in edit mode it should remain after entering edit mode from deployed mode. In this PR, we are going to check if JS mode on for each trigger paths and if not, toggle JS mode before adding trigger functions in each test.
We were asserting external URL(google.com) for Navigate To functionality and navigating back from external URL using BrowserNavigation to app was creating flakiness. Now we will be stubbing the URL for same window.

Link - Spec 36 https://www.notion.so/appsmith/Cypress-tests-analysis-4090efa5e3064a2e87f262d3c399a339
Phase 1

Summary by CodeRabbit

Tests
- Enhanced test scenarios to assert the state of JavaScript toggles in the Tree Select widget.
New Features
- Introduced a method to toggle and verify JavaScript mode in the Property Pane.

coderabbitai · 2024-04-23T08:28:09Z

Walkthrough

The changes involve enhancing Cypress testing for the TreeSelect widget and PropertyPane class. This includes adding functionality to toggle JavaScript mode and verifying its state, as well as refining tests to assert the JavaScript toggle's state based on specific conditions.

Changes

File Path	Change Summary
`.../cypress/e2e/.../TreeSelect/Tree_Select_2_spec.ts`	Asserted JS toggle state as "enabled" or "disabled" in test scenarios. Stubbed `window.open` to prevent new tabs. Changed spec file path.
`.../cypress/support/Pages/PropertyPane.ts`	Added `ToggleJS` method to manage and verify JavaScript mode toggling.

Possibly related issues

[Task]: Fix cypress test suite failures caused by PR #29794 #30378: The enhancements in this PR could potentially address test failures related to the JS toggle functionality, aligning with the objectives outlined in the issue.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

NandanAnantharamu · 2024-04-23T08:28:31Z

/ci-test-limit

github-actions · 2024-04-23T08:29:03Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8797277577.
Cypress dashboard
PR: #32873.

NandanAnantharamu · 2024-04-23T10:17:05Z

/ci-test-limit runId=8797277577

NandanAnantharamu · 2024-04-23T10:20:01Z

/ci-test-limit runId=8797277577

github-actions · 2024-04-23T10:20:30Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8798774725.
Cypress dashboard
PR: #32873.

NandanAnantharamu · 2024-04-23T11:00:47Z

/ci-test-limit runId=8797277577

github-actions · 2024-04-23T11:01:18Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8799264881.
Cypress dashboard
PR: #32873.

github-actions · 2024-04-23T11:12:45Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8799264881.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

NandanAnantharamu · 2024-04-23T11:38:20Z

/ci-test-limit runId=8797277577

NandanAnantharamu · 2024-04-23T11:38:26Z

/ci-test-limit runId=8797277577

NandanAnantharamu · 2024-04-23T11:38:31Z

/ci-test-limit runId=8797277577

github-actions · 2024-04-23T11:38:52Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8799742043.
Cypress dashboard
PR: #32873.

github-actions · 2024-04-23T11:38:58Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8799743036.
Cypress dashboard
PR: #32873.

github-actions · 2024-04-23T11:39:05Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8799744307.
Cypress dashboard
PR: #32873.

github-actions · 2024-04-23T11:49:30Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8799744307.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-04-23T11:49:33Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8799742043.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-04-23T11:50:02Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8799743036.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

NandanAnantharamu · 2024-04-23T11:54:12Z

/ci-test-limit runId=8797277577

NandanAnantharamu · 2024-04-23T11:54:29Z

/ci-test-limit runId=8797277577

github-actions · 2024-04-30T08:39:10Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8891684703.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-04-30T08:39:17Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8891683021.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

ApekshaBhosale · 2024-04-30T09:01:36Z

/ci-test-limit runId=8891293893

ApekshaBhosale · 2024-04-30T09:01:40Z

/ci-test-limit runId=8891293893

ApekshaBhosale · 2024-04-30T09:01:42Z

/ci-test-limit runId=8891293893

ApekshaBhosale · 2024-04-30T09:01:44Z

/ci-test-limit runId=8891293893

ApekshaBhosale · 2024-04-30T09:01:46Z

/ci-test-limit runId=8891293893

github-actions · 2024-04-30T09:02:10Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8892123017.
Cypress dashboard
PR: #32873.

github-actions · 2024-04-30T09:02:13Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8892122669.
Cypress dashboard
PR: #32873.

github-actions · 2024-04-30T09:02:15Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8892124968.
Cypress dashboard
PR: #32873.

github-actions · 2024-04-30T09:02:16Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8892124096.
Cypress dashboard
PR: #32873.

github-actions · 2024-04-30T09:02:17Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8892125118.
Cypress dashboard
PR: #32873.

github-actions · 2024-04-30T09:12:59Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8892124096.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-04-30T09:13:03Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8892125118.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-04-30T09:13:06Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8892124968.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-04-30T09:13:16Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8892122669.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-04-30T09:13:42Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8892123017.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

trishaanand · 2024-04-30T17:26:15Z

@ApekshaBhosale : The PR title and description needs to be updated. The code changes LGTM.

NandanAnantharamu added 2 commits April 23, 2024 13:55

updated tests for Treeselect2

2bc3b8a

updated limited test spec

1fc7fed

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Apr 23, 2024

updated test with wait for element to appear

52bb222

added a new assertion to avoid hard waits

700e315

NandanAnantharamu requested a review from ApekshaBhosale April 23, 2024 11:38

NandanAnantharamu requested a review from trishaanand April 23, 2024 11:38

NandanAnantharamu closed this Apr 23, 2024

NandanAnantharamu reopened this Apr 23, 2024

removed limited test

030c265

ApekshaBhosale requested a review from trishaanand April 30, 2024 11:52

ApekshaBhosale changed the title ~~test: Test/fix tree select2~~ fix: Tree_Select_2_spec - Added toggle JS assertions before updating trigger functions Apr 30, 2024

github-actions bot added Bug Something isn't working and removed skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Apr 30, 2024

ApekshaBhosale changed the title ~~fix: Tree_Select_2_spec - Added toggle JS assertions before updating trigger functions~~ test: Tree_Select_2_spec - Added toggle JS assertions before updating trigger functions Apr 30, 2024

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test and removed Bug Something isn't working labels Apr 30, 2024

trishaanand merged commit 6905d85 into release May 1, 2024
25 of 27 checks passed

trishaanand deleted the test/fixTreeSelect2 branch May 1, 2024 05:16

test: Tree_Select_2_spec - Added toggle JS assertions before updating trigger functions #32873

test: Tree_Select_2_spec - Added toggle JS assertions before updating trigger functions #32873

Conversation

NandanAnantharamu commented Apr 23, 2024 • edited by ApekshaBhosale Loading

Description

Summary by CodeRabbit

coderabbitai bot commented Apr 23, 2024 • edited Loading

Walkthrough

Changes

Possibly related issues

Chat

CodeRabbit Commands (invoked as PR comments)

CodeRabbit Configration File (.coderabbit.yaml)

Documentation and Community

NandanAnantharamu commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

NandanAnantharamu commented Apr 23, 2024

NandanAnantharamu commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

NandanAnantharamu commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

NandanAnantharamu commented Apr 23, 2024

NandanAnantharamu commented Apr 23, 2024

NandanAnantharamu commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

github-actions bot commented Apr 23, 2024

NandanAnantharamu commented Apr 23, 2024

NandanAnantharamu commented Apr 23, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

ApekshaBhosale commented Apr 30, 2024

ApekshaBhosale commented Apr 30, 2024

ApekshaBhosale commented Apr 30, 2024

ApekshaBhosale commented Apr 30, 2024

ApekshaBhosale commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

github-actions bot commented Apr 30, 2024

trishaanand commented Apr 30, 2024

NandanAnantharamu commented Apr 23, 2024 •

edited by ApekshaBhosale

Loading

coderabbitai bot commented Apr 23, 2024 •

edited

Loading

CodeRabbit Configration File (`.coderabbit.yaml`)