test: updated test for DataIdentifier #32752

NandanAnantharamu · 2024-04-18T02:32:20Z

DataIdentifier test fix
app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/DataIdentifier_spec.ts

RCA:
Exeternal API was the main reason for failure

external API was used
Replaced with TED API

Removed unwanted wait

Summary by CodeRabbit

Bug Fixes
- Improved the reliability of list loading in automated tests by removing unnecessary delays.
- Enhanced data processing in lists by modifying the data configuration format.
- Updated test configuration to use the correct spec file path for limited tests.
- Added interactions with EditorNavigation and propPane for selecting entities and properties in the test scenario.
- Added a new declaration _dropdownControlError to the PropertyPane class, representing a selector for dropdown control errors.

coderabbitai · 2024-04-18T02:32:27Z

Walkthrough

The update focuses on enhancing test reliability in the Cypress test suite by removing a redundant sleep function call in the test setup. This change aims to streamline test execution and mitigate potential flakiness associated with list loading. Additionally, interactions with EditorNavigation and propPane have been incorporated for selecting entities and properties in test scenarios.

Changes

File Path	Change Summary
`.../cypress/e2e/Regression/ClientSide/Widgets/ListV2/DataIdentifier_spec.ts`	Removed a sleep function call in the `before` hook. Added interactions with `EditorNavigation` and `propPane`.
`.../cypress/config/limited_tests_config.json`	Updated spec file path from `Fork_Template_spec.js` to `DataIdentifier_spec.ts`.

Possibly related issues

[Task]: Fix cypress test suite failures caused by PR #29794 #30378: The removal of the sleep function call aligns with the objective to address failures in the Cypress test suite and ensure successful test execution without any issues. This change could contribute to resolving the test failures mentioned in this issue.

Recent Review Details

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between e780f8f and 49cadfe.

Files selected for processing (2)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/DataIdentifier_spec.ts (1 hunks)
app/client/cypress/support/Pages/PropertyPane.ts (1 hunks)

Files skipped from review as they are similar to previous changes (1)

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/DataIdentifier_spec.ts

Additional comments not posted (1)

app/client/cypress/support/Pages/PropertyPane.ts (1)

175-175: Ensure the new selector _dropdownControlError matches the expected HTML structure and is used appropriately within the class.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

NandanAnantharamu · 2024-04-18T02:36:59Z

/ci-test-limit

github-actions · 2024-04-18T02:37:28Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8731597355.
Cypress dashboard
PR: #32752.

github-actions · 2024-04-18T02:58:45Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8731597355.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

NandanAnantharamu · 2024-04-18T05:03:40Z

/ci-test-limit

NandanAnantharamu · 2024-04-18T05:03:47Z

/ci-test-limit

NandanAnantharamu · 2024-04-18T05:03:53Z

/ci-test-limit

github-actions · 2024-04-18T05:04:16Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8732655549.
Cypress dashboard
PR: #32752.

github-actions · 2024-04-18T05:04:19Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8732655107.
Cypress dashboard
PR: #32752.

github-actions · 2024-04-18T05:04:21Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8732656705.
Cypress dashboard
PR: #32752.

github-actions · 2024-04-18T05:24:37Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8732655549.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-04-18T05:25:53Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8732655107.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

github-actions · 2024-04-18T05:26:12Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8732656705.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

trishaanand · 2024-04-18T13:33:59Z

app/client/cypress/fixtures/Listv2/ListV2WithNullPrimaryKey.json

@@ -25,7 +25,7 @@
 "triggeredItemView": "{{{}}}",
 "widgetName": "List1",
 "requiresFlatWidgetChildren": true,
- "listData": "{{Api1.data}}",
+ "listData": "[{{Api1.data}}]",


Is Api.data not returning an array that we need to introduce this extra square brackets?

Without Big bracket i get this error message

With Bracket which makes it array dismisses that error

trishaanand · 2024-04-18T13:34:51Z

app/client/cypress/e2e/Regression/ClientSide/Widgets/ListV2/DataIdentifier_spec.ts

@@ -38,7 +38,6 @@ describe(
 () => {
 before(() => {
 agHelper.AddDsl("Listv2/ListV2WithNullPrimaryKey");
- agHelper.Sleep(3000); //for List to load for CI flakyness


Sorry, the RCA doesn't cover the data identifier issue and the solution for it. Could you please add some background? Thanks!

i have added more details with snapshots

NandanAnantharamu · 2024-04-19T08:50:17Z

/ci-test-limit

github-actions · 2024-04-19T08:50:48Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/8750959332.
Cypress dashboard
PR: #32752.

github-actions · 2024-04-19T09:11:08Z

Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/8750959332.
Cypress dashboard url: Click here!
All cypress tests have passed 🎉🎉🎉

NandanAnantharamu · 2024-04-19T09:41:31Z