Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: persists query param in redirect urls #13738

Merged
merged 3 commits into from
May 11, 2022
Merged

fix: persists query param in redirect urls #13738

merged 3 commits into from
May 11, 2022

Conversation

arunvjn
Copy link
Contributor

@arunvjn arunvjn commented May 11, 2022 •
edited by github-actions bot
Loading

Description

Fixes truncated query params in redirect URLs

Fixes #11422

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Cypress

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed No changes to code coverage between the base branch and the head branch

@vercel
Copy link

vercel bot commented May 11, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 11, 2022 at 6:19AM (UTC)

@arunvjn arunvjn requested review from albinAppsmith and akash-codemonk and removed request for albinAppsmith May 11, 2022 06:14
@arunvjn
Copy link
Contributor Author

arunvjn commented May 11, 2022

/ok-to-test sha=dc059d6

@github-actions github-actions bot added Bug Something isn't working Community Reported issues reported by community members High This issue blocks a user from building or impacts a lot of users Login / Signup Authentication flows Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Platform Pod Team Managers Pod Issues that team managers care about for the security and efficiency of their teams labels May 11, 2022
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2305259824.
Workflow: Appsmith External Integration Test Workflow.
Commit: dc059d6.
PR: 13738.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2305259824.
Commit: dc059d6.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2080.32 2056.3 2054.34 2028.62 2076.62 2056.3 2059.24 1.01 0.90
painting 14.74 11.72 20.02 15.15 15.68 15.15 15.46 19.28 17.21
rendering 696.81 704.64 743.16 704.25 692.82 704.25 708.34 2.84 2.54
SELECT_WIDGET_SELECT_OPTION
scripting 424.47 437.19 358.27 318.79 446.63 424.47 397.07 14.05 12.57
painting 4.08 4.67 4.03 4.17 9.13 4.17 5.22 42.15 37.74
rendering 29.37 32.09 21.02 22.3 24.98 24.98 25.95 18.07 16.15

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2305259824.
Commit: dc059d6.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2080.32 2056.3 2054.34 2028.62 2076.62 2056.3 2059.24 1.01 0.90
painting 14.74 11.72 20.02 15.15 15.68 15.15 15.46 19.28 17.21
rendering 696.81 704.64 743.16 704.25 692.82 704.25 708.34 2.84 2.54
SELECT_WIDGET_SELECT_OPTION
scripting 424.47 437.19 358.27 318.79 446.63 424.47 397.07 14.05 12.57
painting 4.08 4.67 4.03 4.17 9.13 4.17 5.22 42.15 37.74
rendering 29.37 32.09 21.02 22.3 24.98 24.98 25.95 18.07 16.15

@trishaanand trishaanand merged commit ae22baa into release May 11, 2022
@trishaanand trishaanand deleted the fix/persist-query-param-on-login branch May 11, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akash-codemonk akash-codemonk akash-codemonk approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Community Reported issues reported by community members High This issue blocks a user from building or impacts a lot of users Login / Signup Authentication flows Needs Triaging Needs attention from maintainers to triage New Developers Pod Issues that new developers face while exploring the IDE Team Managers Pod Issues that team managers care about for the security and efficiency of their teams
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: On Login only the first parameter passed in url persists
3 participants
@arunvjn @akash-codemonk @trishaanand