Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hover state of renaming titles #13725

Merged
merged 1 commit into from
May 11, 2022

Conversation

ChandanBalajiBP
Copy link
Contributor

@ChandanBalajiBP ChandanBalajiBP commented May 10, 2022

Description

Added underline on hover for the titles in Queries, JS and Datasources.

Fixes #13329

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: Fix/Hover-state-of-renaming-titles 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 56.59 (0) 38.39 (0) 35.83 (-0.01) 56.83 (0)
🔴 app/client/src/components/editorComponents/EditableText.tsx 25 (-0.42) 14.63 (-0.75) 6.67 (-0.47) 27.27 (-0.51)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

@vercel
Copy link

vercel bot commented May 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 10, 2022 at 0:35AM (UTC)

@github-actions github-actions bot added the Bug Something isn't working label May 10, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@ChandanBalajiBP
Copy link
Contributor Author

/ok-to-test sha=01604bb2

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2305011027.
Workflow: Appsmith External Integration Test Workflow.
Commit: 01604bb2.
PR: 13725.

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2305011263.
Workflow: Appsmith External Integration Test Workflow.
Commit: 01604bb25a19ad4ef167ff3187bd33b51688f74d.
PR: 13725.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2305011263.
Commit: 01604bb25a19ad4ef167ff3187bd33b51688f74d.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2000.17 2039.74 2047.06 2029.68 1973.8 2029.68 2018.09 1.51 1.35
painting 19.59 18.97 15.43 13.48 15.87 15.87 16.67 15.36 13.74
rendering 719.6 687.84 728.97 693.98 706.11 706.11 707.3 2.43 2.17
SELECT_WIDGET_SELECT_OPTION
scripting 463.4 318.78 336.89 301.56 308.27 318.78 345.78 19.40 17.35
painting 3.73 6.03 4.18 5.02 3.46 4.18 4.48 23.44 20.98
rendering 22.27 21.62 21.74 21.93 21.76 21.76 21.86 1.14 1.05

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2305011027.
Commit: 01604bb2.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1747.21 1543.29 1899.07 1571.22 1828.29 1747.21 1717.82 9.11 8.14
painting 14.96 12.1 12.47 9.8 9.51 12.1 11.77 18.86 16.91
rendering 607.79 572.44 752.93 596.97 639.34 607.79 633.89 11.16 9.98
SELECT_WIDGET_SELECT_OPTION
scripting 317.76 272.05 336.05 338.05 296.73 317.76 312.13 8.95 8.00
painting 4.72 6.54 3.84 5.83 4.62 4.72 5.11 20.94 18.79
rendering 22.03 19.19 21.65 19.61 22.03 21.65 20.9 6.65 5.93
SELECT_CATEGORY
scripting 738.81 801.2 744.1 1269.81 818.95 801.2 874.57 25.58 22.88
painting 4.95 4.22 3.99 9.21 6.32 4.95 5.74 37.28 33.45
rendering 285.52 313.52 298.19 476 333.85 313.52 341.42 22.66 20.27
BIND_TABLE_DATA
scripting 2887.31 2280.7 2317.04 2296.42 2285.9 2296.42 2413.47 10.99 9.83
painting 17.18 16.8 17.55 25.9 24.74 17.55 20.43 21.98 19.63
rendering 636.46 661.38 644.59 885.51 776.82 661.38 720.95 14.99 13.41
CLICK_ON_TABLE_ROW
scripting 1853.58 2071.7 2404.01 2225.4 2384.37 2225.4 2187.81 10.52 9.41
painting 22.01 27.08 19.46 17.84 17.2 19.46 20.72 19.35 17.33
rendering 285.86 340.07 357.23 317.51 346.68 340.07 329.47 8.62 7.71
UPDATE_POST_TITLE
scripting 4091.18 4110.11 4023.17 3010.08 4883.2 4091.18 4023.55 16.57 14.82
painting 15.96 26.7 21.53 13.91 17.52 17.52 19.12 26.52 23.74
rendering 423.03 426.65 523.41 372.97 539.11 426.65 457.03 15.58 13.94
OPEN_MODAL
scripting 3021 1243.46 1386.21 2062.35 1887.59 1887.59 1920.12 36.61 32.74
painting 13.02 12.86 18.1 13.07 14.94 13.07 14.4 15.56 13.89
rendering 469.39 433.59 455.54 422.48 583.85 455.54 472.97 13.67 12.22
CLOSE_MODAL
scripting 630.22 910.76 1814.53 2105.79 1146.92 1146.92 1321.64 46.88 41.93
painting 8.08 6.47 4.86 7.41 11.46 7.41 7.66 31.98 28.59
rendering 339 388.53 360.14 412.84 541.79 388.53 408.46 19.49 17.43

@ChandanBalajiBP ChandanBalajiBP merged commit 43758f6 into release May 11, 2022
@ChandanBalajiBP ChandanBalajiBP deleted the Fix/Hover-state-of-renaming-titles branch May 11, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]-[12000]:Fix hover state of renaming titles
2 participants