Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avoid pasting list widget inside another list widget #13719

Merged
merged 8 commits into from
May 11, 2022

Conversation

rahulramesha
Copy link
Contributor

@rahulramesha rahulramesha commented May 10, 2022

Description

Verify that the widget selected is list widget or inside list widget when one of the copied widget is a list widget.

Fixes #13609

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual testing, cypress and jest

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: copyPasteListWidgetFix 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 56.57 (-0.02) 38.35 (-0.04) 35.84 (0) 56.82 (-0.01)
🔴 app/client/src/sagas/WidgetOperationUtils.ts 68.93 (-2.47) 45.16 (-5.94) 68.49 (0.43) 68.52 (-2.66)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

@vercel
Copy link

vercel bot commented May 10, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 10, 2022 at 10:48AM (UTC)

@github-actions github-actions bot added Bug Something isn't working Copy Paste Issues related to copy paste Needs Triaging Needs attention from maintainers to triage Regressed Scenarios that were working before but have now regressed Release Release Blocker This issue must be resolved before the release UI Builders Pod Issues that UI Builders face using appsmith UI Building Pod labels May 10, 2022
@rahulramesha
Copy link
Contributor Author

/ok-to-test sha=6339dd5

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2300155710.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6339dd5.
PR: 13719.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2300155710.
Commit: 6339dd5.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 597.62 701.85 614.56 703.77 1781 701.85 879.76 57.53 51.46
painting 4.32 7.42 3.25 8 4.18 4.32 5.43 39.23 34.99
rendering 292.05 271.56 266.52 320.27 297.09 292.05 289.5 7.45 6.66
BIND_TABLE_DATA
scripting 2291.24 2343.79 2223.63 2183.24 2320.77 2291.24 2272.53 2.96 2.65
painting 24.36 16.74 13.97 8.87 20.29 16.74 16.85 35.13 31.45
rendering 608.18 556.34 504.53 490.19 544.39 544.39 540.73 8.61 7.70
CLICK_ON_TABLE_ROW
scripting 1886.41 1628.64 1467.18 1822.86 1729.06 1729.06 1706.83 9.70 8.68
painting 19.59 14.2 14.02 22.72 20.54 19.59 18.21 21.53 19.22
rendering 304.62 307.49 255.81 259.45 259.11 259.45 277.3 9.49 8.49
UPDATE_POST_TITLE
scripting 2606.06 3415.95 2377.26 3019.29 2182.13 2606.06 2720.14 18.32 16.39
painting 18.54 21.89 13.98 12.17 19.74 18.54 17.26 23.52 21.03
rendering 351.21 353.73 331.94 326.92 309.71 331.94 334.7 5.44 4.87
OPEN_MODAL
scripting 1087.72 1081.95 980.93 1083.63 1100.13 1083.63 1066.87 4.55 4.07
painting 9.6 19.51 11.38 9.43 9.28 9.6 11.84 36.91 33.02
rendering 404.33 393.46 378.79 414.84 375.14 393.46 393.31 4.27 3.82
CLOSE_MODAL
scripting 2215.66 755.54 680.04 719.76 520.71 719.76 978.34 71.29 63.77
painting 11.56 4.98 4.35 4.9 7.17 4.98 6.59 45.22 40.36
rendering 340.35 338.79 308.16 344.48 310.04 338.79 328.36 5.40 4.83
SELECT_WIDGET_MENU_OPEN
scripting 1405.98 1425.23 1400.8 1419.17 1445.14 1419.17 1419.26 1.23 1.10
painting 6.35 6.68 17.53 13.6 4.35 6.68 9.7 57.73 51.65
rendering 420.88 400.35 400.01 392.84 387.44 400.01 400.3 3.17 2.84
SELECT_WIDGET_SELECT_OPTION
scripting 181.24 199.22 176.51 170.01 168.1 176.51 179.02 6.95 6.22
painting 4.09 3.02 2.72 5.21 2.83 3.02 3.57 29.69 26.61
rendering 12.71 12.58 13.26 11.87 11.71 12.58 12.43 5.15 4.59

@rahulramesha rahulramesha merged commit 27d5ae8 into release May 11, 2022
@rahulramesha rahulramesha deleted the copyPasteListWidgetFix branch May 11, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Copy Paste Issues related to copy paste Needs Triaging Needs attention from maintainers to triage Regressed Scenarios that were working before but have now regressed Release Blocker This issue must be resolved before the release Release UI Builders Pod Issues that UI Builders face using appsmith
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: App crash on List widget when try copy/paste
2 participants