-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: prevent lint warnings from blocking execution in js objects #13700
fix: prevent lint warnings from blocking execution in js objects #13700
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
/ok-to-test sha=4d6c34a |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2297357273. |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2297357273. |
/ok-to-test sha=c4ce2ea |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2297826311. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2297826311. Click to view performance test results
|
Description
This PR ensures that only parse errors prevent the execution of js functions. Parse errors/ Lint errors within a function (that don't render the entire JS Object invalid) don't cause all functions to be unrunnable.
Fixes #12012
Type of change
How Has This Been Tested?
Cypress
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased