Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functionality to close modal when back overlay is clicked. #13669

Merged
merged 2 commits into from
May 10, 2022
Merged

Add functionality to close modal when back overlay is clicked. #13669

merged 2 commits into from
May 10, 2022

Conversation

Irongade
Copy link
Contributor

@Irongade Irongade commented May 9, 2022 •
edited by github-actions bot
Loading

Allow modal to be closed when the back overlay is clicked

Fixes #13101

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: feat/outside-click-close-modal
Status File % Stmts % Branch % Funcs % Lines
🟢 total 56.59 (0) 38.4 (0.01) 35.84 (0) 56.84 (0.01)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

@vercel
Copy link

vercel bot commented May 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 10, 2022 at 8:30AM (UTC)

@Irongade
Copy link
Contributor Author

Irongade commented May 9, 2022

/ok-to-test sha=5ee5d0d

@github-actions github-actions bot added Actions Pod BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production Core Query Execution Issues related to the execution of all queries UX Improvement labels May 9, 2022
@github-actions github-actions bot removed the Bug Something isn't working label May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

4 similar comments
@github-actions
Copy link

github-actions bot commented May 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented May 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented May 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented May 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added Bug Something isn't working and removed Bug Something isn't working labels May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented May 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2293390526.
Workflow: Appsmith External Integration Test Workflow.
Commit: 5ee5d0d.
PR: 13669.

@github-actions
Copy link

github-actions bot commented May 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2293390526.
Commit: 5ee5d0d.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2080.81 2014.01 2074.83 2124.73 2062.69 2074.83 2071.41 1.92 1.72
painting 27.45 23.16 31.38 13.12 23.82 23.82 23.79 28.63 25.60
rendering 905.3 900.74 899.42 915.06 904.98 904.98 905.1 0.68 0.61
SELECT_WIDGET_SELECT_OPTION
scripting 485.91 360.36 450.73 366.51 328.44 366.51 398.39 16.72 14.96
painting 6.42 9.59 4.67 4.28 9.19 6.42 6.83 36.31 32.36
rendering 27.36 22.36 24.78 22.89 19.47 22.89 23.37 12.54 11.21

1 similar comment
@github-actions
Copy link

github-actions bot commented May 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2293390526.
Commit: 5ee5d0d.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2080.81 2014.01 2074.83 2124.73 2062.69 2074.83 2071.41 1.92 1.72
painting 27.45 23.16 31.38 13.12 23.82 23.82 23.79 28.63 25.60
rendering 905.3 900.74 899.42 915.06 904.98 904.98 905.1 0.68 0.61
SELECT_WIDGET_SELECT_OPTION
scripting 485.91 360.36 450.73 366.51 328.44 366.51 398.39 16.72 14.96
painting 6.42 9.59 4.67 4.28 9.19 6.42 6.83 36.31 32.36
rendering 27.36 22.36 24.78 22.89 19.47 22.89 23.37 12.54 11.21

@Irongade
Copy link
Contributor Author

/ok-to-test sha=7eeeaf5

@github-actions github-actions bot added the Bug Something isn't working label May 10, 2022
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2299454054.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7eeeaf5.
PR: 13669.

@Irongade Irongade enabled auto-merge (squash) May 10, 2022 09:08
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2299454054.
Commit: 7eeeaf5.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 625.43 693.1 640.07 573.13 580.97 625.43 622.54 7.81 6.99
painting 3.71 5.39 4.69 4.14 6.25 4.69 4.84 20.87 18.60
rendering 283.2 329.43 260.64 258.13 263.74 263.74 279.03 10.70 9.57
BIND_TABLE_DATA
scripting 2226.36 2309.12 2237.94 2215.2 2218.99 2226.36 2241.52 1.73 1.55
painting 14.37 26.55 14.13 14.21 16.34 14.37 17.12 31.25 27.98
rendering 509.22 594.24 527.15 532.33 549.37 532.33 542.46 5.95 5.32
CLICK_ON_TABLE_ROW
scripting 1576.23 1522.39 1521.37 1565.31 1705.23 1565.31 1578.11 4.77 4.27
painting 20.33 20.79 10.63 14.92 13.44 14.92 16.02 27.59 24.72
rendering 304.27 254.9 241.5 245.2 257.63 254.9 260.7 9.69 8.66
UPDATE_POST_TITLE
scripting 2408.3 2310.76 2531.79 2265.35 2413.05 2408.3 2385.85 4.33 3.87
painting 12.85 18.86 14.55 27.16 42.77 18.86 23.24 52.67 47.12
rendering 339.35 318.98 356.36 320.13 325.25 325.25 332.01 4.77 4.27
OPEN_MODAL
scripting 1067.56 2405.45 1117.92 2454.34 1070.41 1117.92 1623.14 45.40 40.61
painting 9.66 23.48 13.38 9.41 10.08 10.08 13.2 45.23 40.45
rendering 382.31 371.33 400.28 381.81 373.44 381.81 381.83 2.99 2.67
CLOSE_MODAL
scripting 1651.78 679.86 515.79 679.15 543.54 679.15 814.02 58.28 52.12
painting 5.38 4.1 4.05 4.76 6.64 4.76 4.99 21.44 19.24
rendering 321.26 319.07 298.6 327.7 313.52 319.07 316.03 3.48 3.11
SELECT_WIDGET_MENU_OPEN
scripting 1370.96 1443.34 1402.95 1342.97 1432.05 1402.95 1398.45 2.99 2.68
painting 8.62 11.21 6.09 6 14.13 8.62 9.21 37.89 33.88
rendering 395.72 415.31 408.61 392.1 412.5 408.61 404.85 2.55 2.28
SELECT_WIDGET_SELECT_OPTION
scripting 198.11 173.66 176.08 166.56 196.49 176.08 182.18 7.82 7.00
painting 3.57 2.83 5.48 6.89 3.41 3.57 4.44 38.29 34.23
rendering 12.15 11.57 12.07 11.32 12.14 12.07 11.85 3.21 2.87

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2299454054.
Commit: 7eeeaf5.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 625.43 693.1 640.07 573.13 580.97 625.43 622.54 7.81 6.99
painting 3.71 5.39 4.69 4.14 6.25 4.69 4.84 20.87 18.60
rendering 283.2 329.43 260.64 258.13 263.74 263.74 279.03 10.70 9.57
BIND_TABLE_DATA
scripting 2226.36 2309.12 2237.94 2215.2 2218.99 2226.36 2241.52 1.73 1.55
painting 14.37 26.55 14.13 14.21 16.34 14.37 17.12 31.25 27.98
rendering 509.22 594.24 527.15 532.33 549.37 532.33 542.46 5.95 5.32
CLICK_ON_TABLE_ROW
scripting 1576.23 1522.39 1521.37 1565.31 1705.23 1565.31 1578.11 4.77 4.27
painting 20.33 20.79 10.63 14.92 13.44 14.92 16.02 27.59 24.72
rendering 304.27 254.9 241.5 245.2 257.63 254.9 260.7 9.69 8.66
UPDATE_POST_TITLE
scripting 2408.3 2310.76 2531.79 2265.35 2413.05 2408.3 2385.85 4.33 3.87
painting 12.85 18.86 14.55 27.16 42.77 18.86 23.24 52.67 47.12
rendering 339.35 318.98 356.36 320.13 325.25 325.25 332.01 4.77 4.27
OPEN_MODAL
scripting 1067.56 2405.45 1117.92 2454.34 1070.41 1117.92 1623.14 45.40 40.61
painting 9.66 23.48 13.38 9.41 10.08 10.08 13.2 45.23 40.45
rendering 382.31 371.33 400.28 381.81 373.44 381.81 381.83 2.99 2.67
CLOSE_MODAL
scripting 1651.78 679.86 515.79 679.15 543.54 679.15 814.02 58.28 52.12
painting 5.38 4.1 4.05 4.76 6.64 4.76 4.99 21.44 19.24
rendering 321.26 319.07 298.6 327.7 313.52 319.07 316.03 3.48 3.11
SELECT_WIDGET_MENU_OPEN
scripting 1370.96 1443.34 1402.95 1342.97 1432.05 1402.95 1398.45 2.99 2.68
painting 8.62 11.21 6.09 6 14.13 8.62 9.21 37.89 33.88
rendering 395.72 415.31 408.61 392.1 412.5 408.61 404.85 2.55 2.28
SELECT_WIDGET_SELECT_OPTION
scripting 198.11 173.66 176.08 166.56 196.49 176.08 182.18 7.82 7.00
painting 3.57 2.83 5.48 6.89 3.41 3.57 4.44 38.29 34.23
rendering 12.15 11.57 12.07 11.32 12.14 12.07 11.85 3.21 2.87

@Irongade Irongade merged commit 49a4e47 into release May 10, 2022
@Irongade Irongade deleted the feat/outside-click-close-modal branch May 10, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmanAgarwal041 AmanAgarwal041 AmanAgarwal041 approved these changes

@rashmi-rai rashmi-rai rashmi-rai approved these changes

Assignees
No one assigned
Labels
BE Coders Pod Issues related to users writing code to fetch and update data Bug Something isn't working Core Query Execution Issues related to the execution of all queries Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Production UX Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Allow query/js confirmation modal to be dismissed by clicking outside
3 participants
@Irongade @AmanAgarwal041 @rashmi-rai