Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove only for jest test #13668

Merged
merged 3 commits into from
May 11, 2022
Merged

chore: remove only for jest test #13668

merged 3 commits into from
May 11, 2022

Conversation

rishabhrathod01
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 commented May 9, 2022 •
edited by github-actions bot
Loading

Description

Remove skipping jest test.

Type of change

chore

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: chore/remove-jest-skip
Status File % Stmts % Branch % Funcs % Lines
🟢 total 56.62 (0.03) 38.44 (0.05) 35.85 (0.01) 56.86 (0.03)
🟢 app/client/src/entities/Action/actionProperties.ts 57.43 (16.84) 39.39 (22.72) 40 (13.33) 53.26 (15.22)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

@vercel
Copy link

vercel bot commented May 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 10, 2022 at 7:50AM (UTC)

@rishabhrathod01 rishabhrathod01 changed the title remove only for jest test chore: remove only for jest test May 9, 2022
@rishabhrathod01 rishabhrathod01 marked this pull request as ready for review May 9, 2022 09:09
@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label May 9, 2022
@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=4445305

@rishabhrathod01 rishabhrathod01 enabled auto-merge (squash) May 9, 2022 12:16
@github-actions
Copy link

github-actions bot commented May 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2294204178.
Workflow: Appsmith External Integration Test Workflow.
Commit: 4445305.
PR: 13668.

@github-actions
Copy link

github-actions bot commented May 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2294204178.
Commit: 4445305.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 836.48 780.81 803.51 906.45 792.58 803.51 823.97 6.14 5.49
painting 4.21 11.76 4.92 5.82 6.7 5.82 6.68 44.76 39.97
rendering 318.99 314.25 301.97 317.33 305.22 314.25 311.55 2.42 2.17
BIND_TABLE_DATA
scripting 2248.49 2308.75 3003.94 2278.15 2251.4 2278.15 2418.15 13.58 12.15
painting 23.63 17.27 18.56 30.33 18.76 18.76 21.71 24.83 22.20
rendering 938.03 670 699.23 805.51 651.25 699.23 752.8 15.88 14.20
CLICK_ON_TABLE_ROW
scripting 1987.13 2228.23 2241.86 2235.89 2149.54 2228.23 2168.53 4.98 4.46
painting 15.75 22 25.79 35.79 28.1 25.79 25.49 29.11 26.01
rendering 316.12 312.54 355.74 371.35 354.29 354.29 342.01 7.65 6.84
UPDATE_POST_TITLE
scripting 3071.31 3157.29 3167.35 3461.47 4076.63 3167.35 3386.81 12.19 10.90
painting 30.61 13.85 18.14 41.65 32.6 30.61 27.37 41.25 36.90
rendering 415.99 384.26 400.42 467.05 406.81 406.81 414.91 7.56 6.76
OPEN_MODAL
scripting 3839.36 2740.5 3782.2 1521.37 1488.39 2740.5 2674.36 43.14 38.59
painting 14.89 11.77 17.72 20.06 10.34 14.89 14.96 27.01 24.13
rendering 473.02 490.3 510.79 505.2 480.2 490.3 491.9 3.26 2.92
CLOSE_MODAL
scripting 1006.96 1757.05 706.6 861.68 940.03 940.03 1054.46 38.73 34.64
painting 7.18 6.54 5.38 7.49 7.54 7.18 6.83 13.18 11.86
rendering 464.64 385.02 363.25 368.03 382.79 382.79 392.75 10.51 9.40
SELECT_WIDGET_MENU_OPEN
scripting 1665.67 1562.38 1421.98 1616.76 1542.56 1562.38 1561.87 5.88 5.26
painting 19.25 15.17 4.62 9.91 15.28 15.17 12.85 44.12 39.46
rendering 641.27 522.78 498.65 554.06 493.3 522.78 542.01 11.15 9.98
SELECT_WIDGET_SELECT_OPTION
scripting 220.64 210.24 265.66 244.12 248.37 244.12 237.81 9.36 8.37
painting 3.98 2.39 3.34 5.49 3.41 3.41 3.72 30.65 27.42
rendering 17.96 14.62 18.47 15.58 15.85 15.85 16.5 9.94 8.91

1 similar comment
@github-actions
Copy link

github-actions bot commented May 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2294204178.
Commit: 4445305.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 836.48 780.81 803.51 906.45 792.58 803.51 823.97 6.14 5.49
painting 4.21 11.76 4.92 5.82 6.7 5.82 6.68 44.76 39.97
rendering 318.99 314.25 301.97 317.33 305.22 314.25 311.55 2.42 2.17
BIND_TABLE_DATA
scripting 2248.49 2308.75 3003.94 2278.15 2251.4 2278.15 2418.15 13.58 12.15
painting 23.63 17.27 18.56 30.33 18.76 18.76 21.71 24.83 22.20
rendering 938.03 670 699.23 805.51 651.25 699.23 752.8 15.88 14.20
CLICK_ON_TABLE_ROW
scripting 1987.13 2228.23 2241.86 2235.89 2149.54 2228.23 2168.53 4.98 4.46
painting 15.75 22 25.79 35.79 28.1 25.79 25.49 29.11 26.01
rendering 316.12 312.54 355.74 371.35 354.29 354.29 342.01 7.65 6.84
UPDATE_POST_TITLE
scripting 3071.31 3157.29 3167.35 3461.47 4076.63 3167.35 3386.81 12.19 10.90
painting 30.61 13.85 18.14 41.65 32.6 30.61 27.37 41.25 36.90
rendering 415.99 384.26 400.42 467.05 406.81 406.81 414.91 7.56 6.76
OPEN_MODAL
scripting 3839.36 2740.5 3782.2 1521.37 1488.39 2740.5 2674.36 43.14 38.59
painting 14.89 11.77 17.72 20.06 10.34 14.89 14.96 27.01 24.13
rendering 473.02 490.3 510.79 505.2 480.2 490.3 491.9 3.26 2.92
CLOSE_MODAL
scripting 1006.96 1757.05 706.6 861.68 940.03 940.03 1054.46 38.73 34.64
painting 7.18 6.54 5.38 7.49 7.54 7.18 6.83 13.18 11.86
rendering 464.64 385.02 363.25 368.03 382.79 382.79 392.75 10.51 9.40
SELECT_WIDGET_MENU_OPEN
scripting 1665.67 1562.38 1421.98 1616.76 1542.56 1562.38 1561.87 5.88 5.26
painting 19.25 15.17 4.62 9.91 15.28 15.17 12.85 44.12 39.46
rendering 641.27 522.78 498.65 554.06 493.3 522.78 542.01 11.15 9.98
SELECT_WIDGET_SELECT_OPTION
scripting 220.64 210.24 265.66 244.12 248.37 244.12 237.81 9.36 8.37
painting 3.98 2.39 3.34 5.49 3.41 3.41 3.72 30.65 27.42
rendering 17.96 14.62 18.47 15.58 15.85 15.85 16.5 9.94 8.91

@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=aa10737

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2299329771.
Workflow: Appsmith External Integration Test Workflow.
Commit: aa10737.
PR: 13668.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2299329771.
Commit: aa10737.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1335.64 1031.4 835.49 1021.2 990.4 1021.2 1042.83 17.42 15.59
painting 7.58 5.55 4.32 7.75 6.97 6.97 6.43 22.71 20.37
rendering 516.66 404.3 339.27 411.23 367.59 404.3 407.81 16.53 14.79
BIND_TABLE_DATA
scripting 2631.87 2790.09 2341.39 2312.84 2408.08 2408.08 2496.85 8.26 7.39
painting 34.69 30.07 21.81 23.06 24.08 24.08 26.74 20.42 18.25
rendering 890.69 806.07 748.67 757.54 834.05 806.07 807.4 7.22 6.46
CLICK_ON_TABLE_ROW
scripting 3603.9 3062.92 2656.86 1960.76 2900.75 2900.75 2837.04 21.17 18.94
painting 43.07 22.32 27.79 22.94 32.72 27.79 29.77 28.69 25.66
rendering 722.87 410.34 415.75 314.77 437.59 415.75 460.26 33.50 29.97
UPDATE_POST_TITLE
scripting 4833.93 4282.92 3892.95 3594.16 4141.97 4141.97 4149.19 11.18 10.00
painting 25.07 26.23 25 21.43 25.8 25.07 24.71 7.69 6.88
rendering 590.97 530.57 474.88 437.38 580.93 530.57 522.95 12.71 11.37
OPEN_MODAL
scripting 2988.08 1989.34 1632.29 1479.31 2003.78 1989.34 2018.56 29.11 26.04
painting 13.8 15.96 12.9 13.78 15.01 13.8 14.29 8.40 7.49
rendering 581 687.53 514.15 564.72 719.37 581 613.35 14.12 12.63
CLOSE_MODAL
scripting 1113.04 3009.4 826.06 894.71 1013.66 1013.66 1371.37 67.25 60.15
painting 6.88 5.53 6.51 7.14 10.08 6.88 7.23 23.65 21.16
rendering 408.85 382.03 445.89 419.02 414.95 414.95 414.15 5.52 4.94
SELECT_WIDGET_MENU_OPEN
scripting 1801.8 1778.51 1798.56 1767.7 1695.93 1778.51 1768.5 2.43 2.17
painting 11.08 9.46 24.86 7.99 19.45 11.08 14.57 49.90 44.61
rendering 805.52 770.15 698.81 701.24 747.28 747.28 744.6 6.13 5.49
SELECT_WIDGET_SELECT_OPTION
scripting 255.31 267.48 315.55 292.25 306.24 292.25 287.37 8.87 7.93
painting 10.44 3.63 3.99 4.22 11.53 4.22 6.76 57.40 51.33
rendering 23.54 22.43 27.91 23.77 19.24 23.54 23.38 13.30 11.89

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2299329771.
Commit: aa10737.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1335.64 1031.4 835.49 1021.2 990.4 1021.2 1042.83 17.42 15.59
painting 7.58 5.55 4.32 7.75 6.97 6.97 6.43 22.71 20.37
rendering 516.66 404.3 339.27 411.23 367.59 404.3 407.81 16.53 14.79
BIND_TABLE_DATA
scripting 2631.87 2790.09 2341.39 2312.84 2408.08 2408.08 2496.85 8.26 7.39
painting 34.69 30.07 21.81 23.06 24.08 24.08 26.74 20.42 18.25
rendering 890.69 806.07 748.67 757.54 834.05 806.07 807.4 7.22 6.46
CLICK_ON_TABLE_ROW
scripting 3603.9 3062.92 2656.86 1960.76 2900.75 2900.75 2837.04 21.17 18.94
painting 43.07 22.32 27.79 22.94 32.72 27.79 29.77 28.69 25.66
rendering 722.87 410.34 415.75 314.77 437.59 415.75 460.26 33.50 29.97
UPDATE_POST_TITLE
scripting 4833.93 4282.92 3892.95 3594.16 4141.97 4141.97 4149.19 11.18 10.00
painting 25.07 26.23 25 21.43 25.8 25.07 24.71 7.69 6.88
rendering 590.97 530.57 474.88 437.38 580.93 530.57 522.95 12.71 11.37
OPEN_MODAL
scripting 2988.08 1989.34 1632.29 1479.31 2003.78 1989.34 2018.56 29.11 26.04
painting 13.8 15.96 12.9 13.78 15.01 13.8 14.29 8.40 7.49
rendering 581 687.53 514.15 564.72 719.37 581 613.35 14.12 12.63
CLOSE_MODAL
scripting 1113.04 3009.4 826.06 894.71 1013.66 1013.66 1371.37 67.25 60.15
painting 6.88 5.53 6.51 7.14 10.08 6.88 7.23 23.65 21.16
rendering 408.85 382.03 445.89 419.02 414.95 414.95 414.15 5.52 4.94
SELECT_WIDGET_MENU_OPEN
scripting 1801.8 1778.51 1798.56 1767.7 1695.93 1778.51 1768.5 2.43 2.17
painting 11.08 9.46 24.86 7.99 19.45 11.08 14.57 49.90 44.61
rendering 805.52 770.15 698.81 701.24 747.28 747.28 744.6 6.13 5.49
SELECT_WIDGET_SELECT_OPTION
scripting 255.31 267.48 315.55 292.25 306.24 292.25 287.37 8.87 7.93
painting 10.44 3.63 3.99 4.22 11.53 4.22 6.76 57.40 51.33
rendering 23.54 22.43 27.91 23.77 19.24 23.54 23.38 13.30 11.89

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2299329771.
Commit: aa10737.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2099.16 2077.58 1991.02 2003.39 1923.81 2003.39 2018.99 3.50 3.13
painting 24.8 13.33 20.4 17.78 16.08 17.78 18.48 23.65 21.16
rendering 708.34 723.75 691.15 745.63 711.83 711.83 716.14 2.82 2.52
SELECT_WIDGET_SELECT_OPTION
scripting 310.97 380.56 326.2 320.8 321.3 321.3 331.97 8.35 7.47
painting 4.86 13.08 5.61 3.9 4.93 4.93 6.48 57.72 51.70
rendering 21.24 23.69 23.55 21.7 21.66 21.7 22.37 5.19 4.65

@rishabhrathod01 rishabhrathod01 merged commit 89c4bbe into release May 11, 2022
@rishabhrathod01 rishabhrathod01 deleted the chore/remove-jest-skip branch May 11, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yaldram yaldram yaldram approved these changes

Assignees
No one assigned
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rishabhrathod01 @yaldram