Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Test failing for theme name change #13663

Merged
merged 1 commit into from
May 10, 2022

Conversation

nayan-rafiq
Copy link
Contributor

Description

Fixes a failing junit test due to theme name change.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • JUnit test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nayan-rafiq nayan-rafiq requested a review from abhvsn May 9, 2022 05:48
@nayan-rafiq nayan-rafiq self-assigned this May 9, 2022
@vercel
Copy link

vercel bot commented May 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 9, 2022 at 6:02AM (UTC)

@github-actions github-actions bot added the Bug Something isn't working label May 9, 2022
@nayan-rafiq
Copy link
Contributor Author

/ok-to-test sha=db1c8f6

@github-actions
Copy link

github-actions bot commented May 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2293289489.
Workflow: Appsmith External Integration Test Workflow.
Commit: db1c8f6.
PR: 13663.

@github-actions
Copy link

github-actions bot commented May 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2293289489.
Commit: db1c8f6.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1778.38 1843.13 1868.29 1875.94 1803.29 1843.13 1833.81 2.29 2.05
painting 15.36 12.38 12.43 11.58 24.78 12.43 15.31 35.86 32.07
rendering 621.35 629.04 698.94 697.28 629.55 629.55 655.23 5.99 5.36
SELECT_WIDGET_SELECT_OPTION
scripting 299.84 415.69 390.36 487.16 292.23 390.36 377.06 21.77 19.47
painting 6.23 4.83 5.91 10.84 3.59 5.91 6.28 43.79 39.17
rendering 19.43 20.77 23.51 18.4 19.03 19.43 20.23 10.03 9.00

1 similar comment
@github-actions
Copy link

github-actions bot commented May 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2293289489.
Commit: db1c8f6.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1778.38 1843.13 1868.29 1875.94 1803.29 1843.13 1833.81 2.29 2.05
painting 15.36 12.38 12.43 11.58 24.78 12.43 15.31 35.86 32.07
rendering 621.35 629.04 698.94 697.28 629.55 629.55 655.23 5.99 5.36
SELECT_WIDGET_SELECT_OPTION
scripting 299.84 415.69 390.36 487.16 292.23 390.36 377.06 21.77 19.47
painting 6.23 4.83 5.91 10.84 3.59 5.91 6.28 43.79 39.17
rendering 19.43 20.77 23.51 18.4 19.03 19.43 20.23 10.03 9.00

@nayan-rafiq nayan-rafiq merged commit 12dfef1 into release May 10, 2022
@nayan-rafiq nayan-rafiq deleted the fix/test-failing-for-theme-name branch May 10, 2022 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants