test: Automated tests to TableFilterSpec for Bug# 13334 + failure fixes #13662

Aishwarya-U-R · 2022-05-09T05:43:50Z

Description

Implements few automated script validation for TableFilter scenarios plus fixes below flaky specs:

setInterval_spec
iconButton_spec
Error_handling_spec

Type of change

New test (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on Fat container - release

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed

No changes to code coverage between the base branch and the head branch

vercel · 2022-05-09T05:43:53Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
appsmith	✅ Ready (Inspect)	Visit Preview	May 9, 2022 at 6:31PM (UTC)

Aishwarya-U-R · 2022-05-09T07:45:49Z

/ok-to-test sha=aaa23bf

github-actions · 2022-05-09T07:46:27Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2292745151.
Workflow: Appsmith External Integration Test Workflow.
Commit: aaa23bf.
PR: 13662.

Aishwarya-U-R · 2022-05-09T08:23:22Z

/ok-to-test sha=eaac759

github-actions · 2022-05-09T08:28:31Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2292950845.
Workflow: Appsmith External Integration Test Workflow.
Commit: eaac759.
PR: 13662.

github-actions · 2022-05-09T10:50:29Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2292950845.
Commit: eaac759.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_CATEGORY
scripting	800.74	2118.76	830.75	792.72	1975.11	830.75	1303.62	52.21	46.70
painting	4.13	9.33	4.41	4.63	3.71	4.41	5.24	44.08	39.50
rendering	291.12	340.31	315.08	322.62	322.78	322.62	318.38	5.60	5.01
BIND_TABLE_DATA
scripting	2246.47	2274.56	2265.58	2319.27	2251.13	2265.58	2271.4	1.28	1.14
painting	17.51	10.99	18.99	15.61	14.52	15.61	15.52	19.72	17.65
rendering	603.81	679.54	640.61	609.06	596.7	609.06	625.94	5.49	4.91
CLICK_ON_TABLE_ROW
scripting	2131.77	2019.63	2771.34	2182.49	2079.51	2131.77	2236.95	13.63	12.19
painting	18.15	18.07	17.73	16.3	23.04	18.07	18.66	13.72	12.27
rendering	286.55	297.86	296.05	275.4	299.03	296.05	290.98	3.44	3.08
UPDATE_POST_TITLE
scripting	3245.52	3224.31	2849.18	3240.37	4148.55	3240.37	3341.59	14.41	12.88
painting	17.18	20.46	17.97	17.34	35.35	17.97	21.66	35.87	32.09
rendering	420.97	405.55	363.55	385.16	371.41	385.16	389.33	6.12	5.47
OPEN_MODAL
scripting	1140.96	2832.66	1300.09	1287.67	1521.4	1300.09	1616.56	42.89	38.36
painting	25.53	29.31	12.02	17.94	24.13	24.13	21.79	31.30	27.99
rendering	400.45	435.05	485.16	429.98	457.04	435.05	441.54	7.17	6.41
CLOSE_MODAL
scripting	808.65	607.05	698.65	781.76	657.25	698.65	710.67	11.86	10.60
painting	4.41	4.12	7.09	4.53	15.65	4.53	7.16	68.30	61.17
rendering	328.9	327.01	354.99	339.08	344.89	339.08	338.97	3.42	3.06
SELECT_WIDGET_MENU_OPEN
scripting	1520.9	1566.84	1487.05	1473.25	1550.41	1520.9	1519.69	2.63	2.35
painting	9.7	8.87	14.63	6.07	5.09	8.87	8.87	42.16	37.77
rendering	494.44	559.48	593.01	507.77	497.86	507.77	530.51	8.23	7.36
SELECT_WIDGET_SELECT_OPTION
scripting	227.63	452.7	272.66	269.47	283.68	272.66	301.23	28.98	25.92
painting	16.1	4.6	2.86	4.25	4.52	4.52	6.47	83.93	75.12
rendering	14.5	16.55	15.88	13.56	20.55	15.88	16.21	16.59	14.87

github-actions · 2022-05-09T13:37:57Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2292950845.
Commit: eaac759.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_CATEGORY
scripting	800.74	2118.76	830.75	792.72	1975.11	830.75	1303.62	52.21	46.70
painting	4.13	9.33	4.41	4.63	3.71	4.41	5.24	44.08	39.50
rendering	291.12	340.31	315.08	322.62	322.78	322.62	318.38	5.60	5.01
BIND_TABLE_DATA
scripting	2246.47	2274.56	2265.58	2319.27	2251.13	2265.58	2271.4	1.28	1.14
painting	17.51	10.99	18.99	15.61	14.52	15.61	15.52	19.72	17.65
rendering	603.81	679.54	640.61	609.06	596.7	609.06	625.94	5.49	4.91
CLICK_ON_TABLE_ROW
scripting	2131.77	2019.63	2771.34	2182.49	2079.51	2131.77	2236.95	13.63	12.19
painting	18.15	18.07	17.73	16.3	23.04	18.07	18.66	13.72	12.27
rendering	286.55	297.86	296.05	275.4	299.03	296.05	290.98	3.44	3.08
UPDATE_POST_TITLE
scripting	3245.52	3224.31	2849.18	3240.37	4148.55	3240.37	3341.59	14.41	12.88
painting	17.18	20.46	17.97	17.34	35.35	17.97	21.66	35.87	32.09
rendering	420.97	405.55	363.55	385.16	371.41	385.16	389.33	6.12	5.47
OPEN_MODAL
scripting	1140.96	2832.66	1300.09	1287.67	1521.4	1300.09	1616.56	42.89	38.36
painting	25.53	29.31	12.02	17.94	24.13	24.13	21.79	31.30	27.99
rendering	400.45	435.05	485.16	429.98	457.04	435.05	441.54	7.17	6.41
CLOSE_MODAL
scripting	808.65	607.05	698.65	781.76	657.25	698.65	710.67	11.86	10.60
painting	4.41	4.12	7.09	4.53	15.65	4.53	7.16	68.30	61.17
rendering	328.9	327.01	354.99	339.08	344.89	339.08	338.97	3.42	3.06
SELECT_WIDGET_MENU_OPEN
scripting	1520.9	1566.84	1487.05	1473.25	1550.41	1520.9	1519.69	2.63	2.35
painting	9.7	8.87	14.63	6.07	5.09	8.87	8.87	42.16	37.77
rendering	494.44	559.48	593.01	507.77	497.86	507.77	530.51	8.23	7.36
SELECT_WIDGET_SELECT_OPTION
scripting	227.63	452.7	272.66	269.47	283.68	272.66	301.23	28.98	25.92
painting	16.1	4.6	2.86	4.25	4.52	4.52	6.47	83.93	75.12
rendering	14.5	16.55	15.88	13.56	20.55	15.88	16.21	16.59	14.87

Aishwarya-U-R · 2022-05-09T15:31:47Z

/ok-to-test sha=003dc69

github-actions · 2022-05-09T15:32:30Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2295201260.
Workflow: Appsmith External Integration Test Workflow.
Commit: 003dc69.
PR: 13662.

github-actions · 2022-05-09T16:13:47Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2295201260.
Commit: 003dc69.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_CATEGORY
scripting	638.81	591.34	1768.41	587.6	610.56	610.56	839.34	61.92	55.39
painting	3.23	3.28	3.4	9.52	5.23	3.4	4.93	54.77	48.88
rendering	274.41	273.08	263.07	252.1	275.37	273.08	267.61	3.73	3.33
BIND_TABLE_DATA
scripting	2248.79	2265.4	2210.23	2175.59	2189.05	2210.23	2217.81	1.73	1.55
painting	16.18	10.7	10.71	8.64	11.67	10.71	11.58	24.18	21.59
rendering	540.01	507.53	487.09	482.73	542.51	507.53	511.97	5.54	4.95
CLICK_ON_TABLE_ROW
scripting	1568.67	1608.46	1545.36	1619.66	1864.29	1608.46	1641.29	7.81	6.99
painting	23.46	13.25	9.86	11.78	14.36	13.25	14.54	36.18	32.39
rendering	242.28	276.14	249.38	243.83	248.14	248.14	251.95	5.49	4.91
UPDATE_POST_TITLE
scripting	2400.04	2652.47	2521.81	2276.66	2413.12	2413.12	2452.82	5.77	5.16
painting	13.48	13.23	34.83	12.6	15.77	13.48	17.98	52.78	47.22
rendering	346.14	335.77	351.37	313.12	316.54	335.77	332.59	5.17	4.62
OPEN_MODAL
scripting	1000.99	908.89	1040.8	2447.18	1015.89	1015.89	1282.75	50.89	45.52
painting	9.89	11.41	11.9	10.37	11.54	11.41	11.02	7.71	6.90
rendering	413.39	368.93	421.4	369.13	390	390	392.57	6.21	5.56
CLOSE_MODAL
scripting	572.6	589.31	506.15	637.81	652.37	589.31	591.65	9.82	8.78
painting	6.84	9.55	9.94	15.77	4.26	9.55	9.27	46.28	41.42
rendering	289.37	306.94	296.32	316.25	300.38	300.38	301.85	3.40	3.04
SELECT_WIDGET_MENU_OPEN
scripting	1378.17	1425.03	1390.13	1366.19	1312.88	1378.17	1374.48	2.97	2.66
painting	20.1	4.49	10.66	3.98	3.95	4.49	8.64	81.13	72.57
rendering	394.59	385.6	392.63	393.46	392.8	392.8	391.82	0.91	0.81
SELECT_WIDGET_SELECT_OPTION
scripting	236.86	164.21	159.21	183.37	195.26	183.37	187.78	16.54	14.79
painting	2.57	2.7	7.09	6.52	2.02	2.7	4.18	57.89	51.67
rendering	11.57	11.78	11.68	12.78	11.28	11.68	11.82	4.82	4.31

Aishwarya-U-R · 2022-05-09T17:27:34Z

/ok-to-test sha=7cf77f6

github-actions · 2022-05-09T17:28:08Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2295771372.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7cf77f6.
PR: 13662.

github-actions · 2022-05-09T17:59:53Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2295771372.
Commit: 7cf77f6.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_WIDGET_MENU_OPEN
scripting	2025.61	2038.5	2165.15	2128.75	1980.42	2038.5	2067.69	3.70	3.31
painting	18.67	15.5	14.63	12.86	10.96	14.63	14.52	19.97	17.84
rendering	699.39	689.81	732.62	716.43	719.25	716.43	711.5	2.38	2.13
SELECT_WIDGET_SELECT_OPTION
scripting	339.55	334.58	651.1	322.7	334.79	334.79	396.54	35.92	32.13
painting	3.73	4.69	5.11	4.83	6.42	4.83	4.96	19.56	17.54
rendering	27.13	24.9	20.65	26.67	27.38	26.67	25.35	11.05	9.86

github-actions · 2022-05-09T18:09:06Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2295771372.
Commit: 7cf77f6.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_WIDGET_MENU_OPEN
scripting	2025.61	2038.5	2165.15	2128.75	1980.42	2038.5	2067.69	3.70	3.31
painting	18.67	15.5	14.63	12.86	10.96	14.63	14.52	19.97	17.84
rendering	699.39	689.81	732.62	716.43	719.25	716.43	711.5	2.38	2.13
SELECT_WIDGET_SELECT_OPTION
scripting	339.55	334.58	651.1	322.7	334.79	334.79	396.54	35.92	32.13
painting	3.73	4.69	5.11	4.83	6.42	4.83	4.96	19.56	17.54
rendering	27.13	24.9	20.65	26.67	27.38	26.67	25.35	11.05	9.86

Aishwarya-U-R · 2022-05-09T18:23:56Z

/ok-to-test sha=c080a69

github-actions · 2022-05-09T18:24:37Z

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2296044554.
Workflow: Appsmith External Integration Test Workflow.
Commit: c080a69.
PR: 13662.

github-actions · 2022-05-09T19:00:12Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2296044554.
Commit: c080a69.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_WIDGET_MENU_OPEN
scripting	1563.72	1954.53	1542.76	1503.9	1581.84	1563.72	1629.35	11.30	10.11
painting	6.59	16.01	6.55	6.88	8.1	6.88	8.83	46.09	41.22
rendering	534.19	782.72	554.85	512.62	526.89	534.19	582.25	19.42	17.37
SELECT_WIDGET_SELECT_OPTION
scripting	244.46	381.35	257.11	237.08	279.98	257.11	280	21.05	18.83
painting	2.33	6.82	5.02	11.38	3.24	5.02	5.76	62.15	55.73
rendering	13.9	25.44	19.08	14.71	18.41	18.41	18.31	25.01	22.39

github-actions · 2022-05-09T19:13:47Z

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2296044554.
Commit: c080a69.
Results:

Click to view performance test results

	Run 1	Run 2	Run 3	Run 4	Run 5	Median	Mean	SD.Sample	SD.Population
SELECT_WIDGET_MENU_OPEN
scripting	1563.72	1954.53	1542.76	1503.9	1581.84	1563.72	1629.35	11.30	10.11
painting	6.59	16.01	6.55	6.88	8.1	6.88	8.83	46.09	41.22
rendering	534.19	782.72	554.85	512.62	526.89	534.19	582.25	19.42	17.37
SELECT_WIDGET_SELECT_OPTION
scripting	244.46	381.35	257.11	237.08	279.98	257.11	280	21.05	18.83
painting	2.33	6.82	5.02	11.38	3.24	5.02	5.76	62.15	55.73
rendering	13.9	25.44	19.08	14.71	18.41	18.41	18.31	25.01	22.39

Aishwarya-U-R added 2 commits May 9, 2022 11:03

TableFilter bug #13334 scripted

91cf240

Merge branch 'release' into test/TableFilterSpec

aaa23bf

github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels May 9, 2022

vercel bot deployed to Preview May 9, 2022 05:52 View deployment

Deleting App_Theming_spec as already incorporated

eaac759

vercel bot deployed to Preview May 9, 2022 08:29 View deployment

Merge branch 'release' into test/TableFilterSpec

5627ea2

vercel bot deployed to Preview May 9, 2022 08:44 View deployment

Aishwarya-U-R requested a review from yatinappsmith May 9, 2022 14:02

Aishwarya-U-R changed the title ~~test: Automated tests for TableFilter for Bug# 13334~~ test: Automated tests to TableFilterSpec for Bug# 13334 May 9, 2022

yatinappsmith previously approved these changes May 9, 2022

View reviewed changes

setInterval fix

a8a2301

Aishwarya-U-R dismissed yatinappsmith’s stale review via a8a2301 May 9, 2022 15:29

Aishwarya-U-R changed the title ~~test: Automated tests to TableFilterSpec for Bug# 13334~~ test: Automated tests to TableFilterSpec for Bug# 13334 + setInterval failure fix May 9, 2022

Merge branch 'release' into test/TableFilterSpec

003dc69

Aishwarya-U-R requested a review from yatinappsmith May 9, 2022 15:31

yatinappsmith previously approved these changes May 9, 2022

View reviewed changes

vercel bot deployed to Preview May 9, 2022 15:43 View deployment

setInterval fix

7cf77f6

Aishwarya-U-R dismissed yatinappsmith’s stale review via 7cf77f6 May 9, 2022 17:26

vercel bot deployed to Preview May 9, 2022 17:34 View deployment

iconWidget fix

70d913a

vercel bot deployed to Preview May 9, 2022 17:48 View deployment

Aishwarya-U-R changed the title ~~test: Automated tests to TableFilterSpec for Bug# 13334 + setInterval failure fix~~ test: Automated tests to TableFilterSpec for Bug# 13334 + flake failure fixes May 9, 2022

Error_handling flaky fix

c080a69

Aishwarya-U-R changed the title ~~test: Automated tests to TableFilterSpec for Bug# 13334 + flake failure fixes~~ test: Automated tests to TableFilterSpec for Bug# 13334 + failure fixes May 9, 2022

vercel bot deployed to Preview May 9, 2022 18:31 View deployment

Aishwarya-U-R requested a review from yatinappsmith May 10, 2022 05:03

yatinappsmith approved these changes May 10, 2022

View reviewed changes

sharat87 merged commit f5cc986 into release May 10, 2022

sharat87 deleted the test/TableFilterSpec branch May 10, 2022 05:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Automated tests to TableFilterSpec for Bug# 13334 + failure fixes #13662

test: Automated tests to TableFilterSpec for Bug# 13334 + failure fixes #13662

Aishwarya-U-R commented May 9, 2022 •

edited by github-actions bot

Loading

vercel bot commented May 9, 2022 •

edited

Loading

Aishwarya-U-R commented May 9, 2022

github-actions bot commented May 9, 2022

Aishwarya-U-R commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

Aishwarya-U-R commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

Aishwarya-U-R commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

Aishwarya-U-R commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

test: Automated tests to TableFilterSpec for Bug# 13334 + failure fixes #13662

test: Automated tests to TableFilterSpec for Bug# 13334 + failure fixes #13662

Conversation

Aishwarya-U-R commented May 9, 2022 • edited by github-actions bot Loading

Description

Type of change

How Has This Been Tested?

Checklist:

Test coverage results 🧪

vercel bot commented May 9, 2022 • edited Loading

Aishwarya-U-R commented May 9, 2022

github-actions bot commented May 9, 2022

Aishwarya-U-R commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

Aishwarya-U-R commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

Aishwarya-U-R commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

Aishwarya-U-R commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

github-actions bot commented May 9, 2022

Aishwarya-U-R commented May 9, 2022 •

edited by github-actions bot

Loading

vercel bot commented May 9, 2022 •

edited

Loading