Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable revoke button after first click #13644

Merged
merged 1 commit into from
May 6, 2022
Merged

fix: disable revoke button after first click #13644

merged 1 commit into from
May 6, 2022

Conversation

IAmAnubhavSaini
Copy link
Contributor

@IAmAnubhavSaini IAmAnubhavSaini commented May 6, 2022 •
edited by github-actions bot
Loading

Description

Revoke button can be pressed multiple times. This code change stops that.

Fixes #12164

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Cypress test

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: fix-12164
Status File % Stmts % Branch % Funcs % Lines
🟢 total 56.57 (0) 38.35 (0.01) 35.84 (0) 56.82 (0)
🟢 app/client/src/selectors/commentsSelectors.ts 85.25 (1.64) 64.71 (2.95) 73.33 (0) 90.59 (2.35)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

@IAmAnubhavSaini IAmAnubhavSaini self-assigned this May 6, 2022
@vercel
Copy link

vercel bot commented May 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 6, 2022 at 10:04AM (UTC)

@IAmAnubhavSaini IAmAnubhavSaini marked this pull request as ready for review May 6, 2022 09:53
@github-actions github-actions bot added Bug Something isn't working Git Product Issues related to version control product Platform Pod Platform Administration Pod Issues related to platform administration & management labels May 6, 2022
@IAmAnubhavSaini
Copy link
Contributor Author

/ok-to-test sha=03684fce97324d6ad907087b02a78b3583549955

@IAmAnubhavSaini IAmAnubhavSaini removed the request for review from arunvjn May 6, 2022 10:11
@github-actions
Copy link

github-actions bot commented May 6, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2281126174.
Workflow: Appsmith External Integration Test Workflow.
Commit: 03684fce97324d6ad907087b02a78b3583549955.
PR: 13644.

@github-actions
Copy link

github-actions bot commented May 6, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2281126174.
Commit: 03684fce97324d6ad907087b02a78b3583549955.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1045.52 1009.92 836.96 868.52 2115.96 1009.92 1175.38 45.37 40.58
painting 5.83 5.44 6.16 13.67 8.2 6.16 7.86 43.51 38.93
rendering 397.49 341.67 301.56 344.47 327.94 341.67 342.63 10.23 9.15
BIND_TABLE_DATA
scripting 2261.36 2300.88 2321.94 2252.17 2138.9 2261.36 2255.05 3.14 2.81
painting 17.87 20.37 15.96 21.4 21.54 20.37 19.43 12.51 11.22
rendering 770.7 661.5 615.12 763.86 969.17 763.86 756.07 18.05 16.14
CLICK_ON_TABLE_ROW
scripting 2950.32 2266.35 2367.56 2286.94 4549.52 2367.56 2884.14 33.72 30.16
painting 21.81 17.64 23.51 19.38 31.88 21.81 22.84 24.21 21.63
rendering 466.95 318.82 351.27 383.79 881.73 383.79 480.51 48.07 42.99
UPDATE_POST_TITLE
scripting 3110.32 3330.93 3453.82 4104.58 4368.78 3453.82 3673.69 14.61 13.07
painting 20.49 27.31 22 32.96 20 22 24.55 22.48 20.12
rendering 385.43 415.17 418.9 478.8 458.75 418.9 431.41 8.62 7.71
OPEN_MODAL
scripting 1195.31 1276.78 1405.6 1407.52 1687.26 1405.6 1394.49 13.39 11.98
painting 11.54 9.89 14.17 10.89 13.6 11.54 12.02 15.06 13.48
rendering 421.67 456.35 449.66 460.82 562.84 456.35 470.27 11.47 10.26
CLOSE_MODAL
scripting 878.95 825.06 765.46 884.32 829.67 829.67 836.69 5.77 5.16
painting 6.38 9.5 4.92 8.17 8.67 8.17 7.53 24.57 22.05
rendering 359.97 373.31 356.58 377.09 410.56 373.31 375.5 5.70 5.10
SELECT_WIDGET_MENU_OPEN
scripting 1674.4 1636.56 1776.51 1780.51 1647.15 1674.4 1703.03 4.13 3.69
painting 12.87 20.8 16.37 8.05 11.38 12.87 13.89 35.13 31.46
rendering 559.77 568.14 716.59 641.25 553.27 568.14 607.8 11.58 10.36
SELECT_WIDGET_SELECT_OPTION
scripting 351.66 361.41 351.62 267.89 290.88 351.62 324.69 13.04 11.66
painting 3.62 8.81 5.01 3.17 8.99 5.01 5.92 47.30 42.40
rendering 25.08 22.52 19.22 21.36 18.27 21.36 21.29 12.73 11.37

1 similar comment
@github-actions
Copy link

github-actions bot commented May 6, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2281126174.
Commit: 03684fce97324d6ad907087b02a78b3583549955.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1045.52 1009.92 836.96 868.52 2115.96 1009.92 1175.38 45.37 40.58
painting 5.83 5.44 6.16 13.67 8.2 6.16 7.86 43.51 38.93
rendering 397.49 341.67 301.56 344.47 327.94 341.67 342.63 10.23 9.15
BIND_TABLE_DATA
scripting 2261.36 2300.88 2321.94 2252.17 2138.9 2261.36 2255.05 3.14 2.81
painting 17.87 20.37 15.96 21.4 21.54 20.37 19.43 12.51 11.22
rendering 770.7 661.5 615.12 763.86 969.17 763.86 756.07 18.05 16.14
CLICK_ON_TABLE_ROW
scripting 2950.32 2266.35 2367.56 2286.94 4549.52 2367.56 2884.14 33.72 30.16
painting 21.81 17.64 23.51 19.38 31.88 21.81 22.84 24.21 21.63
rendering 466.95 318.82 351.27 383.79 881.73 383.79 480.51 48.07 42.99
UPDATE_POST_TITLE
scripting 3110.32 3330.93 3453.82 4104.58 4368.78 3453.82 3673.69 14.61 13.07
painting 20.49 27.31 22 32.96 20 22 24.55 22.48 20.12
rendering 385.43 415.17 418.9 478.8 458.75 418.9 431.41 8.62 7.71
OPEN_MODAL
scripting 1195.31 1276.78 1405.6 1407.52 1687.26 1405.6 1394.49 13.39 11.98
painting 11.54 9.89 14.17 10.89 13.6 11.54 12.02 15.06 13.48
rendering 421.67 456.35 449.66 460.82 562.84 456.35 470.27 11.47 10.26
CLOSE_MODAL
scripting 878.95 825.06 765.46 884.32 829.67 829.67 836.69 5.77 5.16
painting 6.38 9.5 4.92 8.17 8.67 8.17 7.53 24.57 22.05
rendering 359.97 373.31 356.58 377.09 410.56 373.31 375.5 5.70 5.10
SELECT_WIDGET_MENU_OPEN
scripting 1674.4 1636.56 1776.51 1780.51 1647.15 1674.4 1703.03 4.13 3.69
painting 12.87 20.8 16.37 8.05 11.38 12.87 13.89 35.13 31.46
rendering 559.77 568.14 716.59 641.25 553.27 568.14 607.8 11.58 10.36
SELECT_WIDGET_SELECT_OPTION
scripting 351.66 361.41 351.62 267.89 290.88 351.62 324.69 13.04 11.66
painting 3.62 8.81 5.01 3.17 8.99 5.01 5.92 47.30 42.40
rendering 25.08 22.52 19.22 21.36 18.27 21.36 21.29 12.73 11.37

@mohanarpit mohanarpit merged commit 4934fc9 into release May 6, 2022
@mohanarpit mohanarpit deleted the fix-12164 branch May 6, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitakinger ankitakinger ankitakinger approved these changes

Assignees

@IAmAnubhavSaini IAmAnubhavSaini

Labels
Bug Something isn't working Git Product Issues related to version control product Platform Administration Pod Issues related to platform administration & management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Revoke (disconnect) button can be clicked multiple times
3 participants
@IAmAnubhavSaini @ankitakinger @mohanarpit