Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Not able to see all the options of Font property as it is not scrollable + Canvas scroll to top when I drop Tab widget on the canvas #13608

Merged
merged 10 commits into from
May 11, 2022
Merged

fix: Not able to see all the options of Font property as it is not scrollable + Canvas scroll to top when I drop Tab widget on the canvas #13608

merged 10 commits into from
May 11, 2022

Conversation

jsartisan
Copy link
Contributor

@jsartisan jsartisan commented May 5, 2022 •
edited by github-actions bot
Loading

Fixes #13582
Fixes #13598
Fixes #13591
Fixes #13641

Type of change

Please delete options that are not relevant.

  • Bugfix

How Has This Been Tested?

  • Manually tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed 
// Code coverage diff between base branch:release and head branch: fix/theming-bugs
Status File % Stmts % Branch % Funcs % Lines
🟢 app/client/src/selectors/commentsSelectors.ts 85.25 (1.64) 64.71 (2.95) 73.33 (0) 90.59 (2.35)
🟢 app/client/src/widgets/TabsWidget/component/PageTabs.tsx 97.87 (-0.05) 85 (1.67) 100 (0) 97.73 (-0.05)
🟢 app/client/src/widgets/TabsWidget/component/index.tsx 90.32 (5.61) 61.11 (0.58) 78.57 (15.41) 88 (7.7)

@vercel
Copy link

vercel bot commented May 5, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 10, 2022 at 11:20AM (UTC)

keyurparalkar
keyurparalkar previously approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@keyurparalkar keyurparalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions github-actions bot added App Theming Items that are related to the App level theming controls epic Widgets & Blocks Pod This label assigns issues to the widgets & blocks pod Bug Something isn't working Needs Triaging Needs attention from maintainers to triage Regressed Scenarios that were working before but have now regressed Release Release Blocker This issue must be resolved before the release Tab Widget UI Building Pod labels May 5, 2022
@github-actions
Copy link

github-actions bot commented May 5, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@vivekverma2312
Copy link

@jsartisan Tab issue is tested and working fine. I have tested Font Family issue on 13105

@github-actions github-actions bot added the Critical This issue needs immediate attention. Drop everything else label May 9, 2022
@github-actions github-actions bot added the Medium Issues that frustrate users due to poor UX label May 9, 2022
@github-actions
Copy link

github-actions bot commented May 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

1 similar comment
@github-actions
Copy link

github-actions bot commented May 9, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=13641

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2298543751.
Commit: f4f6837.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1941.88 2048.84 2100.26 2068.48 2055.6 2055.6 2043.01 2.93 2.62
painting 17.77 14.45 9.61 13.97 13.02 13.97 13.76 21.29 19.04
rendering 808.87 892.39 838.79 963.46 896.15 892.39 879.93 6.76 6.04
SELECT_WIDGET_SELECT_OPTION
scripting 303.35 419.94 312.34 312.81 336.52 312.81 336.99 14.23 12.73
painting 4.74 3.95 6.08 5.07 4.24 4.74 4.82 17.22 15.35
rendering 20.05 19.79 21.92 26.42 22.76 21.92 22.19 12.08 10.77

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2298543751.
Commit: f4f6837.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1941.88 2048.84 2100.26 2068.48 2055.6 2055.6 2043.01 2.93 2.62
painting 17.77 14.45 9.61 13.97 13.02 13.97 13.76 21.29 19.04
rendering 808.87 892.39 838.79 963.46 896.15 892.39 879.93 6.76 6.04
SELECT_WIDGET_SELECT_OPTION
scripting 303.35 419.94 312.34 312.81 336.52 312.81 336.99 14.23 12.73
painting 4.74 3.95 6.08 5.07 4.24 4.74 4.82 17.22 15.35
rendering 20.05 19.79 21.92 26.42 22.76 21.92 22.19 12.08 10.77

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=161665d

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2298866707.
Workflow: Appsmith External Integration Test Workflow.
Commit: 161665d.
PR: 13608.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2298866707.
Commit: 161665d.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2276.15 2074.5 2232.66 2338.87 2325.54 2276.15 2249.54 4.74 4.24
painting 16.21 11.88 12.9 29.62 14.76 14.76 17.07 42.24 37.79
rendering 801.83 739.21 767.42 873.58 816.05 801.83 799.62 6.39 5.71
SELECT_WIDGET_SELECT_OPTION
scripting 362.93 347.11 351.26 384.33 374.59 362.93 364.04 4.29 3.83
painting 4.73 5.85 3.82 5.25 10.71 5.25 6.07 44.48 39.70
rendering 21.57 21.94 26.45 21.75 27.8 21.94 23.9 12.47 11.17

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=161665d

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2299454634.
Workflow: Appsmith External Integration Test Workflow.
Commit: 161665d.
PR: 13608.

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=161665d

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2299753482.
Workflow: Appsmith External Integration Test Workflow.
Commit: 161665d.
PR: 13608.

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=161665d

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2299977585.
Workflow: Appsmith External Integration Test Workflow.
Commit: 161665d.
PR: 13608.

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=32270d4

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2299991235.
Workflow: Appsmith External Integration Test Workflow.
Commit: 32270d4.
PR: 13608.

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=d2f5725

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2300251913.
Workflow: Appsmith External Integration Test Workflow.
Commit: d2f5725.
PR: 13608.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2300251913.
Commit: d2f5725.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 590.3 673.01 652.41 629.01 702.11 652.41 649.37 6.56 5.87
painting 3.68 3.92 4.14 6.18 5.96 4.14 4.78 24.90 22.38
rendering 262.79 271.02 264.87 270.25 286.59 270.25 271.1 3.44 3.08
BIND_TABLE_DATA
scripting 2334.57 2249.36 2200.31 2352.68 2201.4 2249.36 2267.66 3.19 2.86
painting 14.83 7.25 15.29 20.11 14.81 14.83 14.46 31.88 28.49
rendering 514.32 521.25 606.73 611.24 598.16 598.16 570.34 8.46 7.57
CLICK_ON_TABLE_ROW
scripting 1665.74 1937.6 1738.41 2216.82 1789.44 1789.44 1869.6 11.67 10.44
painting 17.9 13 14.88 25.93 14.69 14.88 17.28 29.80 26.62
rendering 262.41 294.84 280.79 327.3 284.78 284.78 290.02 8.25 7.38
UPDATE_POST_TITLE
scripting 2458.58 2433.76 2636.5 3159.96 2764.88 2636.5 2690.74 10.97 9.81
painting 11.54 14.99 34.34 23.21 26.41 23.21 22.1 41.22 36.83
rendering 310.55 319.79 341.46 424.46 343.52 341.46 347.96 12.94 11.57
OPEN_MODAL
scripting 1063.37 986.22 1254.23 1339.75 1106.65 1106.65 1150.04 12.53 11.21
painting 9.66 9.93 10.31 12.31 10.83 10.31 10.61 9.90 8.86
rendering 378.87 375.02 399.18 457.21 417.45 399.18 405.55 8.27 7.39
CLOSE_MODAL
scripting 506.79 551.07 660.33 2844.07 648.53 648.53 1042.16 96.85 86.63
painting 5.67 6.4 7.45 11.34 6.58 6.58 7.49 29.91 26.84
rendering 303.51 306.96 314.54 334.59 330.4 314.54 318 4.37 3.91
SELECT_WIDGET_MENU_OPEN
scripting 1425.58 1500.98 1515.67 1443.08 1424.5 1443.08 1461.96 2.96 2.65
painting 5.09 5.26 8.39 11.22 5.01 5.26 6.99 39.48 35.19
rendering 400.89 440.73 468.8 410.38 406.16 410.38 425.39 6.77 6.05
SELECT_WIDGET_SELECT_OPTION
scripting 175.18 218.89 270.95 175.5 209.69 209.69 210.04 18.74 16.76
painting 2.43 3.85 11.69 4.76 4.27 4.27 5.4 67.04 60.00
rendering 11.34 15.02 16.79 12.2 11.74 12.2 13.42 17.66 15.80

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2300251913.
Commit: d2f5725.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 590.3 673.01 652.41 629.01 702.11 652.41 649.37 6.56 5.87
painting 3.68 3.92 4.14 6.18 5.96 4.14 4.78 24.90 22.38
rendering 262.79 271.02 264.87 270.25 286.59 270.25 271.1 3.44 3.08
BIND_TABLE_DATA
scripting 2334.57 2249.36 2200.31 2352.68 2201.4 2249.36 2267.66 3.19 2.86
painting 14.83 7.25 15.29 20.11 14.81 14.83 14.46 31.88 28.49
rendering 514.32 521.25 606.73 611.24 598.16 598.16 570.34 8.46 7.57
CLICK_ON_TABLE_ROW
scripting 1665.74 1937.6 1738.41 2216.82 1789.44 1789.44 1869.6 11.67 10.44
painting 17.9 13 14.88 25.93 14.69 14.88 17.28 29.80 26.62
rendering 262.41 294.84 280.79 327.3 284.78 284.78 290.02 8.25 7.38
UPDATE_POST_TITLE
scripting 2458.58 2433.76 2636.5 3159.96 2764.88 2636.5 2690.74 10.97 9.81
painting 11.54 14.99 34.34 23.21 26.41 23.21 22.1 41.22 36.83
rendering 310.55 319.79 341.46 424.46 343.52 341.46 347.96 12.94 11.57
OPEN_MODAL
scripting 1063.37 986.22 1254.23 1339.75 1106.65 1106.65 1150.04 12.53 11.21
painting 9.66 9.93 10.31 12.31 10.83 10.31 10.61 9.90 8.86
rendering 378.87 375.02 399.18 457.21 417.45 399.18 405.55 8.27 7.39
CLOSE_MODAL
scripting 506.79 551.07 660.33 2844.07 648.53 648.53 1042.16 96.85 86.63
painting 5.67 6.4 7.45 11.34 6.58 6.58 7.49 29.91 26.84
rendering 303.51 306.96 314.54 334.59 330.4 314.54 318 4.37 3.91
SELECT_WIDGET_MENU_OPEN
scripting 1425.58 1500.98 1515.67 1443.08 1424.5 1443.08 1461.96 2.96 2.65
painting 5.09 5.26 8.39 11.22 5.01 5.26 6.99 39.48 35.19
rendering 400.89 440.73 468.8 410.38 406.16 410.38 425.39 6.77 6.05
SELECT_WIDGET_SELECT_OPTION
scripting 175.18 218.89 270.95 175.5 209.69 209.69 210.04 18.74 16.76
painting 2.43 3.85 11.69 4.76 4.27 4.27 5.4 67.04 60.00
rendering 11.34 15.02 16.79 12.2 11.74 12.2 13.42 17.66 15.80

@jsartisan
Copy link
Contributor Author

/ok-to-test sha=d2f5725

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2301485567.
Workflow: Appsmith External Integration Test Workflow.
Commit: d2f5725.
PR: 13608.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2301485567.
Commit: d2f5725.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 982.68 823.73 821.5 1033.42 780.73 823.73 888.41 12.61 11.28
painting 8.55 6.17 5.07 6.83 5.11 6.17 6.35 22.68 20.31
rendering 410.63 294.82 323.68 405.28 320.71 323.68 351.02 15.16 13.56
BIND_TABLE_DATA
scripting 2198.69 2300.35 2774.08 2194.95 2144.67 2198.69 2322.55 11.14 9.96
painting 17.98 25.1 26.2 15.47 21.38 21.38 21.23 21.53 19.27
rendering 875.95 684.39 670.97 725.73 966.74 725.73 784.76 16.61 14.85
CLICK_ON_TABLE_ROW
scripting 2924.26 2223.92 2263.75 2082.49 2435.48 2263.75 2385.98 13.67 12.23
painting 26.3 15.84 19.98 20.63 24.49 20.63 21.45 19.07 17.06
rendering 400.97 331.6 312.91 313.42 336.04 331.6 338.99 10.68 9.55
UPDATE_POST_TITLE
scripting 3422.22 3821.76 3480.38 3211.63 3045.09 3422.22 3396.22 8.66 7.75
painting 27.16 19.08 22.99 18.91 18.41 19.08 21.31 17.60 15.72
rendering 403.59 561.41 451.95 411.16 400.08 411.16 445.64 15.25 13.64
OPEN_MODAL
scripting 1763.08 1240.74 1619.83 1537.94 1175.18 1537.94 1467.35 17.12 15.31
painting 15.32 14.45 11.52 16.47 10.26 14.45 13.6 19.26 17.21
rendering 609.33 436.78 554.11 452.01 423.57 452.01 495.16 16.56 14.82
CLOSE_MODAL
scripting 925.57 3304.99 752.53 1825.1 600.43 925.57 1481.72 75.91 67.89
painting 7.67 19.37 5.98 5.65 4.38 5.98 8.61 71.20 63.65
rendering 422.52 472.5 428.47 337.67 349.69 422.52 402.17 14.16 12.66
SELECT_WIDGET_MENU_OPEN
scripting 1547.41 1523.71 1530.39 1522.71 1546.48 1530.39 1534.14 0.79 0.70
painting 5.5 8.91 5.76 8.49 12.08 8.49 8.15 33.01 29.45
rendering 506.55 528.24 506.13 560.8 682.63 528.24 556.87 13.24 11.85
SELECT_WIDGET_SELECT_OPTION
scripting 248.87 206.1 223.88 215.68 234.03 223.88 225.71 7.33 6.55
painting 2.81 2.68 5.19 3.13 5.07 3.13 3.78 33.07 29.63
rendering 18.72 15.3 16.01 14.95 15.85 15.85 16.17 9.21 8.23

@jsartisan jsartisan merged commit 2dacdec into release May 11, 2022
@jsartisan jsartisan deleted the fix/theming-bugs branch May 11, 2022 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbalaji1192 sbalaji1192 sbalaji1192 approved these changes

@keyurparalkar keyurparalkar keyurparalkar left review comments

Assignees
No one assigned
Labels
App Theming Items that are related to the App level theming controls epic Bug Something isn't working Critical This issue needs immediate attention. Drop everything else Medium Issues that frustrate users due to poor UX Needs Triaging Needs attention from maintainers to triage Regressed Scenarios that were working before but have now regressed Release Blocker This issue must be resolved before the release Release Tab Widget Widgets & Blocks Pod This label assigns issues to the widgets & blocks pod
Projects
None yet
Milestone
No milestone
4 participants
@jsartisan @vivekverma2312 @sbalaji1192 @keyurparalkar