Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: signing up with a redirect url which has a query param goes to a 400 page #13548

Merged
merged 4 commits into from
May 10, 2022
Merged

fix: signing up with a redirect url which has a query param goes to a 400 page #13548

merged 4 commits into from
May 10, 2022

Conversation

akash-codemonk
Copy link
Contributor

@akash-codemonk akash-codemonk commented May 4, 2022 •
edited by github-actions bot
Loading

Description

On app.appsmith the recaptcha token is added as a query param to the redirect url but it isn't encoded. Since there is no recaptcha on release we don't see the error.

Fixes #12926
Fixes #11745

To test this locally hardcoded the query param in code.
Before change

before.mov

After change

after.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: fix/redirect-url
Status File % Stmts % Branch % Funcs % Lines
🔴 total 56.59 (0) 38.39 (-0.01) 35.84 (0) 56.83 (-0.01)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)

@vercel
Copy link

vercel bot commented May 4, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 9, 2022 at 2:26PM (UTC)

@github-actions github-actions bot added Bug Something isn't working Login / Signup Authentication flows Platform Pod Production Team Managers Pod Issues that team managers care about for the security and efficiency of their teams labels May 4, 2022
@github-actions
Copy link

github-actions bot commented May 4, 2022

Unable to find test scripts. Please add necessary tests to the PR.

1 similar comment
@github-actions
Copy link

github-actions bot commented May 4, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added Critical This issue needs immediate attention. Drop everything else Fork App Issues related to forking apps New Developers Pod Issues that new developers face while exploring the IDE QA Needs QA attention labels May 4, 2022
@github-actions
Copy link

github-actions bot commented May 4, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@akash-codemonk
Copy link
Contributor Author

/ok-to-test sha=331a3f2

@github-actions
Copy link

github-actions bot commented May 4, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2268706663.
Workflow: Appsmith External Integration Test Workflow.
Commit: 331a3f2.
PR: 13548.

@akash-codemonk
Copy link
Contributor Author

/ok-to-test sha=6fb2c79

@github-actions
Copy link

github-actions bot commented May 5, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2274106779.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6fb2c79.
PR: 13548.

ankitakinger
ankitakinger reviewed May 5, 2022
View reviewed changes
Copy link
Contributor

@ankitakinger ankitakinger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

github-actions bot commented May 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2274106779.
Commit: 6fb2c79.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 1568.72 1529.96 1575.81 1519.07 1555.7 1555.7 1549.85 1.58 1.42
painting 10.09 15.76 10.3 6.44 9.88 10.09 10.49 31.84 28.50
rendering 545.11 539.36 523.49 511.79 524.35 524.35 528.82 2.53 2.26
SELECT_WIDGET_SELECT_OPTION
scripting 249.89 201.68 249.4 268.78 213.13 249.4 236.58 11.86 10.60
painting 5.04 4.89 5.06 5.12 2.86 5.04 4.59 21.13 18.95
rendering 18.1 16.89 18.3 16.65 16.57 16.89 17.3 4.80 4.28

@akash-codemonk
Copy link
Contributor Author

/ok-to-test sha=0ba32a9

@github-actions
Copy link

github-actions bot commented May 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2295030980.
Workflow: Appsmith External Integration Test Workflow.
Commit: 0ba32a9.
PR: 13548.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2295030980.
Commit: 0ba32a9.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2611.38 2544.82 2464.55 2663.45 2490.16 2544.82 2554.87 3.24 2.90
painting 20.87 12.98 28.45 17.34 19.15 19.15 19.76 28.74 25.71
rendering 1112.2 1127.02 1087.41 1037.99 1085.88 1087.41 1090.1 3.11 2.78
SELECT_WIDGET_SELECT_OPTION
scripting 379.11 385.17 693.25 391.86 430.08 391.86 455.89 29.43 26.32
painting 5.02 8.66 4.64 6.14 4.67 5.02 5.83 29.16 26.07
rendering 29.32 30.34 33.71 27.02 29.26 29.32 29.93 8.15 7.28

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2295030980.
Commit: 0ba32a9.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_WIDGET_MENU_OPEN
scripting 2611.38 2544.82 2464.55 2663.45 2490.16 2544.82 2554.87 3.24 2.90
painting 20.87 12.98 28.45 17.34 19.15 19.15 19.76 28.74 25.71
rendering 1112.2 1127.02 1087.41 1037.99 1085.88 1087.41 1090.1 3.11 2.78
SELECT_WIDGET_SELECT_OPTION
scripting 379.11 385.17 693.25 391.86 430.08 391.86 455.89 29.43 26.32
painting 5.02 8.66 4.64 6.14 4.67 5.02 5.83 29.16 26.07
rendering 29.32 30.34 33.71 27.02 29.26 29.32 29.93 8.15 7.28

@akash-codemonk akash-codemonk merged commit c0f7c45 into release May 10, 2022
@akash-codemonk akash-codemonk deleted the fix/redirect-url branch May 10, 2022 08:02
@sharat87 sharat87 mentioned this pull request May 20, 2022
Closed
1 task
akash-codemonk added a commit that referenced this pull request May 20, 2022
@akash-codemonk
Revert "fix: signing up with a redirect url which has a query param g…
8470421 
…oes to a 400 page (#13548)"

This reverts commit c0f7c45.
akash-codemonk added a commit that referenced this pull request Jun 1, 2022
@akash-codemonk
Revert "fix: signing up with a redirect url which has a query param g…
ec6d998 
…oes to a 400 page (#13548)" (#13991)

This reverts commit c0f7c45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitakinger ankitakinger ankitakinger approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working Critical This issue needs immediate attention. Drop everything else Fork App Issues related to forking apps Login / Signup Authentication flows New Developers Pod Issues that new developers face while exploring the IDE Production QA Needs QA attention Team Managers Pod Issues that team managers care about for the security and efficiency of their teams
Projects
None yet
Milestone
No milestone
2 participants
@akash-codemonk @ankitakinger