Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace klona/full with klona default #13457

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

rishabhrathod01
Copy link
Contributor

@rishabhrathod01 rishabhrathod01 commented Apr 29, 2022

Description

  • when manipulating props, react state (immutable values) do not use klona/default as the non-writable property remains non-writable, and delete or update operation will crash on dev.

Type of change

chore

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed
// Code coverage diff between base branch:release and head branch: fix/replace-klona-full 
Status File % Stmts % Branch % Funcs % Lines
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

- when manipulating props, react state (immutable values)
@vercel
Copy link

vercel bot commented Apr 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview Apr 29, 2022 at 0:03AM (UTC)

@github-actions github-actions bot added the Bug Something isn't working label Apr 29, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@rishabhrathod01
Copy link
Contributor Author

/ok-to-test sha=81faaf5

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@rishabhrathod01 rishabhrathod01 enabled auto-merge (squash) April 29, 2022 12:52
@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2245435688.
Workflow: Appsmith External Integration Test Workflow.
Commit: 81faaf5.
PR: 13457.

@rishabhrathod01 rishabhrathod01 merged commit 3b1fbfa into release Apr 29, 2022
@rishabhrathod01 rishabhrathod01 deleted the fix/replace-klona-full branch April 29, 2022 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants