Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix test failures #13306

Merged
merged 3 commits into from
May 9, 2022
Merged

chore: Fix test failures #13306

merged 3 commits into from
May 9, 2022

Conversation

AnaghHegde
Copy link
Member

@AnaghHegde AnaghHegde commented Apr 26, 2022 •
edited
Loading

Description

Fix Junit tests failing on local machine as CI is buggy and somehow not detecting tests failures.

Fixes #13296

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Locally ran

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Apr 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 9, 2022 at 7:50AM (UTC)

@AnaghHegde AnaghHegde self-assigned this Apr 26, 2022
@github-actions github-actions bot added Task A simple Todo skip-changelog Adding this label to a PR prevents it from being listed in the changelog labels Apr 26, 2022
@AnaghHegde
Copy link
Member Author

/ok-to-test sha=90d97d6

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2225291824.
Workflow: Appsmith External Integration Test Workflow.
Commit: 90d97d6.
PR: 13306.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2225291824.
Commit: 90d97d6.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1805.67 1960.36 675.08 692.38 703.18 703.18 1167.33 56.17 50.24
painting 4.68 5.05 3.69 5.15 4.86 4.86 4.69 12.58 11.09
rendering 290.51 288.13 270.03 274.77 283.99 283.99 281.49 3.12 2.79
BIND_TABLE_DATA
scripting 2189.99 2318.28 2227.08 2257.37 2267.62 2257.37 2252.07 2.12 1.90
painting 19.22 15.09 12.34 12.49 12.96 12.96 14.42 20.11 18.03
rendering 588.95 563.7 579.38 593.35 568.49 579.38 578.77 2.20 1.97
CLICK_ON_TABLE_ROW
scripting 1926.92 1903.41 1887.52 1772.24 1791.29 1887.52 1856.28 3.76 3.36
painting 24.47 19.19 18.81 15.42 14.51 18.81 18.48 21.21 18.99
rendering 289.75 288.37 276.84 275.8 258.71 276.84 277.89 4.49 4.02
UPDATE_POST_TITLE
scripting 3455.67 2995.59 2971.61 3332.38 2908.59 2995.59 3132.77 7.81 6.98
painting 17.92 24.13 26.36 14.94 15.55 17.92 19.78 26.14 23.41
rendering 409.18 351.56 368.94 367.85 348.41 367.85 369.19 6.56 5.86
OPEN_MODAL
scripting 1190.12 1126.86 1192.29 1143.66 1141.27 1143.66 1158.84 2.61 2.33
painting 12.1 17.33 9.4 9.19 10.41 10.41 11.69 28.74 25.66
rendering 422.08 390.32 395.8 399.94 400.15 399.94 401.66 3.01 2.69
CLOSE_MODAL
scripting 749.13 3492.71 674.37 671.07 566.45 674.37 1230.75 102.88 92.02
painting 8.79 4.62 4.17 6.18 5.7 5.7 5.89 30.73 27.50
rendering 234.58 234.16 249.39 243.65 225.54 234.58 237.46 3.90 3.48

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2225291824.
Commit: 90d97d6.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1805.67 1960.36 675.08 692.38 703.18 703.18 1167.33 56.17 50.24
painting 4.68 5.05 3.69 5.15 4.86 4.86 4.69 12.58 11.09
rendering 290.51 288.13 270.03 274.77 283.99 283.99 281.49 3.12 2.79
BIND_TABLE_DATA
scripting 2189.99 2318.28 2227.08 2257.37 2267.62 2257.37 2252.07 2.12 1.90
painting 19.22 15.09 12.34 12.49 12.96 12.96 14.42 20.11 18.03
rendering 588.95 563.7 579.38 593.35 568.49 579.38 578.77 2.20 1.97
CLICK_ON_TABLE_ROW
scripting 1926.92 1903.41 1887.52 1772.24 1791.29 1887.52 1856.28 3.76 3.36
painting 24.47 19.19 18.81 15.42 14.51 18.81 18.48 21.21 18.99
rendering 289.75 288.37 276.84 275.8 258.71 276.84 277.89 4.49 4.02
UPDATE_POST_TITLE
scripting 3455.67 2995.59 2971.61 3332.38 2908.59 2995.59 3132.77 7.81 6.98
painting 17.92 24.13 26.36 14.94 15.55 17.92 19.78 26.14 23.41
rendering 409.18 351.56 368.94 367.85 348.41 367.85 369.19 6.56 5.86
OPEN_MODAL
scripting 1190.12 1126.86 1192.29 1143.66 1141.27 1143.66 1158.84 2.61 2.33
painting 12.1 17.33 9.4 9.19 10.41 10.41 11.69 28.74 25.66
rendering 422.08 390.32 395.8 399.94 400.15 399.94 401.66 3.01 2.69
CLOSE_MODAL
scripting 749.13 3492.71 674.37 671.07 566.45 674.37 1230.75 102.88 92.02
painting 8.79 4.62 4.17 6.18 5.7 5.7 5.89 30.73 27.50
rendering 234.58 234.16 249.39 243.65 225.54 234.58 237.46 3.90 3.48

@AnaghHegde
Copy link
Member Author

/ok-to-test sha=2fb1144

@AnaghHegde AnaghHegde enabled auto-merge (squash) May 6, 2022 11:56
@github-actions
Copy link

github-actions bot commented May 6, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2281553045.
Workflow: Appsmith External Integration Test Workflow.
Commit: 2fb1144.
PR: 13306.

@github-actions
Copy link

github-actions bot commented May 6, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2281553045.
Commit: 2fb1144.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 840.42 792.05 804.8 870.39 720.35 804.8 805.6 7.04 6.30
painting 4.51 5.86 6.3 10.58 4.38 5.86 6.33 39.81 35.55
rendering 319.19 300.79 325.64 289.69 306.37 306.37 308.34 4.66 4.17
BIND_TABLE_DATA
scripting 2205.29 2255.54 2752.48 2217.82 2301.57 2255.54 2346.54 9.80 8.77
painting 23.24 24.68 15.31 19.94 20.14 20.14 20.66 17.47 15.63
rendering 636.23 670.89 687.51 683.81 619.27 670.89 659.54 4.59 4.10
CLICK_ON_TABLE_ROW
scripting 1781.65 2026.03 2375.08 1900.95 2219.57 2026.03 2060.66 11.60 10.38
painting 16.36 16.67 23.86 22.02 15.35 16.67 18.85 20.27 18.14
rendering 326.4 302.83 325.79 298.73 300.89 302.83 310.93 4.48 4.00
UPDATE_POST_TITLE
scripting 2912.54 2969.79 3117.66 2999.2 3115.6 2999.2 3022.96 3.01 2.69
painting 14.76 30.9 29.21 17.8 26.7 26.7 23.87 30.04 26.90
rendering 366.65 385.5 414.22 401.94 421.4 401.94 397.94 5.57 4.98
OPEN_MODAL
scripting 1956.06 1301.43 1271.97 1875.11 1254.42 1301.43 1531.8 22.97 20.55
painting 13.19 21 9.82 33.4 25.9 21 20.66 46.13 41.24
rendering 413.8 474.7 412.19 605.87 447.65 447.65 470.84 16.95 15.16
CLOSE_MODAL
scripting 781.29 631.68 586.75 1049.55 904.38 781.29 790.73 24.24 21.68
painting 4.34 10.64 13.6 15.4 13.44 13.44 11.48 37.80 33.80
rendering 316.67 327.44 321.87 377.61 416.32 327.44 351.98 12.34 11.04
SELECT_WIDGET_MENU_OPEN
scripting 2016.62 1953.66 1519.94 1919.66 1873.05 1919.66 1856.59 10.52 9.41
painting 8.23 11.89 5.31 8.44 12.47 8.44 9.27 31.72 28.37
rendering 788.96 720.18 484.94 539.61 710.53 710.53 648.84 19.99 17.88
SELECT_WIDGET_SELECT_OPTION
scripting 273.2 392.13 226.03 252.37 278.42 273.2 284.43 22.37 20.01
painting 3.56 3.86 8.02 2.78 8.71 3.86 5.39 51.21 45.83
rendering 20.75 24.29 13.12 17.49 17.21 17.49 18.57 22.56 20.19

@AnaghHegde
Copy link
Member Author

/ok-to-test sha=a2593ac

@github-actions
Copy link

github-actions bot commented May 9, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2292724381.
Workflow: Appsmith External Integration Test Workflow.
Commit: a2593ac.
PR: 13306.

@github-actions
Copy link

github-actions bot commented May 9, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2292724381.
Commit: a2593ac.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 760.39 773.8 761.15 864.88 889.15 773.8 809.87 7.67 6.86
painting 6.9 4.63 5.1 5.24 8.62 5.24 6.1 27.05 24.26
rendering 304.46 303.8 328.72 332.68 371.14 328.72 328.16 8.38 7.49
BIND_TABLE_DATA
scripting 2283.89 2609.23 2487.02 2205.02 2293.93 2293.93 2375.82 7.02 6.28
painting 11.47 12.93 18.57 23.13 14.78 14.78 16.18 29.11 26.02
rendering 613.14 633.55 614.86 639.26 591.42 614.86 618.45 3.06 2.74
CLICK_ON_TABLE_ROW
scripting 1925.28 2018.76 2050.14 2026.7 2378.01 2026.7 2079.78 8.34 7.46
painting 18.96 15.05 14.77 19.71 25.89 18.96 18.88 23.89 21.35
rendering 284.78 296.78 299.53 285.64 375.18 296.78 308.38 12.29 11.00
UPDATE_POST_TITLE
scripting 2943.46 3185.71 3546.71 3032.77 3450.76 3185.71 3231.88 8.07 7.22
painting 27.83 16.16 16.76 21.51 44.47 21.51 25.35 46.04 41.18
rendering 374.03 386.49 438.25 382.77 405.88 386.49 397.48 6.44 5.76
OPEN_MODAL
scripting 1183.68 1233.28 1370.8 1249.57 1384.16 1249.57 1284.3 6.90 6.17
painting 12.54 16.55 13.26 9.28 14.21 13.26 13.17 20.12 18.00
rendering 433.65 422.35 423.23 442.36 447.02 433.65 433.72 2.55 2.28
CLOSE_MODAL
scripting 808.45 708.74 676.52 720.23 712.52 712.52 725.29 6.81 6.09
painting 12.33 7.66 7.34 9.69 5.94 7.66 8.59 28.87 25.84
rendering 360.77 343.91 386.91 336.54 359.86 359.86 357.6 5.43 4.85
SELECT_WIDGET_MENU_OPEN
scripting 1575.47 1515.16 1526.31 1586.77 1594.75 1575.47 1559.69 2.34 2.09
painting 6.22 11.06 5.51 18.19 6.58 6.58 9.51 55.94 50.05
rendering 560.21 540.97 503.27 554.96 553.96 553.96 542.67 4.26 3.81
SELECT_WIDGET_SELECT_OPTION
scripting 270.89 266.8 245.42 315.75 301.95 270.89 280.16 10.12 9.05
painting 4.45 3.54 4.17 7.31 5.31 4.45 4.96 29.44 26.41
rendering 17.72 18.05 20.3 23.05 20.46 20.3 19.92 10.79 9.69

@AnaghHegde AnaghHegde merged commit 4db07f8 into release May 9, 2022
@AnaghHegde AnaghHegde deleted the chore/fix-tests branch May 9, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhvsn abhvsn abhvsn approved these changes

@nayan-rafiq nayan-rafiq Awaiting requested review from nayan-rafiq

Assignees

@AnaghHegde AnaghHegde

Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Junit test failures on local env
2 participants
@AnaghHegde @abhvsn