Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Automated tests to improve coverage for JSObjects-onPageLoad + Flaky fixes #12904

Merged
merged 28 commits into from
May 6, 2022
Merged

test: Automated tests to improve coverage for JSObjects-onPageLoad + Flaky fixes #12904

merged 28 commits into from
May 6, 2022

Conversation

Aishwarya-U-R
Copy link
Contributor

@Aishwarya-U-R Aishwarya-U-R commented Apr 13, 2022 •
edited by github-actions bot
Loading

Description

  • This PR includes more tests around JS Objects

Type of change

  • New tests (non-breaking change which adds functionality)

How Has This Been Tested?

  • Fat container [Release]

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: test/AutoTheming
Status File % Stmts % Branch % Funcs % Lines
🔴 total 56.51 (-0.01) 37.99 (0) 35.86 (0) 56.75 (0)
🔴 app/client/src/utils/WorkerUtil.ts 88.98 (-0.78) 70.59 (-1.96) 100 (0) 92.38 (-0.95)

@vercel
Copy link

vercel bot commented Apr 13, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/5vGXAwzvdtHeXVUCoMG42gikd8hY
✅ Preview: https://appsmith-git-test-autotheming-get-appsmith.vercel.app

@Aishwarya-U-R Aishwarya-U-R changed the title test: Automated tests Theming functionality test: Automated tests for Theming functionality Apr 13, 2022
@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Apr 13, 2022
@Aishwarya-U-R Aishwarya-U-R changed the title test: Automated tests for Theming functionality test: Automated tests to improve coverage for JSObjects Apr 13, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

3 similar comments
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@Aishwarya-U-R
Copy link
Contributor Author

/ok-to-test sha=c1e4bf7

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2162168828.
Workflow: Appsmith External Integration Test Workflow.
Commit: c1e4bf7.
PR: 12904.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2162168828.
Commit: c1e4bf7.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1060.17 1032.58 1020.95 963.52 1058.77 1032.58 1027.2 3.83 3.43
painting 21.86 14.91 5.96 4.7 9.03 9.03 11.29 62.89 56.24
rendering 363.48 367.58 362.77 353.04 366.43 363.48 362.66 1.58 1.41
BIND_TABLE_DATA
scripting 2139.92 2201.57 2078.55 2161.33 2204.32 2161.33 2157.14 2.40 2.14
painting 31.37 30.27 41.63 43.93 24.18 31.37 34.28 24.12 21.59
rendering 830.19 854.58 924.98 814.34 799.95 830.19 844.81 5.82 5.21
CLICK_ON_TABLE_ROW
scripting 4168.65 3393.82 4801.67 4155.49 3813.48 4155.49 4066.62 12.75 11.40
painting 48.43 46.34 94.25 63.09 34.43 48.43 57.31 40.18 35.93
rendering 748.71 601.74 699.9 959.22 782.58 748.71 758.43 17.31 15.49
UPDATE_POST_TITLE
scripting 4251.47 4592.44 4398.19 5486.05 4701.56 4592.44 4685.94 10.24 9.16
painting 28.38 59.35 40.71 33.67 30.7 33.67 38.56 32.44 29.02
rendering 488.3 481.19 491.65 500.27 490.11 490.11 490.3 1.40 1.25
OPEN_MODAL
scripting 4070.13 4723.49 1732.39 1624.83 1934.16 1934.16 2817 52.00 46.51
painting 28.03 45.94 33 12.21 20.82 28.03 28 45.46 40.64
rendering 501.74 527.34 526.26 531.92 533.49 527.34 524.15 2.46 2.20
CLOSE_MODAL
scripting 834.21 2150.13 807.63 3665.28 914.74 914.74 1674.4 74.50 66.63
painting 15.24 6.75 8.05 11.95 12.7 11.95 10.94 31.81 28.43
rendering 302.89 330.56 305.6 360.38 351.22 330.56 330.13 7.88 7.04

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2162168828.
Commit: c1e4bf7.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 1060.17 1032.58 1020.95 963.52 1058.77 1032.58 1027.2 3.83 3.43
painting 21.86 14.91 5.96 4.7 9.03 9.03 11.29 62.89 56.24
rendering 363.48 367.58 362.77 353.04 366.43 363.48 362.66 1.58 1.41
BIND_TABLE_DATA
scripting 2139.92 2201.57 2078.55 2161.33 2204.32 2161.33 2157.14 2.40 2.14
painting 31.37 30.27 41.63 43.93 24.18 31.37 34.28 24.12 21.59
rendering 830.19 854.58 924.98 814.34 799.95 830.19 844.81 5.82 5.21
CLICK_ON_TABLE_ROW
scripting 4168.65 3393.82 4801.67 4155.49 3813.48 4155.49 4066.62 12.75 11.40
painting 48.43 46.34 94.25 63.09 34.43 48.43 57.31 40.18 35.93
rendering 748.71 601.74 699.9 959.22 782.58 748.71 758.43 17.31 15.49
UPDATE_POST_TITLE
scripting 4251.47 4592.44 4398.19 5486.05 4701.56 4592.44 4685.94 10.24 9.16
painting 28.38 59.35 40.71 33.67 30.7 33.67 38.56 32.44 29.02
rendering 488.3 481.19 491.65 500.27 490.11 490.11 490.3 1.40 1.25
OPEN_MODAL
scripting 4070.13 4723.49 1732.39 1624.83 1934.16 1934.16 2817 52.00 46.51
painting 28.03 45.94 33 12.21 20.82 28.03 28 45.46 40.64
rendering 501.74 527.34 526.26 531.92 533.49 527.34 524.15 2.46 2.20
CLOSE_MODAL
scripting 834.21 2150.13 807.63 3665.28 914.74 914.74 1674.4 74.50 66.63
painting 15.24 6.75 8.05 11.95 12.7 11.95 10.94 31.81 28.43
rendering 302.89 330.56 305.6 360.38 351.22 330.56 330.13 7.88 7.04

@Aishwarya-U-R
Copy link
Contributor Author

/ok-to-test sha=3a7db37

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2168526076.
Workflow: Appsmith External Integration Test Workflow.
Commit: 3a7db37.
PR: 12904.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2168526076.
Commit: 3a7db37.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
SELECT_CATEGORY
scripting 2002.06 808.49 758.73 803.08 948.31 808.49 1064.13 49.72 44.47
painting 7.23 4.74 4.17 4.28 5.04 4.74 5.09 24.56 21.81
rendering 280.99 328.71 299.19 305.38 294.98 299.19 301.85 5.79 5.18
BIND_TABLE_DATA
scripting 2401.38 2877.94 2168.59 2120.84 2181.41 2181.41 2350.03 13.38 11.96
painting 11.28 19.76 22.1 23.19 24.23 22.1 20.11 25.91 23.17
rendering 641.54 646.13 831.62 767.91 695.12 695.12 716.46 11.45 10.24
CLICK_ON_TABLE_ROW
scripting 2936.58 2878.41 2174.8 2533.31 3447.82 2878.41 2794.18 17.04 15.24
painting 19.26 22.66 24.49 24.63 30.17 24.49 24.24 16.34 14.60
rendering 448.66 387.83 300.33 382.69 379.67 382.69 379.84 13.89 12.42
UPDATE_POST_TITLE
scripting 4539.45 4479.53 3924.05 3211.99 3811.5 3924.05 3993.3 13.62 12.18
painting 25.6 22.75 21.81 15.42 19.14 21.81 20.94 18.43 16.48
rendering 651.4 384.49 483.06 394.38 514.83 483.06 485.63 22.30 19.94
OPEN_MODAL
scripting 1834.85 1687.87 1430.06 3168.35 3249.15 1834.85 2274.06 38.08 34.06
painting 20.41 20.7 16.05 11.56 16.33 16.33 17.01 22.05 19.69
rendering 656.42 522.1 464.03 450.13 543.2 522.1 527.18 15.56 13.92
CLOSE_MODAL
scripting 825.37 884.19 746.73 640.61 876.87 825.37 794.75 12.85 11.50
painting 6.56 6.18 5.42 4.29 9.68 6.18 6.43 31.42 27.99
rendering 283.42 346.48 267.35 253.3 320.2 283.42 294.15 13.08 11.70

@vercel
Copy link

vercel bot commented Apr 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
appsmith ✅ Ready (Inspect) Visit Preview May 5, 2022 at 5:23PM (UTC)

@Aishwarya-U-R
Copy link
Contributor Author

/ok-to-test sha=570b6a4

@github-actions
Copy link

github-actions bot commented May 5, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2273853462.
Workflow: Appsmith External Integration Test Workflow.
Commit: 570b6a4.
PR: 12904.

@Aishwarya-U-R
Copy link
Contributor Author

/ok-to-test sha=c0e491a

@github-actions
Copy link

github-actions bot commented May 5, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2274593091.
Workflow: Appsmith External Integration Test Workflow.
Commit: c0e491a.
PR: 12904.

@Aishwarya-U-R
Copy link
Contributor Author

/ok-to-test sha=412375f

@github-actions
Copy link

github-actions bot commented May 5, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2275153764.
Workflow: Appsmith External Integration Test Workflow.
Commit: 412375f.
PR: 12904.

@Aishwarya-U-R
Copy link
Contributor Author

/ok-to-test sha=53b98c8

@github-actions
Copy link

github-actions bot commented May 5, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2277172582.
Workflow: Appsmith External Integration Test Workflow.
Commit: 53b98c8.
PR: 12904.

@Aishwarya-U-R Aishwarya-U-R changed the title test: Automated tests to improve coverage for JSObjects/Promises test: Automated tests to improve coverage for JSObjects-onPageLoad + Flaky fixes May 6, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@Parthvi12 Parthvi12 self-requested a review May 6, 2022 05:37
@Parthvi12 Parthvi12 merged commit e8c9d1d into release May 6, 2022
@Parthvi12 Parthvi12 deleted the test/AutoTheming branch May 6, 2022 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatinappsmith yatinappsmith Awaiting requested review from yatinappsmith

@Parthvi12 Parthvi12 Awaiting requested review from Parthvi12

Assignees
No one assigned
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aishwarya-U-R @Parthvi12