Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: JSONForm select not working in nested fields - Array/Object #12635

Merged
merged 6 commits into from
Apr 8, 2022
Merged

fix: JSONForm select not working in nested fields - Array/Object #12635

merged 6 commits into from
Apr 8, 2022

Conversation

ashit-rath
Copy link
Contributor

@ashit-rath ashit-rath commented Apr 6, 2022 •
edited by github-actions bot
Loading

Description

This PR fixes 2 things

  1. Select field's menu does not open up when used in nested fields like Array or Object
  2. The multiselect dropdown menu width is less than the multiselect itself.

Fixes #12625

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Cypress
  • Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased 
// Code coverage diff between base branch:release and head branch: fix/12625-json-form-select
Status File % Stmts % Branch % Funcs % Lines
🔴 total 56.35 (0) 37.79 (-0.01) 35.96 (0) 56.57 (0)
🟢 app/client/src/utils/WorkerUtil.ts 89.76 (0.78) 72.55 (1.96) 100 (0) 93.33 (0.95)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)
🔴 app/client/src/widgets/JSONFormWidget/fields/MultiSelectField.tsx 28 (-0.77) 4.65 (-0.76) 0 (0) 32.31 (-1.02)

@vercel
Copy link

vercel bot commented Apr 6, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/B2Bdk31JYhoGjcF1c3FibKJzrbXg
✅ Preview: https://appsmith-git-fix-12625-json-form-select-get-appsmith.vercel.app

@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Bug Something isn't working High This issue blocks a user from building or impacts a lot of users JSON Form Issue / features related to the JSON form wiget Needs Triaging Needs attention from maintainers to triage UI Building Pod labels Apr 6, 2022
@ashit-rath
Copy link
Contributor Author

/ok-to-test sha=447a8a5

@ashit-rath ashit-rath removed the Needs Triaging Needs attention from maintainers to triage label Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions github-actions bot added the Needs Triaging Needs attention from maintainers to triage label Apr 6, 2022
@github-actions
Copy link

github-actions bot commented Apr 6, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2103055743.
Workflow: Appsmith External Integration Test Workflow.
Commit: 447a8a5.
PR: 12635.

@github-actions
Copy link

github-actions bot commented Apr 6, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2103055743.
Commit: 447a8a5.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@ashit-rath
Copy link
Contributor Author

/ok-to-test sha=f9d27e8

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2113065408.
Workflow: Appsmith External Integration Test Workflow.
Commit: f9d27e8.
PR: 12635.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2113065408.
Commit: f9d27e8.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@chandannkumar
Copy link

chandannkumar commented Apr 8, 2022 •
edited by loom-gif-previews bot
Loading

@ashit-rath

  • Unable to clear previous input from Currency Input type
    LOOM DEMO

@ashit-rath
Copy link
Contributor Author

@chandannkumar Can you raise a separate issue for that?
Let's just stick with the select and multiselect issue for now.

@ashit-rath
Copy link
Contributor Author

/ok-to-test sha=765582c

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2113865040.
Workflow: Appsmith External Integration Test Workflow.
Commit: 765582c.
PR: 12635.

@chandannkumar
Copy link

Tested this PR and working as expected

  1. Select field's menu does not open up when used in nested fields like Array or Object - Fixed
  2. The multiselect dropdown menu width is less than the multiselect itself - Fixed

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2113865040.
Commit: 765582c.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@ashit-rath
Copy link
Contributor Author

/ok-to-test sha=2f8a01e

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2114493158.
Workflow: Appsmith External Integration Test Workflow.
Commit: 2f8a01e.
PR: 12635.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2114493158.
Commit: 2f8a01e.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@ashit-rath ashit-rath enabled auto-merge (squash) April 8, 2022 13:22
@ashit-rath
Copy link
Contributor Author

/ok-to-test sha=858ed84

@github-actions
Copy link

github-actions bot commented Apr 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2115495498.
Workflow: Appsmith External Integration Test Workflow.
Commit: 858ed84.
PR: 12635.

@ashit-rath ashit-rath disabled auto-merge April 8, 2022 17:24
@ashit-rath ashit-rath merged commit 6a33b4d into release Apr 8, 2022
@ashit-rath ashit-rath deleted the fix/12625-json-form-select branch April 8, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbalaji1192 sbalaji1192 sbalaji1192 approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working High This issue blocks a user from building or impacts a lot of users JSON Form Issue / features related to the JSON form wiget Needs Triaging Needs attention from maintainers to triage Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: JSONForm select field does not open when used in an nested field (Array/Object)
3 participants
@ashit-rath @chandannkumar @sbalaji1192