Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: old list widgets incorrect page size broke pagination controls #12443

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

ashit-rath
Copy link
Contributor

@ashit-rath ashit-rath commented Mar 31, 2022

Description

Old list widgets have a legacy parentRowSpace value 40 which lead to incorrect calculation in the pageSize which was very high than it should be. This leads to the pagination not appearing when server-side pagination is disabled.

Note to Reviewer:
For some reason the parentRowSpace in the widget is 10 and in derived properties it is 40 (which is present in the DSL).
The solution for now is to hard-code the value of parentRowSpace as 10 in the derived properties.

Fixes #12438

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual
  • Cypress

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

⚪ Total coverage has not changed
// Code coverage diff between base branch:release and head branch: fix/list-pagesize-rowspace 
Status File % Stmts % Branch % Funcs % Lines
🔴 app/client/src/utils/WorkerUtil.ts 88.98 (-0.78) 70.59 (-1.96) 100 (0) 92.38 (-0.95)

@ashit-rath ashit-rath added the Critical This issue needs immediate attention. Drop everything else label Mar 31, 2022
@vercel
Copy link

vercel bot commented Mar 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/5vHzaXe15SQUhBddXj2CX77Ez1ep
✅ Preview: https://appsmith-git-fix-list-pagesize-rowspace-get-appsmith.vercel.app

@ashit-rath
Copy link
Contributor Author

/ok-to-test=74a1789

@github-actions github-actions bot added Widgets Product This label groups issues related to widgets Bug Something isn't working List Widget Issues related to the list widget Regressed Scenarios that were working before but have now regressed UI Building Pod labels Mar 31, 2022
@ashit-rath
Copy link
Contributor Author

/ok-to-test sha=74a1789

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2070969611.
Workflow: Appsmith External Integration Test Workflow.
Commit: 74a1789.
PR: 12443.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2070969611.
Commit: 74a1789.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@vivekverma2312
Copy link

@ashit-rath LGTM, tested page size change too on the DP.

@mohanarpit mohanarpit merged commit 50efc68 into release Mar 31, 2022
@mohanarpit mohanarpit deleted the fix/list-pagesize-rowspace branch March 31, 2022 15:09
ashit-rath added a commit that referenced this pull request Apr 1, 2022
ashit-rath added a commit that referenced this pull request Apr 1, 2022
(cherry picked from commit 50efc68)

Co-authored-by: Somangshu Goswami <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Critical This issue needs immediate attention. Drop everything else List Widget Issues related to the list widget Regressed Scenarios that were working before but have now regressed Widgets Product This label groups issues related to widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: List widget pagination is broken for older widgets
4 participants