-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: old list widgets incorrect page size broke pagination controls #12443
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/get-appsmith/appsmith/5vHzaXe15SQUhBddXj2CX77Ez1ep |
/ok-to-test=74a1789 |
/ok-to-test sha=74a1789 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/2070969611. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/2070969611. Click to view performance test results
|
@ashit-rath LGTM, tested page size change too on the DP. |
(cherry picked from commit 50efc68)
(cherry picked from commit 50efc68) Co-authored-by: Somangshu Goswami <[email protected]>
Description
Old list widgets have a legacy parentRowSpace value
40
which lead to incorrect calculation in the pageSize which was very high than it should be. This leads to the pagination not appearing when server-side pagination is disabled.Note to Reviewer:
For some reason the
parentRowSpace
in the widget is10
and in derived properties it is40
(which is present in the DSL).The solution for now is to hard-code the value of
parentRowSpace
as10
in the derived properties.Fixes #12438
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
⚪ Total coverage has not changed