Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrading boxen dependency #12043

Merged
merged 3 commits into from
Mar 24, 2022
Merged

Conversation

mohanarpit
Copy link
Member

Upgrading the boxen dependency because a transitive dependency ansi-regex needs to be upgraded. If the boxen dependency is not being used, we can remove it from the dependency list as well.

@github-actions github-actions bot added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Mar 21, 2022
@github-actions
Copy link

Unable to find test scripts. Please add necessary tests to the PR.

@vercel
Copy link

vercel bot commented Mar 21, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/zHAw58M6yqAP2DxtzmyoA7yD2aUb
✅ Preview: https://appsmith-git-chore-upgrade-dependency-boxen-get-appsmith.vercel.app

Copy link
Member

@sharat87 sharat87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohanarpit yeah looks like it's unused. Let's remove it.

Also, I'd suggest we remove chalk and yargs as well since they aren't exactly critical for the usecase and the fewer dependencies we have the better. I can remove those in a separate PR if preferred.

@sharat87
Copy link
Member

@mohanarpit yargs and chalk are actually used in the code, although superficially. So I removed the usages as well.

I think we are ready to commit, but just have a look at the latest commit and we're good.

@sharat87 sharat87 merged commit f9b28ae into release Mar 24, 2022
@sharat87 sharat87 deleted the chore/upgrade-dependency-boxen branch March 24, 2022 07:27
Irongade pushed a commit that referenced this pull request Mar 24, 2022
agawda pushed a commit to TalentAlpha/appsmith that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants