Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed invitation token from the invite email #1180

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Removed invitation token from the invite email #1180

merged 1 commit into from
Oct 14, 2020

Conversation

pc9795
Copy link
Contributor

@pc9795 pc9795 commented Oct 14, 2020

Description

Removed invitation token from the invite URL in the invitation email

Fixes #650

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Locally using Postman

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pc9795
Copy link
Contributor Author

pc9795 commented Oct 14, 2020

If we don't use inviteToken then we can remove a lot of code with the field in the User object 🤔

@mohanarpit
Copy link
Member

If we don't use inviteToken then we can remove a lot of code with the field in the User object 🤔

Agreed. The idea is to correct the displayed URL for now. The reason I don't want to remove the excess code immediately is that we may need to implement an expiry feature on the invite in the near future. Currently, our user invitations don't expire. If we need to implement expiry, we'll have to re-introduce the token. Hence, I'm in favour of keeping the token related code for the time being.

@mohanarpit mohanarpit merged commit 8a892b6 into appsmithorg:release Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Corrupt token is allowing activation of the membership.
2 participants