Added an WebExceptionHandler #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pc9795
commented
Oct 13, 2020
| import static org.springframework.web.reactive.function.server.RouterFunctions.route; | ||
|
|
||
| @Component | ||
| @Order(-2) |
There was a problem hiding this comment.
This handler is ordered by @Order(-2) as the ordering of default handler is -1 so we want this to handle everything.
pc9795
commented
Oct 13, 2020
| ServerProperties serverProperties, ApplicationContext applicationContext, | ||
| ObjectProvider<ViewResolver> viewResolvers, | ||
| ServerCodecConfigurer serverCodecConfigurer) { | ||
| super(errorAttributes, resourceProperties, serverProperties.getError(), applicationContext); |
There was a problem hiding this comment.
To check more about how it is configured look configuration of DefaultErrorWebExceptionHandler in ErrorWebFluxAutoConfiguration
mohanarpit
approved these changes
Oct 15, 2020
|
@pc9795 Thank you so much for this PR! It has been merged 🎉 |
|
@all-contributors Please add @pc9795 for their excellent contributions to improve Appsmith's code. |
|
I've put up a pull request to add @pc9795! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the errors which are not handled by
@ExceptionHandler(ex- 404 by the Netty) are handled by DefaultErrorWebExceptionHandler which is autoconfigured by Spring boot.The behaviour of this particular handler is to render an HTML for browsers and JSON for machines (ex- Postman):
https://github.com/spring-projects/spring-boot/blob/bd27756efcad283cf5b6bf790e54ce2a4192c0c7/spring-boot-project/spring-boot-autoconfigure/src/main/java/org/springframework/boot/autoconfigure/web/reactive/error/DefaultErrorWebExceptionHandler.java#L109
You can see the below screen shots:
But for APIs, we can create a custom handler to always render JSON, especially in our expected format.
Screenshot with this handler:
Fixes #804
Type of change
How Has This Been Tested?
Checklist: