Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: adding tests for smtp using test-event-driver #11777

Merged
merged 6 commits into from
Mar 11, 2022
Merged

test: adding tests for smtp using test-event-driver #11777

merged 6 commits into from
Mar 11, 2022

Conversation

Parthvi12
Copy link
Contributor

@Parthvi12 Parthvi12 commented Mar 10, 2022 •
edited by github-actions bot
Loading

Description

This PR contains tests for SMTP using ted and fixes git tests

Fixes #11778

How Has This Been Tested?

locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased 
// Code coverage diff between base branch:release and head branch: smtpTests
Status File % Stmts % Branch % Funcs % Lines
🟢 total 55.83 (0.01) 37.16 (0.01) 35.21 (0) 56.14 (0)
🟢 app/client/src/utils/WorkerUtil.ts 89.76 (0.78) 72.55 (1.96) 100 (0) 93.33 (0.95)
🟢 app/client/src/utils/autocomplete/TernServer.ts 52.94 (0.23) 41.67 (0.84) 36.21 (0) 56.99 (0.25)

@vercel
Copy link

vercel bot commented Mar 10, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/64rXgKUkV3UUHYPLqxrtD48hgp4e
✅ Preview: https://appsmith-git-smtptests-get-appsmith.vercel.app

@github-actions github-actions bot added skip-changelog Adding this label to a PR prevents it from being listed in the changelog Test labels Mar 10, 2022
@Parthvi12
Copy link
Contributor Author

/ok-to-test sha=e28c921

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1964034349.
Workflow: Appsmith External Integration Test Workflow.
Commit: e28c921.
PR: 11777.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1964034349.
Commit: e28c921.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1964034349.
Commit: e28c921.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@Parthvi12
Copy link
Contributor Author

/ok-to-test sha=ed8606f

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1964506257.
Workflow: Appsmith External Integration Test Workflow.
Commit: ed8606f.
PR: 11777.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1964506257.
Commit: ed8606f.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@Parthvi12
Update setup-test.sh
6a21f34 
added smtp port
@Parthvi12
Copy link
Contributor Author

/ok-to-test sha=6a21f34

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1967107304.
Workflow: Appsmith External Integration Test Workflow.
Commit: 6a21f34.
PR: 11777.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1967107304.
Commit: 6a21f34.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@Parthvi12
Copy link
Contributor Author

/ok-to-test sha=7b1c6d4

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1967397757.
Workflow: Appsmith External Integration Test Workflow.
Commit: 7b1c6d4.
PR: 11777.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1967397757.
Commit: 7b1c6d4.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1967397757.
Commit: 7b1c6d4.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@Parthvi12
Copy link
Contributor Author

/ok-to-test sha=bd39b47

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1968825134.
Workflow: Appsmith External Integration Test Workflow.
Commit: bd39b47.
PR: 11777.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1968825134.
Commit: bd39b47.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@Parthvi12 Parthvi12 enabled auto-merge (squash) March 11, 2022 13:30
@mohanarpit mohanarpit merged commit 939e906 into release Mar 11, 2022
@mohanarpit mohanarpit deleted the smtpTests branch March 11, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yatinappsmith yatinappsmith yatinappsmith approved these changes

@Aishwarya-U-R Aishwarya-U-R Awaiting requested review from Aishwarya-U-R

Assignees
No one assigned
Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Add cypress tests for SMTP using test-event-driver
3 participants
@Parthvi12 @yatinappsmith @mohanarpit