Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make sure discard changes for git is applied even if client exits the flow before server responds #11666

Merged
merged 2 commits into from
Mar 9, 2022
Merged

chore: Make sure discard changes for git is applied even if client exits the flow before server responds #11666

merged 2 commits into from
Mar 9, 2022

Conversation

abhvsn
Copy link
Contributor

@abhvsn abhvsn commented Mar 7, 2022

Fixes #11665

@vercel
Copy link

vercel bot commented Mar 7, 2022 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/7FSmm5aqWkiodFhwyjt3vaHuTqHD
✅ Preview: https://appsmith-git-monosink-git-discard-change-get-appsmith.vercel.app

@abhvsn
Copy link
Contributor Author

abhvsn commented Mar 7, 2022

/ok-to-test sha=73a0b75

@github-actions
Copy link

github-actions bot commented Mar 7, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1944110129.
Workflow: Appsmith External Integration Test Workflow.
Commit: 73a0b75.
PR: 11666.

@abhvsn abhvsn self-assigned this Mar 7, 2022
@abhvsn abhvsn requested a review from AnaghHegde March 7, 2022 08:35
@github-actions
Copy link

github-actions bot commented Mar 8, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1944110129.
Workflow: Appsmith External Integration Test Workflow.
Commit: 73a0b75.
PR: 11666.

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1944110129.
Commit: 73a0b75.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@abhvsn abhvsn added the skip-changelog Adding this label to a PR prevents it from being listed in the changelog label Mar 9, 2022
@abhvsn abhvsn merged commit bc929f2 into release Mar 9, 2022
@abhvsn abhvsn deleted the monosink-git-discard-change branch March 9, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnaghHegde AnaghHegde AnaghHegde approved these changes

Assignees

@abhvsn abhvsn

Labels
skip-changelog Adding this label to a PR prevents it from being listed in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task]: Don't take client subscription into account for git discard changes API
2 participants
@abhvsn @AnaghHegde