Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add API for delete branch for git connected application #11432

Merged
merged 7 commits into from
Mar 2, 2022

Conversation

AnaghHegde
Copy link
Member

@AnaghHegde AnaghHegde commented Feb 24, 2022

Description

Present the user has to delete the branch in the remote repo first and then come back to Appsmith UI and trigger the sync branches CTA. This is a bad UX and in some scenarios this CTA does not work as expected.
This PR change set will solve this by exposing an API for the client for the delete action

Fixes #11272

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Locally
  • TCs are on the way

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@AnaghHegde AnaghHegde self-assigned this Feb 24, 2022
@vercel
Copy link

vercel bot commented Feb 24, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/J9P8kEZRTGEQfnTkyg1TBcAfZMSL
✅ Preview: https://appsmith-git-feat-delete-branch-get-appsmith.vercel.app

@github-actions github-actions bot added the Enhancement New feature or request label Feb 24, 2022
@AnaghHegde
Copy link
Member Author

/ok-to-test sha=f41e0ef

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1894957625.
Workflow: Appsmith External Integration Test Workflow.
Commit: f41e0ef.
PR: 11432.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1894957625.
Commit: f41e0ef.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

Copy link
Contributor

@abhvsn abhvsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits but LGTM

@AnaghHegde
Copy link
Member Author

/ok-to-test sha=5ce33a5

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1905248279.
Workflow: Appsmith External Integration Test Workflow.
Commit: 5ce33a5.
PR: 11432.

@AnaghHegde AnaghHegde enabled auto-merge (squash) February 27, 2022 06:18
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1905248279.
Commit: 5ce33a5.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@AnaghHegde
Copy link
Member Author

/ok-to-test sha=ee075b2

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1905425502.
Workflow: Appsmith External Integration Test Workflow.
Commit: ee075b2.
PR: 11432.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1905425502.
Commit: ee075b2.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@AnaghHegde
Copy link
Member Author

/ok-to-test sha=ee075b2

@github-actions
Copy link

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1908438984.
Workflow: Appsmith External Integration Test Workflow.
Commit: ee075b2.
PR: 11432.

@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1908438984.
Commit: ee075b2.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

1 similar comment
@github-actions
Copy link

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1908438984.
Commit: ee075b2.
Results:

Click to view performance test results

Median Mean SD.Sample SD.Population

@AnaghHegde AnaghHegde merged commit 1d90a9f into release Mar 2, 2022
@AnaghHegde AnaghHegde deleted the feat/delete-branch branch March 2, 2022 13:42
Tooluloope added a commit that referenced this pull request Mar 11, 2022
* fix: handle main container height (#11461)

* fix: use sentence casing (#11376)

* feat: Add API for delete branch for git connected application (#11432)

* Add API to delete git branches

* WIP

* Fix test failures

* Change the method from POST to DELETE

* Changes per review

* Changes per review

* fix: separating property pane out of widgets editor to avoid triggering unwanted events on widget canvas (#11396)

* separating property pane out of widgets editor to avoid triggering unwanted events on widget canvas

* fix: changed download flow for image control (#11391)

* fix: changed download flow for image control

* test: cypress test added

* fix cypress test case

* fix: Modified error from string to first error object in debugger log (#11511)

* fix: Modified action execution endpoint (#9473)

* test: Automated tests for Promises & related bugs in Typescript + Flaky fixes (#10378)

* Flaky fixes

* S3 CRUD intercept fix

* S3 CRUD script change revert

* S3 revert!

* .its(store) not present fix

* TS failure fixes

* ChartDataopoint js removed

* JSObject ts flaky fix

* Bugs 9789, 10150 scripted

* Bug 10284 & 9782 scripted

* Updated dsl file names

* Table_Widget case #7 flaky fix

* Bug 10150 scripting improved

* DocumentViewer spec flaky fix

* Input widget locator corrected

* MemberRoles cases script started in TS

* UpdateUserRoleInOrg() fix

* Skip JSObject_To_ListWidgetSpec.ts until #10284

* Add validation

* JSObject_To_ListWidgetSpec.ts timeout increase

* Skipping tests until bug 10284 is fixed

* Increased wait time

* UpdateUserRoleInOrg() updated

* MemberRoles_Spec.ts fixed

* JSObjToInput - updated

* Postgres flaky fix

* Member Roles aka CreateOrg test flaky fix

* JSObToListWidget_Spec.ts - commenting until bugfix

* COmmenting JSobjToInput spec

* Commonlocators added back

* Entity explorer name fix

* Locators fix

* Locator corrected

* Cypress.json removed files from ignoring list

* S3 & Postgress failures fix

* Postgress failure locator fix

* S3 upload script skipping until bug fix

* Params Bug 10784 script started

* Fixing Promises Spec

* Increased wait time!

* MigrationSpec - Image column,Cardformat,Pagestyles

* S3, Postgres, Promise - failures fix

* Canvas renamed

* Bug 11415 - Added Validations

* InputWidgets_navigateTo - flaky fix

* MigrationSpec - import change

* Locators files - Json to Js conversion

* DS plugnis name change

* Locators - Json to JS conversion

* Locators - Json to JS updations

* Select_Widget_Value flaky fix

* Adding timeout for execute calls to finish

* Migration spec - diff syntax+List.js flaky fix

* List & MIgration flaky fix

* feat: add smart substitution handling for known MongoDB types (#11135)

* shelf: start working on substitution for `ISODate`

* a draft for Sumit to check what I did wrong in my tests

* test: tests are working

* test: cleanup

* refactor: add replacementDataType parameter to DataTypeStringUtils.jsonSmartReplacementPlaceholderWithValue

* fix: remove quotes for Mongo Types work in single form, arrays and json.

* add handling for more use cases
add/update more TCs

* add comments

* add more comments

* add space (cosmetic change)

Co-authored-by: Sumit Kumar <[email protected]>

* fix: 9824 Google Sheet to filter empty condition ver.2 (#11435)

* fix: 9824 Google Sheet to filter empty condition ver.2

* Code review comments updated

* Updates as per review comments - Ver 3

* Resolved errors found during testing

* Code review comments fix

Co-authored-by: Leo Thomas <[email protected]>

* feat: Add disconnect button on auth config pages and form login callout banner (#11389)

* added form login callout banner

* form login config page changes

* form login config page changes

* added redirecturl and uneditable field components

* added disconnect button on auth pages

* Added env variables for form login auth page

* added disconnect button on auth pages

* updated docs link for dform login callout doc

* added condition for disconnect button

* added ce changes done on ee

* updated css

* suggested changes in PR review

* suggested changes in PR review

* suggested changes in PR review

* reverted gitignore files changes

* reverted gitignore files changes

* updated logic for saving admin settings

* removed unused imports

* added changes for taginput field

* removed console

* removed warning

* removed unwanted changes

* fix: Number type input should honour required property when value is empty string (#11442)

* feat: API to discard changes for git connected applications (#11362)

* Add discard changes functionality for git

* Recover deleted resources from the file system and refactor

* Remove untracked files, remove unwanted actions

* Testcases added for discard changes

* Added comments

* test: Test fix grep spec case insesitive (#11523)

* added grep -i spec


Co-authored-by: Aishwarya-U-R <[email protected]>

* Remove curl call to download certbot config files for ssl (#11372)

* Refactor entrypoint script to support migrate slim to fat container (#11519)

* fix: Changed test class reference to CE (#11578)

* fix: removing unnecessary paths to evaluate (#11341)

* removing unnecessary paths to evaluate

* created regex and small refactor

* test: bugAutomation4136 (#11245)

* bugAutomation4136

* Added tests for bug 5134 / 4136

* updated test data

* Bug7258 automated

* feat: Application templates (#10964)

* fix: warning message - if child property doesn't exist in data tree (#10351)

* makeParentsDependOnChild - return if child doesn't exist in allKeys

* add unit tests

* add nested object to unit test

* fix unit tests

* fix unit tests

* add warning messages

* add comments for mock

* fix: reword datascource message

* fix: #11301 filter pane text css updated (#11410)

* fix: Remove reset password button if form login is disabled (#11591)

* increased restart server timeout & showing reset pwd only if form login is enabled

* Updated callout for disconnect button

* added space

* chore: Modified plugin config aggregation logic (#11561)

* fix: Modified plugin config aggregation logic

* Modified logs a bit

* Reverted incorrect path from another branch

* Fix apiContentType bug (#11600)

* fix: Drop down multiselect usage fixes for query forms (#11465)

* Update: Type for initialValues

- Added string[] to the initialValues type to allow dropdowns to have multiple values too

* Remove: Old projection selector file

- Removed projection selector file
- The new usage will be the old drop down file with new options

* Update: Dropdown file

- Added options to select and deselect the multiple drop down options
- Added functions to handle selection and deselection
- Added option in final render method to allow searching
- Handled default values for multi select and single select drop downs

* Update FormControlRegistry.tsx

- Updated projection component to point to drop down component with extra options

* Update: Fixed logic for dropdown select

- Fixed the if condition blocks to catch the case when the multiselect output is not an array

* fix: firestore queries asterisk (#11599)

* fix: remove asterisk from non-mandatory fields in firestore query

* making one false

* fix: remove asterisk from non-mandatory fields in firestore query

* fix: remove asterisk from non-mandatory fields in firestore query

Co-authored-by: Hritik Kumar <[email protected]>

* chore: Soft delete resources across Appsmith board for delete operation (#11555)

* Soft delete resources

* Add TC and migrations

* added event to stop loading (#11597)

* fix: Signup text update & code optimisation (#11606)

* text change for signup admin settings & code optimized

* minor change

* feat: Add new API to combine get application details and get pages API (#11448)

Merges the get application details and get page list API into one. This API takes either applicationId or pageId and returns the list of pages of that application.

* feat: Make icon selector keyboard accessible (#10460)

* feat: virtualize icon rendering makes icon selector smoother

* make icon selector keyboard accessible

* fix: Aspect ratio of video changes when Camera widget is longer in width than the aspect ratio (#11453)

* feat: add tooltip to column header text which overflows (#10666)

* feature: add tooltip to column header text which overflows (#10495)

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* feature: add tooltip to column header text which overflows (#10495)

* remove unused styled components

* remove unused import

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix cypress command to handle the new changes

* Fix: test issues

Co-authored-by: Tolulope Adetula <[email protected]>

* Don't provide extra information on forgot password (#11596)

* removed default isAsync false from new js action (#11427)

Co-authored-by: Rishabh-Rathod <[email protected]>

* test: Automated tests for Bug #10784 + Failure fixes (#11586)

* Scripting Bug # 10784

* Bug 10784 - added script

* Uncommenting - JSObjToInput spec

* Uncommenting - JSObjtoListWidget spec

* SelectEntityByName reverted

* Migration spec locators fix

* Table_GeneralProp spec updated

* Read Table Row/Column locator updated

* Calling WaitAutoSave in JSObj creation

* 19px to 28px to match CI run

* CreateJSObject() - adding back wait time

* Reverting 28px to 19px

* Commenting table specs until CI fixed

* Commenting table spec 9th case

* UNcommenting

* Commenting Table_GeneralProp failure case

* Default action config values not being set (#11632)

* Add check for default branch before deleting branch (#11631)

* fix: remove EDIT button (#11356)

* chore: update icons in org menu (#11548)


* chore: update icons in org menu
* chore: update user-heart-line and update org menu
* chore: use member instead of members for icon name

* test: adding MySQL noise test (#11469)

* adding MySQL noise test

* fixed git tests

* updating git tests

* [Fix] Added permission in security config for themes (#11527)

Theme API path was not added added to security config path. As a result, themes in published mode in public apps were not loaded. This PR fixes that issue.

* fix: Style values of the page and default value for telemetry (#11640)

* chore: Change watchtower to latest from latest-dev (#11669)

This is because watchtower:latest-dev doesn't run on ARM architectures.

* fix: Modified root json for SMTP to comply with UQI aggregation rules (#11676)

* Fix startup failing if signup disabled is empty (#11686)

Signed-off-by: Shrikant Sharat Kandula <[email protected]>

* fix: table widget value displacement (#11650)

* Updated Label Config

* Revert "fix: handle main container height (#11461)" (#11674)

This reverts commit c6f5dcb.

* test: Add Github token to test build docker (#11729)

* test: added github token to re-run (#11771)

Co-authored-by: Aishwarya-U-R <[email protected]>

Co-authored-by: Bhavin K <[email protected]>
Co-authored-by: f0c1s <[email protected]>
Co-authored-by: Anagh Hegde <[email protected]>
Co-authored-by: rahulramesha <[email protected]>
Co-authored-by: Nidhi <[email protected]>
Co-authored-by: Aishwarya-U-R <[email protected]>
Co-authored-by: Mojtaba <[email protected]>
Co-authored-by: Sumit Kumar <[email protected]>
Co-authored-by: Leo Thomas <[email protected]>
Co-authored-by: Leo Thomas <[email protected]>
Co-authored-by: Ankita Kinger <[email protected]>
Co-authored-by: balajisoundar <[email protected]>
Co-authored-by: Abhijeet <[email protected]>
Co-authored-by: yatinappsmith <[email protected]>
Co-authored-by: geekup-legodevops <[email protected]>
Co-authored-by: Apeksha Bhosale <[email protected]>
Co-authored-by: NandanAnantharamu <[email protected]>
Co-authored-by: akash-codemonk <[email protected]>
Co-authored-by: Anand Srinivasan <[email protected]>
Co-authored-by: Segun Daniel Oluwadare <[email protected]>
Co-authored-by: Yash Vibhandik <[email protected]>
Co-authored-by: Ayangade Adeoluwa <[email protected]>
Co-authored-by: Ayush Pahwa <[email protected]>
Co-authored-by: devnamrits <[email protected]>
Co-authored-by: Hritik Kumar <[email protected]>
Co-authored-by: Nayan <[email protected]>
Co-authored-by: Aswath K <[email protected]>
Co-authored-by: Paul Li <[email protected]>
Co-authored-by: Vicky Bansal <[email protected]>
Co-authored-by: Shrikant Sharat Kandula <[email protected]>
Co-authored-by: Rishabh-Rathod <[email protected]>
Co-authored-by: Parthvi12 <[email protected]>
Co-authored-by: Nikhil Nandagopal <[email protected]>
Co-authored-by: Somangshu Goswami <[email protected]>
sum35h added a commit that referenced this pull request Mar 16, 2022
commit b98f2bd
Author: Trisha Anand <[email protected]>
Date:   Tue Mar 15 17:43:02 2022 +0530

    chore: Increasing the start time check for backend process to stay up to 3.5 minutes to ensure that all the checks have run and some grace time before marking the process to be running. (#11876)

commit e037f28
Merge: 0addde0 f828a8e
Author: Trisha Anand <[email protected]>
Date:   Mon Mar 14 12:36:31 2022 +0530

    fix: Analytics sendEvent should be able to send events even during sign in

commit f828a8e
Author: Trisha Anand <[email protected]>
Date:   Sun Mar 13 22:23:08 2022 +0530

    fix: Analytics sendEvent should be able to send events even during sign in process (#11818)

commit 0addde0
Merge: aa7114e 0fc609a
Author: Tolulope Adetula <[email protected]>
Date:   Fri Mar 11 11:32:51 2022 +0100

    Merge pull request #11802 from appsmithorg/promotion/v1.6.15

    ci: Release v1.6.15

commit aa7114e
Merge: 2586f1c cee4b7c
Author: Arpit Mohan <[email protected]>
Date:   Fri Mar 11 11:14:32 2022 +0100

    ci: revert "ci: Release v1.6.15"

commit cee4b7c
Author: Tolulope Adetula <[email protected]>
Date:   Fri Mar 11 01:26:17 2022 -0800

    Revert "ci: Release v1.6.15 (#11726)"

    This reverts commit 2586f1c.

commit 2586f1c
Author: Tolulope Adetula <[email protected]>
Date:   Fri Mar 11 07:50:07 2022 +0100

    ci: Release v1.6.15 (#11726)

    * fix: handle main container height (#11461)

    * fix: use sentence casing (#11376)

    * feat: Add API for delete branch for git connected application (#11432)

    * Add API to delete git branches

    * WIP

    * Fix test failures

    * Change the method from POST to DELETE

    * Changes per review

    * Changes per review

    * fix: separating property pane out of widgets editor to avoid triggering unwanted events on widget canvas (#11396)

    * separating property pane out of widgets editor to avoid triggering unwanted events on widget canvas

    * fix: changed download flow for image control (#11391)

    * fix: changed download flow for image control

    * test: cypress test added

    * fix cypress test case

    * fix: Modified error from string to first error object in debugger log (#11511)

    * fix: Modified action execution endpoint (#9473)

    * test: Automated tests for Promises & related bugs in Typescript + Flaky fixes (#10378)

    * Flaky fixes

    * S3 CRUD intercept fix

    * S3 CRUD script change revert

    * S3 revert!

    * .its(store) not present fix

    * TS failure fixes

    * ChartDataopoint js removed

    * JSObject ts flaky fix

    * Bugs 9789, 10150 scripted

    * Bug 10284 & 9782 scripted

    * Updated dsl file names

    * Table_Widget case #7 flaky fix

    * Bug 10150 scripting improved

    * DocumentViewer spec flaky fix

    * Input widget locator corrected

    * MemberRoles cases script started in TS

    * UpdateUserRoleInOrg() fix

    * Skip JSObject_To_ListWidgetSpec.ts until #10284

    * Add validation

    * JSObject_To_ListWidgetSpec.ts timeout increase

    * Skipping tests until bug 10284 is fixed

    * Increased wait time

    * UpdateUserRoleInOrg() updated

    * MemberRoles_Spec.ts fixed

    * JSObjToInput - updated

    * Postgres flaky fix

    * Member Roles aka CreateOrg test flaky fix

    * JSObToListWidget_Spec.ts - commenting until bugfix

    * COmmenting JSobjToInput spec

    * Commonlocators added back

    * Entity explorer name fix

    * Locators fix

    * Locator corrected

    * Cypress.json removed files from ignoring list

    * S3 & Postgress failures fix

    * Postgress failure locator fix

    * S3 upload script skipping until bug fix

    * Params Bug 10784 script started

    * Fixing Promises Spec

    * Increased wait time!

    * MigrationSpec - Image column,Cardformat,Pagestyles

    * S3, Postgres, Promise - failures fix

    * Canvas renamed

    * Bug 11415 - Added Validations

    * InputWidgets_navigateTo - flaky fix

    * MigrationSpec - import change

    * Locators files - Json to Js conversion

    * DS plugnis name change

    * Locators - Json to JS conversion

    * Locators - Json to JS updations

    * Select_Widget_Value flaky fix

    * Adding timeout for execute calls to finish

    * Migration spec - diff syntax+List.js flaky fix

    * List & MIgration flaky fix

    * feat: add smart substitution handling for known MongoDB types (#11135)

    * shelf: start working on substitution for `ISODate`

    * a draft for Sumit to check what I did wrong in my tests

    * test: tests are working

    * test: cleanup

    * refactor: add replacementDataType parameter to DataTypeStringUtils.jsonSmartReplacementPlaceholderWithValue

    * fix: remove quotes for Mongo Types work in single form, arrays and json.

    * add handling for more use cases
    add/update more TCs

    * add comments

    * add more comments

    * add space (cosmetic change)

    Co-authored-by: Sumit Kumar <[email protected]>

    * fix: 9824 Google Sheet to filter empty condition ver.2 (#11435)

    * fix: 9824 Google Sheet to filter empty condition ver.2

    * Code review comments updated

    * Updates as per review comments - Ver 3

    * Resolved errors found during testing

    * Code review comments fix

    Co-authored-by: Leo Thomas <[email protected]>

    * feat: Add disconnect button on auth config pages and form login callout banner (#11389)

    * added form login callout banner

    * form login config page changes

    * form login config page changes

    * added redirecturl and uneditable field components

    * added disconnect button on auth pages

    * Added env variables for form login auth page

    * added disconnect button on auth pages

    * updated docs link for dform login callout doc

    * added condition for disconnect button

    * added ce changes done on ee

    * updated css

    * suggested changes in PR review

    * suggested changes in PR review

    * suggested changes in PR review

    * reverted gitignore files changes

    * reverted gitignore files changes

    * updated logic for saving admin settings

    * removed unused imports

    * added changes for taginput field

    * removed console

    * removed warning

    * removed unwanted changes

    * fix: Number type input should honour required property when value is empty string (#11442)

    * feat: API to discard changes for git connected applications (#11362)

    * Add discard changes functionality for git

    * Recover deleted resources from the file system and refactor

    * Remove untracked files, remove unwanted actions

    * Testcases added for discard changes

    * Added comments

    * test: Test fix grep spec case insesitive (#11523)

    * added grep -i spec

    Co-authored-by: Aishwarya-U-R <[email protected]>

    * Remove curl call to download certbot config files for ssl (#11372)

    * Refactor entrypoint script to support migrate slim to fat container (#11519)

    * fix: Changed test class reference to CE (#11578)

    * fix: removing unnecessary paths to evaluate (#11341)

    * removing unnecessary paths to evaluate

    * created regex and small refactor

    * test: bugAutomation4136 (#11245)

    * bugAutomation4136

    * Added tests for bug 5134 / 4136

    * updated test data

    * Bug7258 automated

    * feat: Application templates (#10964)

    * fix: warning message - if child property doesn't exist in data tree (#10351)

    * makeParentsDependOnChild - return if child doesn't exist in allKeys

    * add unit tests

    * add nested object to unit test

    * fix unit tests

    * fix unit tests

    * add warning messages

    * add comments for mock

    * fix: reword datascource message

    * fix: #11301 filter pane text css updated (#11410)

    * fix: Remove reset password button if form login is disabled (#11591)

    * increased restart server timeout & showing reset pwd only if form login is enabled

    * Updated callout for disconnect button

    * added space

    * chore: Modified plugin config aggregation logic (#11561)

    * fix: Modified plugin config aggregation logic

    * Modified logs a bit

    * Reverted incorrect path from another branch

    * Fix apiContentType bug (#11600)

    * fix: Drop down multiselect usage fixes for query forms (#11465)

    * Update: Type for initialValues

    - Added string[] to the initialValues type to allow dropdowns to have multiple values too

    * Remove: Old projection selector file

    - Removed projection selector file
    - The new usage will be the old drop down file with new options

    * Update: Dropdown file

    - Added options to select and deselect the multiple drop down options
    - Added functions to handle selection and deselection
    - Added option in final render method to allow searching
    - Handled default values for multi select and single select drop downs

    * Update FormControlRegistry.tsx

    - Updated projection component to point to drop down component with extra options

    * Update: Fixed logic for dropdown select

    - Fixed the if condition blocks to catch the case when the multiselect output is not an array

    * fix: firestore queries asterisk (#11599)

    * fix: remove asterisk from non-mandatory fields in firestore query

    * making one false

    * fix: remove asterisk from non-mandatory fields in firestore query

    * fix: remove asterisk from non-mandatory fields in firestore query

    Co-authored-by: Hritik Kumar <[email protected]>

    * chore: Soft delete resources across Appsmith board for delete operation (#11555)

    * Soft delete resources

    * Add TC and migrations

    * added event to stop loading (#11597)

    * fix: Signup text update & code optimisation (#11606)

    * text change for signup admin settings & code optimized

    * minor change

    * feat: Add new API to combine get application details and get pages API (#11448)

    Merges the get application details and get page list API into one. This API takes either applicationId or pageId and returns the list of pages of that application.

    * feat: Make icon selector keyboard accessible (#10460)

    * feat: virtualize icon rendering makes icon selector smoother

    * make icon selector keyboard accessible

    * fix: Aspect ratio of video changes when Camera widget is longer in width than the aspect ratio (#11453)

    * feat: add tooltip to column header text which overflows (#10666)

    * feature: add tooltip to column header text which overflows (#10495)

    * remove unused import

    * feature: add tooltip to column header text which overflows (#10495)

    * remove unused styled components

    * remove unused import

    * feature: add tooltip to column header text which overflows (#10495)

    * remove unused styled components

    * remove unused import

    * Fix cypress command to handle the new changes

    * Fix cypress command to handle the new changes

    * Fix cypress command to handle the new changes

    * Fix: test issues

    Co-authored-by: Tolulope Adetula <[email protected]>

    * Don't provide extra information on forgot password (#11596)

    * removed default isAsync false from new js action (#11427)

    Co-authored-by: Rishabh-Rathod <[email protected]>

    * test: Automated tests for Bug #10784 + Failure fixes (#11586)

    * Scripting Bug # 10784

    * Bug 10784 - added script

    * Uncommenting - JSObjToInput spec

    * Uncommenting - JSObjtoListWidget spec

    * SelectEntityByName reverted

    * Migration spec locators fix

    * Table_GeneralProp spec updated

    * Read Table Row/Column locator updated

    * Calling WaitAutoSave in JSObj creation

    * 19px to 28px to match CI run

    * CreateJSObject() - adding back wait time

    * Reverting 28px to 19px

    * Commenting table specs until CI fixed

    * Commenting table spec 9th case

    * UNcommenting

    * Commenting Table_GeneralProp failure case

    * Default action config values not being set (#11632)

    * Add check for default branch before deleting branch (#11631)

    * fix: remove EDIT button (#11356)

    * chore: update icons in org menu (#11548)

    * chore: update icons in org menu
    * chore: update user-heart-line and update org menu
    * chore: use member instead of members for icon name

    * test: adding MySQL noise test (#11469)

    * adding MySQL noise test

    * fixed git tests

    * updating git tests

    * [Fix] Added permission in security config for themes (#11527)

    Theme API path was not added added to security config path. As a result, themes in published mode in public apps were not loaded. This PR fixes that issue.

    * fix: Style values of the page and default value for telemetry (#11640)

    * chore: Change watchtower to latest from latest-dev (#11669)

    This is because watchtower:latest-dev doesn't run on ARM architectures.

    * fix: Modified root json for SMTP to comply with UQI aggregation rules (#11676)

    * Fix startup failing if signup disabled is empty (#11686)

    Signed-off-by: Shrikant Sharat Kandula <[email protected]>

    * fix: table widget value displacement (#11650)

    * Updated Label Config

    * Revert "fix: handle main container height (#11461)" (#11674)

    This reverts commit c6f5dcb.

    * test: Add Github token to test build docker (#11729)

    * test: added github token to re-run (#11771)

    Co-authored-by: Aishwarya-U-R <[email protected]>

    Co-authored-by: Bhavin K <[email protected]>
    Co-authored-by: f0c1s <[email protected]>
    Co-authored-by: Anagh Hegde <[email protected]>
    Co-authored-by: rahulramesha <[email protected]>
    Co-authored-by: Nidhi <[email protected]>
    Co-authored-by: Aishwarya-U-R <[email protected]>
    Co-authored-by: Mojtaba <[email protected]>
    Co-authored-by: Sumit Kumar <[email protected]>
    Co-authored-by: Leo Thomas <[email protected]>
    Co-authored-by: Leo Thomas <[email protected]>
    Co-authored-by: Ankita Kinger <[email protected]>
    Co-authored-by: balajisoundar <[email protected]>
    Co-authored-by: Abhijeet <[email protected]>
    Co-authored-by: yatinappsmith <[email protected]>
    Co-authored-by: geekup-legodevops <[email protected]>
    Co-authored-by: Apeksha Bhosale <[email protected]>
    Co-authored-by: NandanAnantharamu <[email protected]>
    Co-authored-by: akash-codemonk <[email protected]>
    Co-authored-by: Anand Srinivasan <[email protected]>
    Co-authored-by: Segun Daniel Oluwadare <[email protected]>
    Co-authored-by: Yash Vibhandik <[email protected]>
    Co-authored-by: Ayangade Adeoluwa <[email protected]>
    Co-authored-by: Ayush Pahwa <[email protected]>
    Co-authored-by: devnamrits <[email protected]>
    Co-authored-by: Hritik Kumar <[email protected]>
    Co-authored-by: Nayan <[email protected]>
    Co-authored-by: Aswath K <[email protected]>
    Co-authored-by: Paul Li <[email protected]>
    Co-authored-by: Vicky Bansal <[email protected]>
    Co-authored-by: Shrikant Sharat Kandula <[email protected]>
    Co-authored-by: Rishabh-Rathod <[email protected]>
    Co-authored-by: Parthvi12 <[email protected]>
    Co-authored-by: Nikhil Nandagopal <[email protected]>
    Co-authored-by: Somangshu Goswami <[email protected]>

commit 0fc609a
Author: yatinappsmith <[email protected]>
Date:   Thu Mar 10 18:28:56 2022 +0530

    test: added github token to re-run (#11771)

    Co-authored-by: Aishwarya-U-R <[email protected]>

commit f6ea885
Author: yatinappsmith <[email protected]>
Date:   Wed Mar 9 20:30:15 2022 +0530

    test: Add Github token to test build docker (#11729)

commit 9b723ff
Merge: c9760ed a0dc77a
Author: Somangshu Goswami <[email protected]>
Date:   Tue Mar 8 15:04:55 2022 +0530

    Merge branch 'master' into release

commit c9760ed
Author: Bhavin K <[email protected]>
Date:   Tue Mar 8 12:54:40 2022 +0530

    Revert "fix: handle main container height (#11461)" (#11674)

    This reverts commit c6f5dcb.

commit 8a63a3d
Author: Nikhil Nandagopal <[email protected]>
Date:   Tue Mar 8 12:52:20 2022 +0530

    Updated Label Config

commit b17cd2e
Author: Tolulope Adetula <[email protected]>
Date:   Tue Mar 8 07:06:32 2022 +0100

    fix: table widget value displacement (#11650)

commit ae5f956
Author: Shrikant Sharat Kandula <[email protected]>
Date:   Mon Mar 7 17:38:18 2022 +0530

    Fix startup failing if signup disabled is empty (#11686)

    Signed-off-by: Shrikant Sharat Kandula <[email protected]>

commit 966564d
Author: Nidhi <[email protected]>
Date:   Mon Mar 7 14:56:54 2022 +0530

    fix: Modified root json for SMTP to comply with UQI aggregation rules (#11676)

commit 1233f7f
Author: Shrikant Sharat Kandula <[email protected]>
Date:   Mon Mar 7 13:58:20 2022 +0530

    chore: Change watchtower to latest from latest-dev (#11669)

    This is because watchtower:latest-dev doesn't run on ARM architectures.

commit af5483c
Author: Ankita Kinger <[email protected]>
Date:   Mon Mar 7 11:36:34 2022 +0530

    fix: Style values of the page and default value for telemetry (#11640)

commit be5b12b
Author: Nayan <[email protected]>
Date:   Mon Mar 7 01:43:26 2022 +0600

    [Fix] Added permission in security config for themes (#11527)

    Theme API path was not added added to security config path. As a result, themes in published mode in public apps were not loaded. This PR fixes that issue.

commit 7aa6a20
Merge: 1eb1a9e 1c9cb18
Author: Daniel <[email protected]>
Date:   Sun Mar 6 18:48:03 2022 +0100

    Merge pull request #11493 from appsmithorg/fix/reword-datasource-message

    fix: reword datasource message

commit 1eb1a9e
Author: Parthvi12 <[email protected]>
Date:   Sun Mar 6 23:14:17 2022 +0530

    test: adding MySQL noise test (#11469)

    * adding MySQL noise test

    * fixed git tests

    * updating git tests

commit c346af6
Author: f0c1s <[email protected]>
Date:   Sat Mar 5 18:50:33 2022 +0530

    chore: update icons in org menu (#11548)

    * chore: update icons in org menu
    * chore: update user-heart-line and update org menu
    * chore: use member instead of members for icon name

commit 15cd285
Author: f0c1s <[email protected]>
Date:   Sat Mar 5 14:21:25 2022 +0530

    fix: remove EDIT button (#11356)

commit dde1eb1
Author: Anagh Hegde <[email protected]>
Date:   Sat Mar 5 14:00:29 2022 +0530

    Add check for default branch before deleting branch (#11631)

commit e576ac0
Author: Ayangade Adeoluwa <[email protected]>
Date:   Sat Mar 5 01:45:48 2022 +0100

    Default action config values not being set (#11632)

commit bd69eb9
Author: Aishwarya-U-R <[email protected]>
Date:   Sat Mar 5 01:01:35 2022 +0530

    test: Automated tests for Bug #10784 + Failure fixes (#11586)

    * Scripting Bug # 10784

    * Bug 10784 - added script

    * Uncommenting - JSObjToInput spec

    * Uncommenting - JSObjtoListWidget spec

    * SelectEntityByName reverted

    * Migration spec locators fix

    * Table_GeneralProp spec updated

    * Read Table Row/Column locator updated

    * Calling WaitAutoSave in JSObj creation

    * 19px to 28px to match CI run

    * CreateJSObject() - adding back wait time

    * Reverting 28px to 19px

    * Commenting table specs until CI fixed

    * Commenting table spec 9th case

    * UNcommenting

    * Commenting Table_GeneralProp failure case

commit f610033
Author: Apeksha Bhosale <[email protected]>
Date:   Fri Mar 4 15:51:33 2022 +0530

    removed default isAsync false from new js action (#11427)

    Co-authored-by: Rishabh-Rathod <[email protected]>

commit cde48bf
Author: Shrikant Sharat Kandula <[email protected]>
Date:   Fri Mar 4 15:16:58 2022 +0530

    Don't provide extra information on forgot password (#11596)

commit 43441bf
Author: Vicky Bansal <[email protected]>
Date:   Fri Mar 4 14:26:16 2022 +0530

    feat: add tooltip to column header text which overflows (#10666)

    * feature: add tooltip to column header text which overflows (#10495)

    * remove unused import

    * feature: add tooltip to column header text which overflows (#10495)

    * remove unused styled components

    * remove unused import

    * feature: add tooltip to column header text which overflows (#10495)

    * remove unused styled components

    * remove unused import

    * Fix cypress command to handle the new changes

    * Fix cypress command to handle the new changes

    * Fix cypress command to handle the new changes

    * Fix: test issues

    Co-authored-by: Tolulope Adetula <[email protected]>

commit 26d06c4
Author: Paul Li <[email protected]>
Date:   Fri Mar 4 14:51:10 2022 +0800

    fix: Aspect ratio of video changes when Camera widget is longer in width than the aspect ratio (#11453)

commit ef89f3f
Author: Aswath K <[email protected]>
Date:   Fri Mar 4 12:15:50 2022 +0530

    feat: Make icon selector keyboard accessible (#10460)

    * feat: virtualize icon rendering makes icon selector smoother

    * make icon selector keyboard accessible

commit caab37d
Author: Nayan <[email protected]>
Date:   Fri Mar 4 12:32:48 2022 +0600

    feat: Add new API to combine get application details and get pages API (#11448)

    Merges the get application details and get page list API into one. This API takes either applicationId or pageId and returns the list of pages of that application.

commit 1688757
Author: Ankita Kinger <[email protected]>
Date:   Fri Mar 4 11:56:12 2022 +0530

    fix: Signup text update & code optimisation (#11606)

    * text change for signup admin settings & code optimized

    * minor change

commit e0e0fc8
Author: Apeksha Bhosale <[email protected]>
Date:   Fri Mar 4 11:06:13 2022 +0530

    added event to stop loading (#11597)

commit 13d6450
Author: Abhijeet <[email protected]>
Date:   Thu Mar 3 23:06:34 2022 +0530

    chore: Soft delete resources across Appsmith board for delete operation (#11555)

    * Soft delete resources

    * Add TC and migrations

commit 406fa0c
Author: devnamrits <[email protected]>
Date:   Thu Mar 3 22:08:44 2022 +0530

    fix: firestore queries asterisk (#11599)

    * fix: remove asterisk from non-mandatory fields in firestore query

    * making one false

    * fix: remove asterisk from non-mandatory fields in firestore query

    * fix: remove asterisk from non-mandatory fields in firestore query

    Co-authored-by: Hritik Kumar <[email protected]>

commit 5c187d6
Author: Ayush Pahwa <[email protected]>
Date:   Thu Mar 3 21:12:02 2022 +0530

    fix: Drop down multiselect usage fixes for query forms (#11465)

    * Update: Type for initialValues

    - Added string[] to the initialValues type to allow dropdowns to have multiple values too

    * Remove: Old projection selector file

    - Removed projection selector file
    - The new usage will be the old drop down file with new options

    * Update: Dropdown file

    - Added options to select and deselect the multiple drop down options
    - Added functions to handle selection and deselection
    - Added option in final render method to allow searching
    - Handled default values for multi select and single select drop downs

    * Update FormControlRegistry.tsx

    - Updated projection component to point to drop down component with extra options

    * Update: Fixed logic for dropdown select

    - Fixed the if condition blocks to catch the case when the multiselect output is not an array

commit b25441f
Author: Ayangade Adeoluwa <[email protected]>
Date:   Thu Mar 3 16:32:59 2022 +0100

    Fix apiContentType bug (#11600)

commit 8b1638a
Author: Nidhi <[email protected]>
Date:   Thu Mar 3 19:26:55 2022 +0530

    chore: Modified plugin config aggregation logic (#11561)

    * fix: Modified plugin config aggregation logic

    * Modified logs a bit

    * Reverted incorrect path from another branch

commit a905b33
Author: Ankita Kinger <[email protected]>
Date:   Thu Mar 3 18:49:10 2022 +0530

    fix: Remove reset password button if form login is disabled (#11591)

    * increased restart server timeout & showing reset pwd only if form login is enabled

    * Updated callout for disconnect button

    * added space

commit 2f7d862
Author: Yash Vibhandik <[email protected]>
Date:   Thu Mar 3 04:03:26 2022 -0800

    fix: #11301 filter pane text css updated (#11410)

commit 1c9cb18
Author: Segun Daniel Oluwadare <[email protected]>
Date:   Mon Feb 28 12:27:26 2022 +0100

    fix: reword datascource message

commit d89e12e
Author: Anand Srinivasan <[email protected]>
Date:   Thu Mar 3 16:29:52 2022 +0530

    fix: warning message - if child property doesn't exist in data tree (#10351)

    * makeParentsDependOnChild - return if child doesn't exist in allKeys

    * add unit tests

    * add nested object to unit test

    * fix unit tests

    * fix unit tests

    * add warning messages

    * add comments for mock

commit 65aee7f
Author: akash-codemonk <[email protected]>
Date:   Thu Mar 3 16:26:53 2022 +0530

    feat: Application templates (#10964)

commit 9b075e5
Author: NandanAnantharamu <[email protected]>
Date:   Thu Mar 3 16:24:44 2022 +0530

    test: bugAutomation4136 (#11245)

    * bugAutomation4136

    * Added tests for bug 5134 / 4136

    * updated test data

    * Bug7258 automated

commit eb34255
Author: Apeksha Bhosale <[email protected]>
Date:   Thu Mar 3 13:12:23 2022 +0530

    fix: removing unnecessary paths to evaluate (#11341)

    * removing unnecessary paths to evaluate

    * created regex and small refactor

commit d57207d
Author: Nidhi <[email protected]>
Date:   Thu Mar 3 12:00:55 2022 +0530

    fix: Changed test class reference to CE (#11578)

commit a0dc77a
Merge: 18220d4 18192ba
Author: Arpit Mohan <[email protected]>
Date:   Wed Mar 2 17:51:15 2022 +0530

    Merge pull request #11554 from appsmithorg/release

    ci: Release v1.6.14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Provide option to delete branch with in the Application
2 participants