-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Wait for evaluation before completing resetWidget and storeValue functions #11178
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/get-appsmith/appsmith/Ah5N7HXcXZYFmbmAYbyLZNUnhCLa |
Unable to find test scripts. Please add necessary tests to the PR. |
/ok-to-test sha=91366c6 |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1846620455. |
/ok-to-test sha=7b39b0c |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1851534973. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
If we don't let the evaluation finish before completing resetWidget and storeValue, next function in promise chain is executed before it's effects are reflected in the data tree
Fixes #11110
Type of change
How Has This Been Tested?
TODO
Checklist:
Test coverage results 🧪
🔴 Total coverage has decreased