Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: js editor not showing falsy values 🐞 #10946

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

ohansFavour
Copy link
Contributor

@ohansFavour ohansFavour commented Feb 7, 2022

Description

Fixes #9668

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: fix/js-editor-not-showing-falsy-result-values 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 54.98 (-0.01) 36.31 (-0.01) 34.68 (0) 55.37 (0)
🟢 app/client/src/components/editorComponents/CodeEditor/codeEditorUtils.ts 95.65 (0) 95 (5) 71.43 (0) 95 (0)
🔴 app/client/src/components/editorComponents/CodeEditor/index.tsx 66.67 (-0.33) 40.22 (-0.46) 51.22 (0) 66.55 (-0.36)
🔴 app/client/src/utils/autocomplete/TernServer.ts 52.71 (-0.23) 40.83 (-0.84) 36.21 (0) 56.74 (-0.25)

@vercel
Copy link

vercel bot commented Feb 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/get-appsmith/appsmith/22dYryPbmnvRNBe2Y7aDQRAqjj1e
✅ Preview: https://appsmith-git-fix-js-editor-not-showing-fals-6f3cac-get-appsmith.vercel.app

@github-actions github-actions bot added the Bug Something isn't working label Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

4 similar comments
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@ohansFavour
Copy link
Contributor Author

/ok-to-test sha=9799351

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1808260400.
Workflow: Appsmith External Integration Test Workflow.
Commit: 9799351.
PR: 10946.

@ohansFavour ohansFavour changed the title fix: js editor not showing falsy values fix: js editor not showing falsy values 🐞 Feb 7, 2022
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1808260400.
Commit: 9799351.
Results:

Click to view performance test results

Run 1 Run 2 Run 3 Run 4 Run 5 Median Mean SD.Sample SD.Population
Click on table row
scripting 2250.05 2283.4 2596.16 2209.1 2169.91 2250.05 2301.72 7.39 6.61
painting 32.35 30.13 29.06 14.08 16.97 29.06 24.52 34.09 30.51
rendering 273.41 364.35 293.17 272.98 251.28 273.41 291.04 14.97 13.39
Edit input
scripting 304.31 364.18 311.13 287.69 290.31 304.31 311.52 9.95 8.90
painting 5.39 36.03 9.72 15.71 4.21 9.72 14.21 91.48 81.84
rendering 23.02 16.14 15.14 14.44 15.35 15.35 16.82 20.93 18.73
Clear input
scripting 749.25 751.58 766.35 1030.62 757.21 757.21 811 15.16 13.56
painting 5.59 10.66 7.61 6.34 11.98 7.61 8.44 32.82 29.38
rendering 186.83 185.8 181.88 192.78 178.92 185.8 185.24 2.84 2.54
Edit input again
scripting 300.43 316.45 306.11 294.96 308.17 306.11 305.22 2.66 2.38
painting 6.39 6.06 10.23 6.41 5.54 6.39 6.93 27.13 24.24
rendering 20.51 21.43 23.9 19.88 20.65 20.65 21.27 7.38 6.58

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Unable to find test scripts. Please add necessary tests to the PR.

@trishaanand trishaanand merged commit a1a774f into release Feb 10, 2022
@trishaanand trishaanand deleted the fix/js-editor-not-showing-falsy-result-values branch February 10, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: JS editor response window is empty for falsy values
3 participants