Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returning validation failures while creating organization #1084

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Returning validation failures while creating organization #1084

merged 4 commits into from
Oct 15, 2020

Conversation

pc9795
Copy link
Contributor

@pc9795 pc9795 commented Oct 8, 2020

Description

This PR handles the exceptions which are thrown by the validation API. Also added a clear message for validation failure when creating an organization with no "name" field.

Fixes #604

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manually using Postman
  • Unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@pc9795 pc9795 marked this pull request as ready for review October 9, 2020 01:28
@mohanarpit mohanarpit merged commit 67ef538 into appsmithorg:release Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Wrong error message while trying to create an organization with no name
3 participants