-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide option in phone input widget to turn off auto formatting #10832
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/get-appsmith/appsmith/4GU4jc5mb239HaqRAvbGs1LFq2m7 |
app/client/cypress/integration/Smoke_TestSuite/ClientSideTests/FormWidgets/Phone_input_spec.js
Show resolved
Hide resolved
/ok-to-test sha=186266c |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1784288149. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1784288149. Click to view performance test results
|
@sbalaji1192 tested this PR. DP looks good Moving to Done |
@@ -121,26 +135,40 @@ class PhoneInputWidget extends BaseInputWidget< | |||
} | |||
|
|||
static getDerivedPropertiesMap(): DerivedPropertiesMap { | |||
return _.merge(super.getDerivedPropertiesMap(), { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason to remove the merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value
is not a derived property anymore. super.getDerivedPropertiesMap() returns {value: "{{this.text}}"
so removed it.
f8e35b9
to
a0a067c
Compare
@sbalaji1192 Retested this PR for #10806 & #10859. Everything is working good. Tested for migration too. Nothing seems to break. |
/ok-to-test sha=a0a067c |
Tests running at: https://github.com/appsmithorg/appsmith/actions/runs/1823530599. |
UI Performance test run logs and artifacts: https://github.com/appsmithorg/appsmith/actions/runs/1823530599. Click to view performance test results
|
Description
Fixes #10806
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🟢 Total coverage has increased