Fix the hidden column list is not bounded and overflows in height (#981) #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nikhil-Nandagopal
approved these changes
Oct 8, 2020
A-Scratchy
deleted the
fix/The-hidden-column-list-is-not-bounded-and-overflows-in-height-#981
branch
Nikhil-Nandagopal
added a commit
that referenced
this pull request
Oct 12, 2020
* Update README.md * Updating README to add contributor section (#870) * Remove gitlab-ci configuration files (#865) We have since moved our CI to Github Actions and no longer require Gitlab CI config files. * Updating the README in the client codebase We now reference the global contribution guide directly * Feature/share app test (#843) * Add ShareApp test * Sharing app tests and public access * Update CONTRIBUTING.md * Update install.sh fixes #889 * Update deploy install script to use api64.ipify.org which supports IPv4 (#887) Co-authored-by: Nikhil Nandagopal <[email protected]> * Id value issue for radio groups (#895) Fixes: #661 There was issue related to id value while creating new radio group options other than the default ones. And as said I, the id field is not needed at all, but some old config still has the id field. So since ID field is not required , I have removed it. Which solves the issue. * Fix triggering of onChange when value is the same (#892) Fixes: #710 * Invite user modal in view mode can be closed by clicking outside (#906) * Update README.md Spelling correction * #678 Correction in contributing.md for client setup (#907) Co-authored-by: Saket Agrawal <[email protected]> * Docs: Add instructions in client setup for any port conflicts with 80/443 (#918) Co-authored-by: Arpit Mohan <[email protected]> * Fix(sign-up): change in sign up error message (#908) * Fix(backend): Wrong error message while resetting the password fixed, changed from id to email (#911) Fixes #637 * Options Validaor checks for empty values Fixes: #662 * fix: add missed error callback for download (#912) Fixes: #673 * Revert "Options Validaor checks for empty values" This reverts commit 6b49d4c. * Update table icon (#761) * style: center login form when 3rd party auth is not enabled (#919) * style: center login form when 3rd party auth is not enabled * style: center signup form when 3rd party auth is not enabled * fix: input widget number validation #768 (#917) * Explorer fixes (#689) * Make entity icon an actionable area Persist user toggled entity collapse states * remove dependency on props.isDefaultExpanded * Hover effect for dependencies * Pass search keyword for reliable toggling of entity groups on entity search * Fix default expanded state of Datasource group entity * Remove plugingroup file, which was added due to a botched merge conflict resolution * Fix issue with radio widget crashing (#922) * fix types * Options Validaor checks for empty values Fixes: #662 Co-authored-by: Sanchit Jain <[email protected]> * Fixed the pull request template issue partially (#902) Fixes #826 * Feature: Invite modal (#927) * light and dark mode added in Invite modal * warnings removed * create org and invite user test cases fixed * Application invite design implemented * manage user icon added * button width fixed * PR feedback implemented * Improve PR template. * Remove troublesome test * Fix failing Radio tests (#931) * Possible fix for CI checkout issue * Possible fix for CI checkout issue * Fixed the ipify URL in PingScheduledTask (#1013) * Revert "Feature: Invite modal (#927)" (#1017) This reverts commit 63daf74. * Fix image widget not showing default image when image property is invalid (#882) Fixes: #760 * Fix CI checkouts for all pull_request_target steps * Local meta state in widgets (#851) * Update README.md * Fix for action execution (#1023) * Adding the condition to fix push vs pull_request_target commit checkouts * Input Widget: Parse regexp before regex validation (#884) Fixes #697 * Display warning icon for forgot password failure (#890) Fixes: #587 * Create Org Form: don't allow to use only spaces in names (#913) Also disables the submit button when invalid Fixes: #807, #621 * Auto Focus on email fields in auth screens (#923) Fixes: #610 Co-authored-by: Anshul <[email protected]> * Added check for duplicate values in Dropdown and Radio Widgets (#1011) Fixes #655 * Fix Reset password not disabled after successful reset (#1021) Fixes #636 * Fix active styles for checkbox & radio (#1061) Fixes: #994 * Add source to user sign up event (#1065) * Send separate user create event for new users (#1066) * Expand datasource entity in explorer based on some conditions (#1062) * Expand datasource entity in explorer based on some conditions * Fix test * Do not show error tost when api fails * Expand datasource entity on test success * Use email as id for users and fix signup events not being reported (#1067) * Fixing typos in the README file (#871) Co-authored-by: Arpit Mohan <[email protected]> * Forgot password submit button enable condition (#701) Fixes: #586 Co-authored-by: Anshul <[email protected]> * Adding a new email template for sending an email when an appsmith use… (#1077) * Adding a new email template for sending an email when an appsmith user's role in an organization changes. * Minor changes in text. * Fix - Distorted UI when there are too many characters in email ID #584 (#1010) * Fix - Distorted UI when there are too many characters in email ID #584 * Fix - Distorted UI when there are too many characters in email ID #584 * Fix the hidden column list is not bounded and overflows in height (#981) (#1024) * fix(applications): add validation for empty name (#914) * Update CONTRIBUTING.md * Update CodeContributionsGuidelines.md * replaced dragdrop with dsl (#1081) * Fix datasource structure test (#1080) * Fix datasource structure test * Dummy commit * CI: Try creating build id * CI: Fix build id step: * Revert build id changes * Update README.md * Fix/new ui is distorted due to long organization name #735 (#1014) * Fix for long org names on side menu. Now ellipsizes with tooltip if Orgname is over the value set in ellipsize prop. Otherwise functions as before. * added ellipsize prop to index. Fixes #735 20 seems to be a good value that stop org names running onto next line. Tested on Firefox and chrome. Linux debian stretch. Co-authored-by: root <[email protected]> * Use username instead of object_id in analytics (#1082) * Adding the close-label.yml file required by Github App to mark issues as QA (#1091) Fixes #1090 When a PR is successfully merged, the Github bot will add the label QA to the issue. These issues can then be picked up by the QA team for verification. Refer: https://github.com/Logerfo/close-label * Only mark applications as example applications if the application id exists in the template configuration. (#1093) * docs: add mohanarpit as a contributor (#1095) * docs: update README.md [skip ci] * docs: create .all-contributorsrc [skip ci] * Moving the contributor badge to the correct location in README Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Arpit Mohan <[email protected]> * docs: add Nikhil-Nandagopal as a contributor (#1096) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Arpit Mohan <[email protected]> * docs: add areyabhishek as a contributor (#1097) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add trishaanand as a contributor (#1098) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add riodeuno as a contributor (#1099) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add hetunandu as a contributor (#1100) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Trisha Anand <[email protected]> * docs: add satbir121 as a contributor (#1106) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Arpit Mohan <[email protected]> * docs: add sharat87 as a contributor (#1102) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Arpit Mohan <[email protected]> * docs: add aakashDesign as a contributor (#1107) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add Debsourabh as a contributor (#1108) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add NandanAnantharamu as a contributor (#1103) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Arpit Mohan <[email protected]> * docs: add prapullac as a contributor (#1104) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Arpit Mohan <[email protected]> * docs: add Saket2 as a contributor (#1109) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add harishkotra as a contributor (#1110) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add visibleajay as a contributor (#1111) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add akbansa as a contributor (#1112) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add gogetter22 as a contributor (#1113) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * docs: add Xniveres as a contributor (#1114) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * Correcting hyperlink from contributor badge to contributor section * Show datasource structure fixes (#1078) * Tests for binding related use cases (#1116) Co-authored-by: Nandan <[email protected]> * Feature/video widget test (#1115) Co-authored-by: nandan.anantharamu <[email protected]> * Adding filter tests for table (#1117) Co-authored-by: nandan.anantharamu <[email protected]> * Getting Cypress to work correctly for internal pull requests (#1121) * Hotfix to fix the client build workflow * Update README.md * Fix release cleanup issues (#1132) * Changed CSS to prevent share button from coming out (#925) Changed CSS to prevent share button from coming out. Decreased the width of the wrapper to a suitable value. * Fix issue with setting dynamic triggers on immutable widget objects (#1137) * Feature/invitation modal (#938) * light and dark mode added in Invite modal * warnings removed * create org and invite user test cases fixed * Application invite design implemented * manage user icon added * button width fixed * PR feedback implemented * test cases fixed * used blueprint classes * used calc for width distribution * copy button width fixed * prop passing fixed * copy button size reduced * readonly input field background color fixed * input background theme name ordering changed * TagInputComponent moved to ads * created DropdownWrapper for select field in orgInviteForm * Warnings created due to unique key and depdencies is fixed * Warning fixed in dropdown component * correct prop name used Co-authored-by: Rohit Kumawat <[email protected]> * fix(codemirror-autocomplete): show selection background on hover for options (#1134) This fix if merged shows the selection background by hovering on autocomplete options. Ref: #946 * Stop expanding datasource in explorer after testing (#1138) Co-authored-by: areyabhishek <[email protected]> Co-authored-by: Arpit Mohan <[email protected]> Co-authored-by: Ari <[email protected]> Co-authored-by: NandanAnantharamu <[email protected]> Co-authored-by: jack1142 <[email protected]> Co-authored-by: Sanchit Jain <[email protected]> Co-authored-by: Nicholas <[email protected]> Co-authored-by: Aditya Vats <[email protected]> Co-authored-by: Saket2 <[email protected]> Co-authored-by: Saket Agrawal <[email protected]> Co-authored-by: MartinT <[email protected]> Co-authored-by: Dmitriy Danilov <[email protected]> Co-authored-by: Petro Popelyshko <[email protected]> Co-authored-by: Hetu Nandu <[email protected]> Co-authored-by: akash-codemonk <[email protected]> Co-authored-by: Abhinav Jha <[email protected]> Co-authored-by: Omkar Phansopkar <[email protected]> Co-authored-by: devrk96 <[email protected]> Co-authored-by: Prashant Chaubey <[email protected]> Co-authored-by: satbir121 <[email protected]> Co-authored-by: Ajay Kumar <[email protected]> Co-authored-by: Arpit Mohan <[email protected]> Co-authored-by: dodococo <[email protected]> Co-authored-by: Josh Mak <[email protected]> Co-authored-by: Anshul Bansal <[email protected]> Co-authored-by: Anshul <[email protected]> Co-authored-by: Caitlin-Fotheringham <[email protected]> Co-authored-by: Akash Hamirwasia <[email protected]> Co-authored-by: Yash Joshi <[email protected]> Co-authored-by: Shrikant Sharat Kandula <[email protected]> Co-authored-by: Aadhitya A <[email protected]> Co-authored-by: Trisha Anand <[email protected]> Co-authored-by: Kishore <[email protected]> Co-authored-by: Adam <[email protected]> Co-authored-by: root <[email protected]> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Nandan <[email protected]> Co-authored-by: Ishaan Mehta <[email protected]> Co-authored-by: Thakur Karthik <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hidden column list has now been bounded and had a scroll bar added.
Spacing added between name and Icon.
Text clipped for very long column names and width now bounded.
Before fix
After fix
Fixes #981
Type of change
How Has This Been Tested?
Tested manually and verified on the following systems.
Checklist: