Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the top input type to an open field (Select) #34568

Closed
carinanfonseca opened this issue Jun 27, 2024 · 0 comments · Fixed by #34574 or #34619
Closed

Change the top input type to an open field (Select) #34568

carinanfonseca opened this issue Jun 27, 2024 · 0 comments · Fixed by #34574 or #34619
Assignees
@rahulbarwal
Labels
Select Widget Select or dropdown widget Task A simple Todo Widgets & Blocks Pod This label assigns issues to the widgets & blocks pod

Comments

@carinanfonseca
Copy link
Contributor

carinanfonseca commented Jun 27, 2024 •
edited
Loading

Users are confused how to add static data to a select widget: https://fathom.video/calls/109679577

all details
@Nikhil-Nandagopal Nikhil-Nandagopal added the Task A simple Todo label Jun 27, 2024
@carinanfonseca carinanfonseca added the Select Widget Select or dropdown widget label Jun 27, 2024
@github-actions github-actions bot added the Widgets & Blocks Pod This label assigns issues to the widgets & blocks pod label Jun 27, 2024
@carinanfonseca carinanfonseca changed the title Change the top input type to an open field Change the top input type to an open field (Select) Jun 27, 2024
@carinanfonseca carinanfonseca removed the Widgets & Blocks Pod This label assigns issues to the widgets & blocks pod label Jun 27, 2024
@github-actions github-actions bot added the Widgets & Blocks Pod This label assigns issues to the widgets & blocks pod label Jun 27, 2024
@rahulbarwal rahulbarwal mentioned this issue Jun 28, 2024
Merged
2 tasks
@rahulbarwal rahulbarwal self-assigned this Jun 28, 2024
@rahulbarwal rahulbarwal mentioned this issue Jul 2, 2024
Merged
2 tasks
@rahulbarwal rahulbarwal reopened this Jul 2, 2024
rahulbarwal added a commit that referenced this issue Jul 3, 2024
@rahulbarwal
feat: Refactor SelectWidget sourceData handling (#34619)
ce93059 
## Description
This pull request refactors the sourceData handling in the SelectWidget
component. It introduces a dynamic property path for the sourceData in
the SelectWidget configuration, allowing it to be passed as a JSON
string.

This change ensures that the source data matches the sample data passed
for the widget configuration, enabling the switching back of the JS
toggle button.

Additionally, it fixes cypress tests: opening of the prop pane in JS
mode.


Fixes #34568
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Widget, @tag.Select, @tag.Binding"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9758347627>
> Commit: 01e5b4f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9758347627&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.Select, @tag.Binding`
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved stability of test scenarios by ensuring JavaScript mode is
toggled appropriately.

- **Tests**
- Updated test cases to include JavaScript mode toggling for more
accurate test outcomes.
- Renamed and restructured test files to enhance clarity and
maintainability.

- **New Features**
- Enhanced `SelectWidget` to initialize `sourceData` with a stringified
array and made `sourceData` dynamically configurable.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Jul 10, 2024
@rahulbarwal @Shivam-z
feat: Add dynamic property path for sourceData in SelectWidget (appsm…
9ff9bca 
…ithorg#34574)

## Description
Add dynamic property path for sourceData in SelectWidget.

Fixes appsmithorg#34568
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Widget"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9712372976>
> Commit: c5521e4
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9712372976&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget`

<!-- end of auto-generated comment: Cypress test results  -->









## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced the Select Widget with a new property to support dynamic
property paths.
- **Tests**
- Added new tests to validate the dynamic property paths functionality
in the Select Widget.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Shivam-z pushed a commit to Shivam-z/appsmith that referenced this issue Jul 10, 2024
@rahulbarwal @Shivam-z
feat: Refactor SelectWidget sourceData handling (appsmithorg#34619)
e2ecc9e 
## Description
This pull request refactors the sourceData handling in the SelectWidget
component. It introduces a dynamic property path for the sourceData in
the SelectWidget configuration, allowing it to be passed as a JSON
string.

This change ensures that the source data matches the sample data passed
for the widget configuration, enabling the switching back of the JS
toggle button.

Additionally, it fixes cypress tests: opening of the prop pane in JS
mode.


Fixes appsmithorg#34568
_or_  
Fixes `Issue URL`
> [!WARNING]  
> _If no issue exists, please create an issue first, and check with the
maintainers if the issue is valid._

## Automation

/ok-to-test tags="@tag.Widget, @tag.Select, @tag.Binding"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9758347627>
> Commit: 01e5b4f
> <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9758347627&attempt=1"
target="_blank">Cypress dashboard</a>.
> Tags: `@tag.Widget, @tag.Select, @tag.Binding`
<!-- end of auto-generated comment: Cypress test results  -->


## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved stability of test scenarios by ensuring JavaScript mode is
toggled appropriately.

- **Tests**
- Updated test cases to include JavaScript mode toggling for more
accurate test outcomes.
- Renamed and restructured test files to enhance clarity and
maintainability.

- **New Features**
- Enhanced `SelectWidget` to initialize `sourceData` with a stringified
array and made `sourceData` dynamically configurable.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahulbarwal rahulbarwal

Labels
Select Widget Select or dropdown widget Task A simple Todo Widgets & Blocks Pod This label assigns issues to the widgets & blocks pod
Projects
None yet
Milestone
No milestone
3 participants
@Nikhil-Nandagopal @rahulbarwal @carinanfonseca