test: updated flaky test for iframe (#28258)

appsmithorg · Oct 23, 2023 · 15f380e · 15f380e
1 parent 2377a69
commit 15f380e
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/app/client/cypress/e2e/Regression/ClientSide/Widgets/Iframe/IframeTest_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Widgets/Iframe/IframeTest_spec.ts
@@ -3,6 +3,7 @@ import {
  locators,
  entityExplorer,
  propPane,
+ deployMode,
 } from "../../../../../support/Objects/ObjectsCore";
 
 import testdata from "../../../../../fixtures/testdata.json";
@@ -113,20 +114,22 @@ describe("Iframe widget Tests", function () {
  agHelper.ValidateToastMessage("URL Changed");
  });
 
- // Border Color is failing Skipping to unblock - Fixing it in a separate PR by 20/10/2023
- it.skip("3. Verify colors, borders and shadows", () => {
+ it("3. Verify colors, borders and shadows", () => {
  propPane.MoveToTab("Style");
 
- // Border Color
+ // Change Border Color
  propPane.SelectColorFromColorPicker("bordercolor", 10);
- agHelper.AssertCSS("iframe", "border-color", "rgb(185, 28, 28)");
 
- // Verify border
+ // Change  border
  agHelper.GetNClick(propPane._segmentedControl("0px"));
- agHelper.AssertCSS("iframe", "border-radius", "0px");
 
- // Verify Box Shadow
+ // Change  Box Shadow
  agHelper.GetNClick(`${propPane._segmentedControl("0")}:contains('Large')`);
+
+ //Verify details in Deploy mode
+ deployMode.DeployApp();
+ agHelper.AssertCSS("iframe", "border-color", "rgb(185, 28, 28)");
+ agHelper.AssertCSS("iframe", "border-radius", "0px");
  agHelper.AssertCSS(
  "iframe",
  "box-shadow",

diff --git a/app/client/cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts b/app/client/cypress/e2e/Regression/ClientSide/Widgets/Others/IconButton_2_spec.ts
@@ -67,10 +67,11 @@ describe("Icon Button widget Tests", function () {
  it("3. Validate icon can be selected from dropdown and icon can be searched by typing", () => {
  // Select from dropdown
  agHelper.GetNClick(`${locators._propertyControl}icon`);
- agHelper.GetNClick(propPane._dataIcon("power"));
+ agHelper.GetElement(propPane._iconDropdown).scrollTo("top");
+ agHelper.GetNClick(propPane._dataIcon("airplane"));
  agHelper.AssertElementVisibility(
  `${locators._widgetInDeployed("iconbuttonwidget")} ${propPane._dataIcon(
- "power",
+ "airplane",
  )}`,
  );
 

diff --git a/app/client/cypress/support/Pages/PropertyPane.ts b/app/client/cypress/support/Pages/PropertyPane.ts
@@ -169,6 +169,8 @@ export class PropertyPane {
  control;
 
  _dataIcon = (icon: string) => `[data-icon="${icon}"]`;
+ _iconDropdown = "[data-test-id='virtuoso-scroller']";
+
  public OpenJsonFormFieldSettings(fieldName: string) {
  this.agHelper.GetNClick(this._jsonFieldEdit(fieldName));
  }