Add reporter based on the command line diff tool
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that when verification fails, the test runner will report the line of code in your test that calls the verifier instead of a line of code within the library.
It's unnecessary and unidiomatic. Interfaces can be satisfied by pointers or values.
The name DiffReporter was already taken by the composite reporter of all the other reporters, so I came up with the name RealDiffReporter for this one.
|
Nice work @christoffer-thomsen ! I'm not a maintainer of this library, but as long as there are some automatic tests for the provided features I think this should just be merged 😊🎉 |
|
great stuff, happy to have your input. Thankyou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On behalf of my employer, Maersk, I am contributing this PR which consists of three changes:
difftool. The implementation is straight forwardly adapted from the other reporters. I believe adding this reporter will fix issue Logging diff on approval failure #27 in many cases given that Linux servers are likely to have some version ofdiffinstalled.Looking forward to your feedback.
Thanks,
Christoffer G. Thomsen
Senior Software Engineer
Maersk