Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] heap-overflow in get.c:344 #735

Closed
chluo1997 opened this issue Jul 24, 2022 · 1 comment
Closed

[Bug] heap-overflow in get.c:344 #735

chluo1997 opened this issue Jul 24, 2022 · 1 comment
Assignees

Comments

@chluo1997
Copy link

You are opening a bug report against the Tcpreplay project: we use
GitHub Issues for tracking bug reports and feature requests.

If you have a question about how to use Tcpreplay, you are at the wrong
site. You can ask a question on the tcpreplay-users mailing list
or on Stack Overflow with [tcpreplay] tag.
General help is available here.

If you have a build issue, consider downloading the latest release

Otherwise, to report a bug, please fill out the reproduction steps
(below) and delete these introductory paragraphs. Thanks!

Describe the bug
A clear and concise description of what the bug is.
There is a heap-overflow bug in get_ipv6_next. Different from #716 (The crash point is in line 322, ntohs(eth_hdr->ether_type);), this bug is triggered in line 344 (pktdata[l2_net_off] >> 4).

To Reproduce
Steps to reproduce the behavior:

  1. export CC=clang && export CFLAGS="-fsanitize=address -g"
  2. ./autogen.sh && ./configure --disable-shared --disable-local-libopts && make clean && make -j8
  3. tcpprep --auto=bridge --pcap=POC --cachefile=/dev/null

Expected behavior
A clear and concise description of what you expected to happen.
The program does not crash.

Screenshots
If applicable, add screenshots to help explain your problem.
Screen Shot 2022-07-24 at 15 32 38

System (please complete the following information):

  • OS: Debian
  • OS version: buster
  • Tcpreplay Version: 09f0774

Additional context
Add any other context about the problem here.
POC
poc.zip

@chluo1997 chluo1997 changed the title heap-overflow in get_l2len_protocol:344 [Bug] heap-overflow in get.c:344 Jul 24, 2022
@fklassen fklassen self-assigned this Aug 7, 2022
@fklassen
Copy link
Member

fklassen commented Aug 7, 2022

Fixed overflow in PR #744

@fklassen fklassen closed this as completed Aug 7, 2022
fklassen added a commit that referenced this issue Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants