Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: re-add WithCustomClientOption, useful for unit testing. #51

Merged

Conversation

netrebel
Copy link
Contributor

Hi,

Could you re-add WithCustomClientOption?

My existing unit tests make use of WithEndpoint with a httptest.NewServer URL. But it needs to be used in combination with option.WithoutAuthentication() so that the client can be initialized correctly (see example in README).

Doing this, there's no need to have a local dummy Credentials file for unit testing.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 28.14%. Comparing base (5a7fb86) to head (b5725bc).
Report is 42 commits behind head on master.

Files Patch % Lines
option.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #51       +/-   ##
===========================================
- Coverage   84.97%   28.14%   -56.83%     
===========================================
  Files           5        3        -2     
  Lines         213      135       -78     
===========================================
- Hits          181       38      -143     
- Misses         24       89       +65     
  Partials        8        8               
Flag Coverage Δ
go-1.21 28.14% <0.00%> (?)
go-1.22 28.14% <0.00%> (?)
ubuntu-latest 28.14% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@appleboy appleboy merged commit 20c9c52 into appleboy:master May 30, 2024
5 of 7 checks passed
@appleboy
Copy link
Owner

@netrebel Thnaks.

@netrebel netrebel deleted the netrebel/add-withCustomClientOption branch May 30, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants