Suggest @preconcurrency on conformances it could help
#73741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DougGregor
requested review from
AnthonyLatsis,
hborla,
slavapestov,
ktoso and
xedin
as code owners
|
@swift-ci please smoke test |
DougGregor
force-pushed
the
suggest-preconcurrency-conformances
branch
from
ffebd09
to
523e254
Compare
|
@swift-ci please smoke test |
DougGregor
force-pushed
the
suggest-preconcurrency-conformances
branch
from
523e254
to
42d819b
Compare
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
hborla
reviewed
May 20, 2024
| @@ -2655,6 +2655,8 @@ WARNING(add_predates_concurrency_import,none, | |||
| "%select{| as warnings}0", (bool, Identifier)) | |||
| WARNING(remove_predates_concurrency_import,none, | |||
| "'@preconcurrency' attribute on module %0 has no effect", (Identifier)) | |||
| NOTE(add_preconcurrency_to_conformance,none, | |||
| "add '@preconcurrency' to the %0 conformance to suppress isolation-related diagnostics", (DeclName)) | |||
There was a problem hiding this comment.
Instead of just saying this will suppress diagnostics, should we say that applying @preconcurrency will switch from static isolation diagnostics to dynamic ones? I think this should somehow mention that you're opting into dynamic assertions by doing this.
There was a problem hiding this comment.
That is a great point! Thank you!
|
@swift-ci please smoke test Linux |
|
@swift-ci please clean smoke test Linux |
DougGregor
force-pushed
the
suggest-preconcurrency-conformances
branch
from
aa63d7a
to
9e26152
Compare
|
@swift-ci please smoke test |
DougGregor
force-pushed
the
suggest-preconcurrency-conformances
branch
from
9e26152
to
8a94990
Compare
|
@swift-ci please smoke test |
When diagnosing a case where an actor-isolated witness cannot satisfy a non-isolated requirement, also suggest that the conformance could be annotated with `@preconcurrency`.
DougGregor
force-pushed
the
suggest-preconcurrency-conformances
branch
from
8a94990
to
5a0e70a
Compare
|
@swift-ci please clean smoke test |
|
@swift-ci please clean test Linux |
|
@swift-ci please clean smoke test Linux |
|
@swift-ci please test Linux |
xedin
approved these changes
May 21, 2024
| @@ -573,6 +573,8 @@ class NormalProtocolConformance : public RootProtocolConformance, | |||
| Context(dc) { | |||
| assert(!conformingType->hasArchetype() && | |||
| "ProtocolConformances should store interface types"); | |||
| assert((preconcurrencyLoc.isInvalid() || isPreconcurrency) && | |||
| "Cannot have a @preconcurrency location without isPreconcurrency"); | |||
We moved some diagnostics around, which ended up breaking some downstream tests that we don't want to break. Restore the location.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When diagnosing a case where an actor-isolated witness cannot satisfy a non-isolated requirement, also suggest that the conformance could be annotated with
@preconcurrency.