Re-enable StringNormalization validation test #73714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test macOS platform |
|
Failure is unrelated (compiler crashed while building DocC 🤷♂️). Still...
|
|
@swift-ci please test macOS platform |
|
@Azoy since you originally disabled this test, can you advise whether this looks safe to merge? It certainly seems okay to me, but I wouldn't want to risk breaking any internal systems by re-enabling it. I plan to expand this file with some additional tests (for new, related APIs) and enable it on other platforms, but as a first step it would be nice to re-enable what is here. Thanks! |
|
@swift-ci please test linux platform |
|
@swift-ci please test windows platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test works for me. It's Darwin-only as well, so if it also works on CI, it's probably fine? Let's see.