Add back alloc limits script with JSON mode #2987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: We removed the alloc limits script, but it is still very useful. It just couldn't produce JSON. So now it can! Modifications: Re-adds the alloc limits script. Makes it produce JSON. Result: JSON can be produced from the CI output.
glbrntt
approved these changes
Nov 21, 2024
Lukasa
added a commit
to Lukasa/swift-nio
that referenced
this pull request
Nov 22, 2024
Motivation: We removed the alloc limits script, but it is still very useful. It just couldn't produce JSON. So now it can! Modifications: Re-adds the alloc limits script. Makes it produce JSON. Result: JSON can be produced from the CI output. (cherry picked from commit 035d3a5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
We removed the alloc limits script, but it is still very useful. It just couldn't produce JSON. So now it can!
Modifications:
Re-adds the alloc limits script.
Makes it produce JSON.
Result:
JSON can be produced from the CI output.