Add ByteBuffer support to BufferedWriter
#2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: The `BufferedWriter` in `NIOFileSystem` has API in terms of `some Sequence<UInt8>`, meaning that you need to pass `byteBuffer.readableBytesView` which is a bit inconvenient. Modifications: - Add overloads which allow you to pass `ByteBuffer` directly - Remove redundant availability guards; they are already applied to the type Result: - Better API for users - Resolves apple#2662
glbrntt
added
the
🔼 needs-minor-version-bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
The
BufferedWriterinNIOFileSystemhas API in terms ofsome Sequence<UInt8>, meaning that you need to passbyteBuffer.readableBytesViewwhich is a bit inconvenient.Modifications:
ByteBufferdirectlyResult: