Add support for SWIFTCI_USE_LOCAL_DEPS convention
#2699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To use this package in utils/build-script pipeline
Lukasa
added
the
needs-no-version-bump
|
@swift-server-bot add to allowlist |
|
@Lukasa Would you mind having a new tag to pin the version including this fix in update-checkout-config.json if possible? 🙏 |
|
Hi @kateinoigakukun: yes, we can do a release, but we don't typically do releases this late in the week, so it won't happen until early next week. |
|
Sure! Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support ci.swift.org convention
Motivation:
This package is used by https://github.com/apple/swift-sdk-generator and it needs to be built during build-script pipeline, so we need to make its dependencies follow the CI convention.
Modifications:
Changed
Package.swiftto respectSWIFTCI_USE_LOCAL_DEPSenvironment variable and use locally checked out packages if defined.Result:
We can use
swift-nio2.41.0, which is the first version with dependencies, and later in utils/build-script pipeline.CC: @MaxDesiatov