Add a NIOFileSystem shim #2689
Merged
Add a NIOFileSystem shim #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation: Renaming the `NIOFileSystem` module to `_NIOFileSystem` is a breaking change (which is okay, it's documented to be unstable API). However, users will be presented with a wall of build errors on updating to the next version of NIO. We can make the transition slightly easier for them. Modifications: Add back a `NIOFileSystem` module which re-exports `_NIOFileSystem` and add it as a target to the `_NIOFileSystem` product. This makes both modules available to users. We can then remove `NIOFileSystem` after a grace period. Result: Users can still build using `NIOFileSystem` but can transition to `_NIOFileSystem`.
glbrntt
added
the
🔼 needs-minor-version-bump
simonjbeaumont
approved these changes
Mar 22, 2024
weissi
reviewed
Apr 5, 2024
| // SPDX-License-Identifier: Apache-2.0 | ||
| // | ||
| //===----------------------------------------------------------------------===https:// | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Renaming the
NIOFileSystemmodule to_NIOFileSystemis a breaking change (which is okay, it's documented to be unstable API). However, users will be presented with a wall of build errors on updating to the next version of NIO. We can make the transition slightly easier for them.Modifications:
Add back a
NIOFileSystemmodule which re-exports_NIOFileSystemand add it as a target to the_NIOFileSystemproduct. This makes both modules available to users. We can then removeNIOFileSystemafter a grace period.Result:
Users can still build using
NIOFileSystemwhile transitioning to_NIOFileSystem.