Change BufferedReader.read(while:) signature #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
added
the
🔼 needs-minor-version-bump
glbrntt
requested changes
Mar 20, 2024
Return whether EOF read or predicate doesn't hold anymore in BufferedReader.read(while:)
glbrntt
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return whether EOF read or predicate doesn't hold anymore in
BufferedReader.read(while:).Motivation:
Using
BufferedReader.read(while:)isn't currently too nice to use because we can't differentiate between reading EOF and the predicate not holding anymore. See #2665.Modifications:
This change deprecates
BufferedReader.read(while:)and replaces it with a new version that returns not only the read bytes (as aByteBuffer) but also a boolean indicating whether we finished reading because EOF has been read, or because the predicate doesn't hold true anymore.Result:
BufferedReader.read(while:)now returns not only the read bytes (as aByteBuffer) but also a boolean indicating whether we finished reading because EOF has been read, or because the predicate doesn't hold true anymore.