Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Underscore the NIOFileSystem module #2683

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

glbrntt
Copy link
Contributor

@glbrntt glbrntt commented Mar 14, 2024

Motivation:

The 'NIOFileSystem' target isn't yet stable API and is made available via the '_NIOFileSystemModule' product. This doesn't make it obvious enough that the module isn't yet considered stable.

Modifications:

  • Rename 'NIOFileSystem' and 'NIOFileSystemFoundationCompat' such that they are prefixed with '_'.

Result:

Motivation:

The 'NIOFileSystem' target isn't yet stable API and is made available
via the '_NIOFileSystemModule' product. This doesn't make it obvious
enough that the module isn't yet considered stable.

Modifications:

- Rename 'NIOFileSystem' and 'NIOFileSystemFoundationCompat' such that
  they are prefixed with '_'.

Result:

More obviously not stable API
@glbrntt glbrntt added the 🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0 label Mar 14, 2024
@glbrntt glbrntt enabled auto-merge (squash) March 14, 2024 14:57
@glbrntt glbrntt merged commit df5745d into apple:main Mar 14, 2024
8 of 9 checks passed
@glbrntt glbrntt deleted the underscode-filesystem branch March 15, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔼 needs-minor-version-bump For PRs that when merged cause a bump of the minor version, ie. 1.x.0 -> 1.(x+1).0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NIOFileSystem module needs to be _NIOFileSystem
2 participants