Drop Swift versions earlier than 5.8 #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjcairo
force-pushed
the
drop-old-swift-versions
branch
from
5f8bb5d
to
9662e2a
Compare
ktoso
approved these changes
May 15, 2024
|
@swift-server-bot test this please |
|
Mind checking the soundness (formatting issue)? The CI jobs for old swift we'll remove. |
FranzBusch
reviewed
May 15, 2024
|
I think the soudness job just needs to be updated to use a newer docker file |
FranzBusch
approved these changes
May 15, 2024
|
No, there was an actual whitespace formatting issue - just fixed it. |
|
CI updated. @swift-server-bot test this please. |
|
@swift-server-bot test this please |
|
@swift-server-bot test this please |
|
@swift-server-bot add to allowlist |
|
@gjcairo We gotta update the breaking change checker script the same way we did in metrics. |
|
branch protection rules adjusted in github -- can you fix the api checker? |
gjcairo
force-pushed
the
drop-old-swift-versions
branch
from
595b588
to
1d302c0
Compare
ayushi2103
pushed a commit
to ayushi2103/swift-log
that referenced
this pull request
May 17, 2024
* Drop Swift versions earlier than 5.8 * Delete build_podspec.sh * Update check_no_api_breakages script
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Jun 27, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [apple/swift-log](https://togithub.com/apple/swift-log) | minor | `from: "1.5.4"` -> `from: "1.6.1"` | --- ### Release Notes <details> <summary>apple/swift-log (apple/swift-log)</summary> ### [`v1.6.1`](https://togithub.com/apple/swift-log/releases/tag/1.6.1): Swift Log 1.6.1 [Compare Source](https://togithub.com/apple/swift-log/compare/1.6.0...1.6.1) ##### SemVer Patch - Disable existential any build setting ([#​312](https://togithub.com/apple/swift-log/issues/312)) ### [`v1.6.0`](https://togithub.com/apple/swift-log/releases/tag/1.6.0) [Compare Source](https://togithub.com/apple/swift-log/compare/1.5.4...1.6.0) #### SemVer Minor - Add Sendability annotations in [apple/swift-log#308 - Fix deprecation warnings around default log implementations on handlers in [apple/swift-log#310 - Drop Swift versions earlier than 5.8 in [apple/swift-log#299 - Implement Copy-On-Write (CoW) behavior for Logger struct by [@​ayushi2103](https://togithub.com/ayushi2103) in [apple/swift-log#297 ##### SemVer Patch - Replace standardOutput to standardError by [@​ayushi2103](https://togithub.com/ayushi2103) in [apple/swift-log#295 - Use Set to spot duplicated log handler warnings in [apple/swift-log#306 - Make protocol usage obvious using any and some keywords in [apple/swift-log#307 - Remove documentation for non-existent arguments by [@​b1ackturtle](https://togithub.com/b1ackturtle) in [apple/swift-log#309 - Remove Docc plugin which is no longer required in [apple/swift-log#311 ##### Other Changes - Remove archived repository in [apple/swift-log#292 - Add CI for Swift 5.10 in [apple/swift-log#287 - Added swift-log-ecs to README.md by [@​rwbutler](https://togithub.com/rwbutler) in [apple/swift-log#298 - Update README.md add shipbook as backend by [@​elishas](https://togithub.com/elishas) in [apple/swift-log#304 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes support for Swift versions earlier than 5.8
Motivation:
Following the changes done in
swift-metricson apple/swift-metrics#141, I believe we should alignswift-logwith the rest of the ecosystem too and support only the last 3 Swift releases.Modifications:
This PR removes support for Swift versions earlier than 5.8
Result:
Only the last 3 Swift releases are now supported.